Fix for good practique code
gitea/salix/pipeline/head This commit looks good Details

This commit is contained in:
Jorge Padawan 2021-01-12 10:11:37 +01:00
parent a9eb0355d4
commit 509de4fa0a
8 changed files with 122 additions and 116 deletions

View File

@ -1,6 +1,7 @@
<vn-card class="summary"> <vn-card class="summary">
<h5> <h5>
<a ng-if="::summary.id" <a
ng-if="::summary.id"
vn-tooltip="Go to the user" vn-tooltip="Go to the user"
ui-sref="account.card.summary({id: {{::summary.id}}})" ui-sref="account.card.summary({id: {{::summary.id}}})"
name="goToSummary"> name="goToSummary">
@ -12,15 +13,15 @@
<vn-one> <vn-one>
<h4 ng-show="$ctrl.isHr"> <h4 ng-show="$ctrl.isHr">
<a <a
ui-sref="account.card.basicData({id:summary.id})" ui-sref="account.card.basicData({id:summary.id})"
target="_self"> target="_self">
<span translate vn-tooltip="Go to">Basic Data</span> <span translate vn-tooltip="Go to">Basic Data</span>
</a> </a>
</h4> </h4>
<h4 <h4
translate translate
ng-show="!$ctrl.isHr"> ng-show="!$ctrl.isHr">
Basic Data Basic Data
</h4> </h4>
<vn-label-value <vn-label-value
label="Id" label="Id"

View File

@ -4,7 +4,8 @@
</vn-crud-model> </vn-crud-model>
<vn-card class="summary"> <vn-card class="summary">
<h5> <h5>
<a ng-if="::$ctrl.summary.claim.id" <a
ng-if="::$ctrl.summary.claim.id"
vn-tooltip="Go to the claim" vn-tooltip="Go to the claim"
ui-sref="claim.card.summary({id: {{::$ctrl.summary.claim.id}}})" ui-sref="claim.card.summary({id: {{::$ctrl.summary.claim.id}}})"
name="goToSummary"> name="goToSummary">
@ -56,15 +57,15 @@
<vn-auto> <vn-auto>
<h4 ng-show="$ctrl.isSalesPerson"> <h4 ng-show="$ctrl.isSalesPerson">
<a <a
ui-sref="claim.card.detail({id:$ctrl.claim.id})" ui-sref="claim.card.detail({id:$ctrl.claim.id})"
target="_self"> target="_self">
<span translate vn-tooltip="Go to">Detail</span> <span translate vn-tooltip="Go to">Detail</span>
</a> </a>
</h4> </h4>
<h4 <h4
ng-show="!$ctrl.isSalesPerson" ng-show="!$ctrl.isSalesPerson"
translate> translate>
Detail Detail
</h4> </h4>
<vn-data-viewer data="::$ctrl.summary.salesClaimed"> <vn-data-viewer data="::$ctrl.summary.salesClaimed">
<vn-table> <vn-table>
@ -118,15 +119,15 @@
<vn-auto> <vn-auto>
<h4 ng-show="$ctrl.isClaimManager"> <h4 ng-show="$ctrl.isClaimManager">
<a <a
ui-sref="claim.card.development({id:$ctrl.claim.id})" ui-sref="claim.card.development({id:$ctrl.claim.id})"
target="_self"> target="_self">
<span translate vn-tooltip="Go to">Development</span> <span translate vn-tooltip="Go to">Development</span>
</a> </a>
</h4> </h4>
<h4 <h4
translate translate
ng-show="!$ctrl.isClaimManager"> ng-show="!$ctrl.isClaimManager">
Development Development
</h4> </h4>
<vn-data-viewer data="::$ctrl.summary.developments"> <vn-data-viewer data="::$ctrl.summary.developments">
<vn-table> <vn-table>
@ -160,15 +161,15 @@
<vn-auto> <vn-auto>
<h4 ng-show="$ctrl.isClaimManager"> <h4 ng-show="$ctrl.isClaimManager">
<a <a
ui-sref="claim.card.action({id:$ctrl.claim.id})" ui-sref="claim.card.action({id:$ctrl.claim.id})"
target="_self"> target="_self">
<span translate vn-tooltip="Go to">Action</span> <span translate vn-tooltip="Go to">Action</span>
</a> </a>
</h4> </h4>
<h4 <h4
translate translate
ng-show="!$ctrl.isClaimManager"> ng-show="!$ctrl.isClaimManager">
Action Action
</h4> </h4>
<vn-data-viewer data="::$ctrl.summary.actions"> <vn-data-viewer data="::$ctrl.summary.actions">
<vn-table> <vn-table>

View File

@ -14,15 +14,15 @@
<vn-one> <vn-one>
<h4 ng-show="$ctrl.isEmployee"> <h4 ng-show="$ctrl.isEmployee">
<a <a
ui-sref="client.card.basicData({id:$ctrl.client.id})" ui-sref="client.card.basicData({id:$ctrl.client.id})"
target="_self"> target="_self">
<span translate vn-tooltip="Go to">Basic data</span> <span translate vn-tooltip="Go to">Basic data</span>
</a> </a>
</h4> </h4>
<h4 <h4
translate translate
ng-show="!$ctrl.isEmployee"> ng-show="!$ctrl.isEmployee">
Basic data Basic data
</h4> </h4>
<vn-label-value label="Id" <vn-label-value label="Id"
value="{{$ctrl.summary.id}}"> value="{{$ctrl.summary.id}}">
@ -56,15 +56,15 @@
<vn-one> <vn-one>
<h4 ng-show="$ctrl.isEmployee"> <h4 ng-show="$ctrl.isEmployee">
<a <a
ui-sref="client.card.fiscalData({id:$ctrl.client.id})" ui-sref="client.card.fiscalData({id:$ctrl.client.id})"
target="_self"> target="_self">
<span translate vn-tooltip="Go to">Fiscal address</span> <span translate vn-tooltip="Go to">Fiscal address</span>
</a> </a>
</h4> </h4>
<h4 <h4
translate translate
ng-show="!$ctrl.isEmployee"> ng-show="!$ctrl.isEmployee">
Fiscal address Fiscal address
</h4> </h4>
<vn-label-value label="Social name" <vn-label-value label="Social name"
value="{{$ctrl.summary.socialName}}"> value="{{$ctrl.summary.socialName}}">
@ -91,15 +91,15 @@
<vn-one> <vn-one>
<h4 ng-show="$ctrl.isEmployee"> <h4 ng-show="$ctrl.isEmployee">
<a <a
ui-sref="client.card.fiscalData({id:$ctrl.client.id})" ui-sref="client.card.fiscalData({id:$ctrl.client.id})"
target="_self"> target="_self">
<span translate vn-tooltip="Go to">Fiscal data</span> <span translate vn-tooltip="Go to">Fiscal data</span>
</a> </a>
</h4> </h4>
<h4 <h4
translate translate
ng-show="!$ctrl.isEmployee"> ng-show="!$ctrl.isEmployee">
Fiscal data Fiscal data
</h4> </h4>
<vn-vertical> <vn-vertical>
<vn-check <vn-check
@ -142,15 +142,15 @@
<vn-one> <vn-one>
<h4 ng-show="$ctrl.isEmployee"> <h4 ng-show="$ctrl.isEmployee">
<a <a
ui-sref="client.card.billingData({id:$ctrl.client.id})" ui-sref="client.card.billingData({id:$ctrl.client.id})"
target="_self"> target="_self">
<span translate vn-tooltip="Go to">Billing data</span> <span translate vn-tooltip="Go to">Billing data</span>
</a> </a>
</h4> </h4>
<h4 <h4
translate translate
ng-show="!$ctrl.isEmployee"> ng-show="!$ctrl.isEmployee">
Billing data Billing data
</h4> </h4>
<vn-label-value label="Pay method" <vn-label-value label="Pay method"
value="{{$ctrl.summary.payMethod.name}}"> value="{{$ctrl.summary.payMethod.name}}">
@ -182,15 +182,15 @@
<vn-one> <vn-one>
<h4 ng-show="$ctrl.isEmployee"> <h4 ng-show="$ctrl.isEmployee">
<a <a
ui-sref="client.card.address.index({id:$ctrl.client.id})" ui-sref="client.card.address.index({id:$ctrl.client.id})"
target="_self"> target="_self">
<span translate vn-tooltip="Go to">Address</span> <span translate vn-tooltip="Go to">Address</span>
</a> </a>
</h4> </h4>
<h4 <h4
translate translate
ng-show="!$ctrl.isEmployee"> ng-show="!$ctrl.isEmployee">
Address Address
</h4> </h4>
<vn-label-value label="Name" <vn-label-value label="Name"
value="{{$ctrl.summary.defaultAddress.nickname}}"> value="{{$ctrl.summary.defaultAddress.nickname}}">
@ -205,13 +205,14 @@
<vn-one> <vn-one>
<h4 ng-show="$ctrl.isEmployee"> <h4 ng-show="$ctrl.isEmployee">
<a <a
ui-sref="client.card.webAccess({id:$ctrl.client.id})" ui-sref="client.card.webAccess({id:$ctrl.client.id})"
target="_self"> target="_self">
<span translate vn-tooltip="Go to">Web access</span> <span translate vn-tooltip="Go to">Web access</span>
</a> </a>
</h4> </h4>
<h4 translate <h4
ng-show="!$ctrl.isEmployee">Web access translate
ng-show="!$ctrl.isEmployee">Web access
</h4> </h4>
<vn-label-value label="User" <vn-label-value label="User"
value="{{$ctrl.summary.account.name}}"> value="{{$ctrl.summary.account.name}}">

View File

@ -27,15 +27,15 @@
<vn-one name="basicData"> <vn-one name="basicData">
<h4 ng-show="$ctrl.isBuyer"> <h4 ng-show="$ctrl.isBuyer">
<a <a
ui-sref="item.card.basicData({id:$ctrl.item.id})" ui-sref="item.card.basicData({id:$ctrl.item.id})"
target="_self"> target="_self">
<span translate vn-tooltip="Go to">Basic data</span> <span translate vn-tooltip="Go to">Basic data</span>
</a> </a>
</h4> </h4>
<h4 <h4
translate translate
ng-show="!$ctrl.isBuyer"> ng-show="!$ctrl.isBuyer">
Basic data Basic data
</h4> </h4>
<vn-label-value label="Name" <vn-label-value label="Name"
value="{{$ctrl.summary.item.name}}"> value="{{$ctrl.summary.item.name}}">
@ -66,15 +66,15 @@
<vn-one name="otherData"> <vn-one name="otherData">
<h4 ng-show="$ctrl.isBuyer"> <h4 ng-show="$ctrl.isBuyer">
<a <a
ui-sref="item.card.basicData({id:$ctrl.item.id})" ui-sref="item.card.basicData({id:$ctrl.item.id})"
target="_self"> target="_self">
<span translate vn-tooltip="Go to">Other data</span> <span translate vn-tooltip="Go to">Other data</span>
</a> </a>
</h4> </h4>
<h4 <h4
translate translate
ng-show="!$ctrl.isBuyer"> ng-show="!$ctrl.isBuyer">
Other data Other data
</h4> </h4>
<vn-label-value label="Intrastat code" <vn-label-value label="Intrastat code"
value="{{$ctrl.summary.item.intrastat.id}}"> value="{{$ctrl.summary.item.intrastat.id}}">
@ -101,15 +101,15 @@
<vn-one name="tags"> <vn-one name="tags">
<h4 ng-show="$ctrl.isBuyer || $ctrl.isReplenisher"> <h4 ng-show="$ctrl.isBuyer || $ctrl.isReplenisher">
<a <a
ui-sref="item.card.tags({id:$ctrl.item.id})" ui-sref="item.card.tags({id:$ctrl.item.id})"
target="_self"> target="_self">
<span translate vn-tooltip="Go to">Tags</span> <span translate vn-tooltip="Go to">Tags</span>
</a> </a>
</h4> </h4>
<h4 <h4
translate translate
ng-show="!$ctrl.isBuyer || !$ctrl.isReplenisher"> ng-show="!$ctrl.isBuyer || !$ctrl.isReplenisher">
Tags Tags
</h4> </h4>
<vn-label-value <vn-label-value
label="{{tag.priority}} {{tag.tag.name}}" label="{{tag.priority}} {{tag.tag.name}}"
@ -119,14 +119,16 @@
</vn-one> </vn-one>
<vn-one name="tax"> <vn-one name="tax">
<h4 ng-show="$ctrl.isBuyer || $ctrl.isAdministrative"> <h4 ng-show="$ctrl.isBuyer || $ctrl.isAdministrative">
<a ui-sref="item.card.tax({id:$ctrl.item.id})"> <a
ui-sref="item.card.tax({id:$ctrl.item.id})"
target="_self">
<span translate vn-tooltip="Go to">Tax</span> <span translate vn-tooltip="Go to">Tax</span>
</a> </a>
</h4> </h4>
<h4 <h4
translate translate
ng-show="!$ctrl.isBuyer || !$ctrl.isAdministrative"> ng-show="!$ctrl.isBuyer || !$ctrl.isAdministrative">
Tax Tax
</h4> </h4>
<vn-label-value label="{{tax.country.country}}" <vn-label-value label="{{tax.country.country}}"
ng-repeat="tax in $ctrl.summary.item.taxes" ng-repeat="tax in $ctrl.summary.item.taxes"
@ -136,15 +138,15 @@
<vn-one name="niche"> <vn-one name="niche">
<h4 ng-show="$ctrl.isBuyer || $ctrl.isReplenisher"> <h4 ng-show="$ctrl.isBuyer || $ctrl.isReplenisher">
<a <a
ui-sref="item.card.niche({id:$ctrl.item.id})" ui-sref="item.card.niche({id:$ctrl.item.id})"
target="_self"> target="_self">
<span translate vn-tooltip="Go to">Niche</span> <span translate vn-tooltip="Go to">Niche</span>
</a> </a>
</h4> </h4>
<h4 <h4
translate translate
ng-show="!$ctrl.isBuyer || !$ctrl.isReplenisher"> ng-show="!$ctrl.isBuyer || !$ctrl.isReplenisher">
Niche Niche
</h4> </h4>
<vn-label-value label="{{niche.warehouse.name}}" <vn-label-value label="{{niche.warehouse.name}}"
ng-repeat="niche in $ctrl.summary.niches" ng-repeat="niche in $ctrl.summary.niches"
@ -154,15 +156,15 @@
<vn-one name="botanical"> <vn-one name="botanical">
<h4 ng-show="$ctrl.isBuyer"> <h4 ng-show="$ctrl.isBuyer">
<a <a
ui-sref="item.card.botanical({id:$ctrl.item.id})" ui-sref="item.card.botanical({id:$ctrl.item.id})"
target="_self"> target="_self">
<span translate vn-tooltip="Go to">Botanical</span> <span translate vn-tooltip="Go to">Botanical</span>
</a> </a>
</h4> </h4>
<h4 <h4
translate translate
ng-show="!$ctrl.isBuyer"> ng-show="!$ctrl.isBuyer">
Botanical Botanical
</h4> </h4>
<vn-label-value label="Botanical" <vn-label-value label="Botanical"
value="{{$ctrl.summary.botanical.botanical}}"> value="{{$ctrl.summary.botanical.botanical}}">
@ -177,15 +179,15 @@
<vn-one name="barcode"> <vn-one name="barcode">
<h4 ng-show="$ctrl.isBuyer || $ctrl.isReplenisher"> <h4 ng-show="$ctrl.isBuyer || $ctrl.isReplenisher">
<a <a
ui-sref="item.card.itemBarcode({id:$ctrl.item.id})" ui-sref="item.card.itemBarcode({id:$ctrl.item.id})"
target="_self"> target="_self">
<span translate vn-tooltip="Go to">Barcode</span> <span translate vn-tooltip="Go to">Barcode</span>
</a> </a>
</h4> </h4>
<h4 <h4
translate translate
ng-show="!$ctrl.isBuyer || !$ctrl.isReplenisher"> ng-show="!$ctrl.isBuyer || !$ctrl.isReplenisher">
Barcode Barcode
</h4> </h4>
<p ng-repeat="barcode in $ctrl.summary.item.itemBarcode track by $index"> <p ng-repeat="barcode in $ctrl.summary.item.itemBarcode track by $index">
<b>{{barcode.code}}</b> <b>{{barcode.code}}</b>

View File

@ -63,15 +63,15 @@
<vn-auto> <vn-auto>
<h4 ng-show="$ctrl.isDelivery"> <h4 ng-show="$ctrl.isDelivery">
<a <a
ui-sref="route.card.tickets({id:$ctrl.route.id})" ui-sref="route.card.tickets({id:$ctrl.route.id})"
target="_self"> target="_self">
<span translate vn-tooltip="Go to">Ticket</span> <span translate vn-tooltip="Go to">Ticket</span>
</a> </a>
</h4> </h4>
<h4 <h4
translate translate
ng-show="!$ctrl.isDelivery"> ng-show="!$ctrl.isDelivery">
Ticket Ticket
</h4> </h4>
<vn-table model="model"> <vn-table model="model">
<vn-thead> <vn-thead>

View File

@ -12,15 +12,15 @@
<vn-one> <vn-one>
<h4 ng-show="$ctrl.isAdministrative"> <h4 ng-show="$ctrl.isAdministrative">
<a <a
ui-sref="supplier.card.basicData({id:$ctrl.supplier.id})" ui-sref="supplier.card.basicData({id:$ctrl.supplier.id})"
target="_self"> target="_self">
<span translate vn-tooltip="Go to">Basic data</span> <span translate vn-tooltip="Go to">Basic data</span>
</a> </a>
</h4> </h4>
<h4 <h4
translate translate
ng-show="!$ctrl.isAdministrative"> ng-show="!$ctrl.isAdministrative">
Basic data Basic data
</h4> </h4>
<vn-vertical> <vn-vertical>
<vn-label-value <vn-label-value
@ -50,15 +50,15 @@
<vn-one> <vn-one>
<h4 ng-show="$ctrl.isAdministrative"> <h4 ng-show="$ctrl.isAdministrative">
<a <a
ui-sref="supplier.card.billingData({id:$ctrl.supplier.id})" ui-sref="supplier.card.billingData({id:$ctrl.supplier.id})"
target="_self"> target="_self">
<span translate vn-tooltip="Go to">Billing data</span> <span translate vn-tooltip="Go to">Billing data</span>
</a> </a>
</h4> </h4>
<h4 <h4
translate translate
ng-show="!$ctrl.isAdministrative"> ng-show="!$ctrl.isAdministrative">
Billing data Billing data
</h4> </h4>
<vn-label-value <vn-label-value
label="Pay method" label="Pay method"
@ -87,15 +87,15 @@
<vn-one> <vn-one>
<h4 ng-show="$ctrl.isAdministrative"> <h4 ng-show="$ctrl.isAdministrative">
<a <a
ui-sref="supplier.card.fiscalData({id:$ctrl.supplier.id})" ui-sref="supplier.card.fiscalData({id:$ctrl.supplier.id})"
target="_self"> target="_self">
<span translate vn-tooltip="Go to">Fiscal data</span> <span translate vn-tooltip="Go to">Fiscal data</span>
</a> </a>
</h4> </h4>
<h4 <h4
translate translate
ng-show="!$ctrl.isAdministrative"> ng-show="!$ctrl.isAdministrative">
Fiscal data Fiscal data
</h4> </h4>
<vn-label-value <vn-label-value
label="Sage tax type" label="Sage tax type"
@ -117,15 +117,15 @@
<vn-one> <vn-one>
<h4 ng-show="$ctrl.isAdministrative"> <h4 ng-show="$ctrl.isAdministrative">
<a <a
ui-sref="supplier.card.fiscalData({id:$ctrl.supplier.id})" ui-sref="supplier.card.fiscalData({id:$ctrl.supplier.id})"
target="_self"> target="_self">
<span translate vn-tooltip="Go to">Fiscal address</span> <span translate vn-tooltip="Go to">Fiscal address</span>
</a> </a>
</h4> </h4>
<h4 <h4
translate translate
ng-show="!$ctrl.isAdministrative"> ng-show="!$ctrl.isAdministrative">
Fiscal address Fiscal address
</h4> </h4>
<vn-label-value <vn-label-value
label="Social name" label="Social name"

View File

@ -134,15 +134,15 @@
<vn-auto ng-if="$ctrl.travelThermographs.length != 0"> <vn-auto ng-if="$ctrl.travelThermographs.length != 0">
<h4 ng-show="$ctrl.isBuyer"> <h4 ng-show="$ctrl.isBuyer">
<a <a
ui-sref="travel.card.thermograph.index({id:$ctrl.travelData.id})" ui-sref="travel.card.thermograph.index({id:$ctrl.travelData.id})"
target="_self"> target="_self">
<span translate vn-tooltip="Go to">Thermograph</span> <span translate vn-tooltip="Go to">Thermograph</span>
</a> </a>
</h4> </h4>
<h4 <h4
translate translate
ng-show="!$ctrl.isBuyer"> ng-show="!$ctrl.isBuyer">
Thermograph Thermograph
</h4> </h4>
<vn-table> <vn-table>
<vn-thead> <vn-thead>

View File

@ -37,7 +37,8 @@
<vn-horizontal class="vn-pa-md"> <vn-horizontal class="vn-pa-md">
<vn-auto> <vn-auto>
<h4> <h4>
<a ui-sref="zone.card.warehouses({id:$ctrl.zone.id})"> <a
ui-sref="zone.card.warehouses({id:$ctrl.zone.id})">
<span translate vn-tooltip="Go to">Warehouse</span> <span translate vn-tooltip="Go to">Warehouse</span>
</a> </a>
</h4> </h4>