verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

4213-item.summary #1011

Merged
joan merged 5 commits from 4213-item.summary into dev 2022-07-01 09:25:07 +00:00
Conversation 0 Commits 5 Files Changed 3 +18 -1
vicent commented 2022-06-22 12:32:46 +00:00
Contributor
Copy Link
No description provided.
vicent added the
CR / Tests passed
 label 2022-06-22 12:32:46 +00:00
vicent added 1 commit 2022-06-22 12:32:46 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
2c721867fc feat(item.summary): add description
vicent changed title from feat(item.summary): add description to 4213-item.summary 2022-06-22 12:34:07 +00:00
vicent added 1 commit 2022-06-27 05:32:30 +00:00
gitea/salix/pipeline/head This commit looks good Details
fcf79a507c Merge branch 'dev' into 4213-item.summary
joan requested changes 2022-06-27 11:08:24 +00:00
db/changes/10480-june/00-item.sql Outdated
@ -0,0 +1 @@
ALTER TABLE `vn`.`item` MODIFY COLUMN description varchar(512) CHARACTER SET utf8 COLLATE utf8_unicode_ci DEFAULT NULL NULL;
joan commented 2022-06-27 11:08:18 +00:00
Contributor
Copy Link

Puedes utilizar tipo text, en vez de un varchar()

Puedes utilizar tipo text, en vez de un varchar()
vicent marked this conversation as resolved
modules/item/front/summary/index.html Outdated
@ -117,6 +117,23 @@
value="{{tag.value}}">
</vn-label-value>
</vn-one>
<vn-one name="description">
joan commented 2022-06-27 11:07:47 +00:00
Contributor
Copy Link

Quizas estaría bien ocultar el bloque si no tiene una descripción, para evitar que se muestre un encabezado pero sin contenido.

Quizas estaría bien ocultar el bloque si no tiene una descripción, para evitar que se muestre un encabezado pero sin contenido.
vicent marked this conversation as resolved
vicent added 1 commit 2022-06-29 12:28:31 +00:00
gitea/salix/pipeline/head This commit is unstable Details
d49a2666f1 refactor: don´t show 'description' if it is empty
vicent added 1 commit 2022-06-29 12:29:16 +00:00
vicent requested review from joan 2022-06-29 12:29:22 +00:00
vicent added 1 commit 2022-06-29 12:36:24 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
748dc1b37e fix: delete engine memory to pass backTest
joan merged commit fc87039571 into dev 2022-07-01 09:25:07 +00:00
joan deleted branch 4213-item.summary 2022-07-01 09:25:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
joan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1011
No description provided.
Delete Branch "4213-item.summary"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?