4270-route.create #1023

Merged
joan merged 13 commits from 4270-route.create into dev 2022-08-03 07:09:11 +00:00
Contributor
No description provided.
vicent added the
CR / Tests passed
label 2022-07-05 10:48:27 +00:00
vicent added 5 commits 2022-07-05 10:48:30 +00:00
vicent added 1 commit 2022-07-07 05:39:55 +00:00
vicent added 1 commit 2022-07-12 06:20:13 +00:00
gitea/salix/pipeline/head This commit looks good Details
25dab78ca2
Merge branch 'dev' into 4270-route.create
vicent requested review from joan 2022-07-12 06:22:10 +00:00
carlosjr added 1 commit 2022-07-15 12:22:21 +00:00
gitea/salix/pipeline/head This commit looks good Details
bbfab8d0bd
Merge branch 'dev' into 4270-route.create
carlosjr requested changes 2022-07-15 12:43:15 +00:00
@ -0,0 +4,4 @@
const routeId = 1;
it('should set the commission work center if the worker has workCenter', async() => {
const tx = await models.Defaulter.beginTransaction({});
Contributor

Es confuso iniciar la transacción en un modelo que no es el que vas a invocar en tu funcionalidad.

models.Defaulter vs models.Route

Es confuso iniciar la transacción en un modelo que no es el que vas a invocar en tu funcionalidad. models.Defaulter vs models.Route
vicent marked this conversation as resolved
@ -0,0 +26,4 @@
}
});
it(`should set the commission work center equals default work center if the worker hasn't workCenter`, async() => {
Contributor

Shoul set the default commision work center if that worker didn't have one yet

Shoul set the default commision work center if that worker didn't have one yet
vicent marked this conversation as resolved
@ -0,0 +29,4 @@
it(`should set the commission work center equals default work center if the worker hasn't workCenter`, async() => {
const tx = await models.Defaulter.beginTransaction({});
try {
const noExistentId = 2;
Contributor

¿Te refieres a el user "Customer" no tiene workCenter asignado? esta variable es confusa, dale un nombre que describa realmente lo que hace.

¿Te refieres a el user "Customer" no tiene workCenter asignado? esta variable es confusa, dale un nombre que describa realmente lo que hace.
vicent marked this conversation as resolved
@ -0,0 +14,4 @@
},
http: {
path: `/:id/updateWorkCenter`,
verb: 'GET'
Contributor

GET o POST?

GET o POST?
vicent marked this conversation as resolved
@ -0,0 +34,4 @@
try {
const [result] = await Self.rawSql(`
SELECT IFNULL(wl.workCenterFK, r.defaultWorkCenterFk) AS commissionWorkCenter
Contributor

workCenterFK tiene la F y la K en mayus, esto parece un typo, miralo porfa.

workCenterFK tiene la F y la K en mayus, esto parece un typo, miralo porfa.
vicent marked this conversation as resolved
@ -6,2 +6,3 @@
this.$.watcher.submit().then(
res => this.$state.go('route.card.summary', {id: res.data.id})
res => {
this.$http.get(`Routes/${res.data.id}/updateWorkCenter`);
Contributor

GET o POST?

GET o POST?
vicent marked this conversation as resolved
@ -7,1 +7,3 @@
res => this.$state.go('route.card.summary', {id: res.data.id})
res => {
this.$http.get(`Routes/${res.data.id}/updateWorkCenter`);
this.$state.go('route.card.summary', {id: res.data.id});
Contributor

estas redirigiendo a una ruta antes de saber si ha resuelto correctamente el POST* de updateWorkCenter.

esto es mala practica.

estas redirigiendo a una ruta antes de saber si ha resuelto correctamente el POST* de updateWorkCenter. esto es mala practica.
vicent marked this conversation as resolved
carlosjr removed the
CR / Tests passed
label 2022-07-15 12:43:30 +00:00
vicent added 2 commits 2022-07-19 12:40:51 +00:00
vicent added the
CR / Tests passed
label 2022-07-19 12:42:07 +00:00
vicent requested review from carlosjr 2022-07-19 12:42:18 +00:00
vicent added 1 commit 2022-07-19 12:42:59 +00:00
carlosjr added 1 commit 2022-07-22 11:07:15 +00:00
gitea/salix/pipeline/head This commit looks good Details
7d7365c4f3
Merge branch 'dev' into 4270-route.create
carlosjr approved these changes 2022-07-22 11:17:46 +00:00
carlosjr left a comment
Contributor

LGTM

LGTM
joan added 1 commit 2022-08-03 06:44:55 +00:00
joan merged commit eed0ac66c6 into dev 2022-08-03 07:09:11 +00:00
joan deleted branch 4270-route.create 2022-08-03 07:09:12 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1023
No description provided.