verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 58 Releases Wiki Activity

4270-route.create #1023

Merged
joan merged 13 commits from 4270-route.create into dev 2022-08-03 07:09:11 +00:00
Conversation 0 Commits 13 Files Changed 8 +6 -4
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 318b688b67 - Show all commits

4
modules/route/back/methods/route/updateWorkCenter.js
View File

@ -14,7 +14,7 @@ module.exports = Self => {
},
http: {
path: `/:id/updateWorkCenter`,
verb: 'GET'
verb: 'POST'
vicent marked this conversation as resolved Outdated
carlosjr commented 2022-07-15 12:41:32 +00:00
Outdated
Review
Copy Link

GET o POST?

GET o POST?
}
});
@ -34,7 +34,7 @@ module.exports = Self => {
try {
const [result] = await Self.rawSql(`
SELECT IFNULL(wl.workCenterFK, r.defaultWorkCenterFk) AS commissionWorkCenter
SELECT IFNULL(wl.workCenterFk, r.defaultWorkCenterFk) AS commissionWorkCenter
vicent marked this conversation as resolved Outdated
carlosjr commented 2022-07-15 12:39:14 +00:00
Outdated
Review
Copy Link

workCenterFK tiene la F y la K en mayus, esto parece un typo, miralo porfa.

workCenterFK tiene la F y la K en mayus, esto parece un typo, miralo porfa.
FROM vn.routeConfig r
LEFT JOIN vn.workerLabour wl ON wl.workerFk = ?
AND CURDATE() BETWEEN wl.started AND IFNULL(wl.ended, CURDATE());

6
modules/route/front/create/index.js
View File

@ -5,8 +5,10 @@ export default class Controller extends Section {
onSubmit() {
this.$.watcher.submit().then(
res => {
this.$http.get(`Routes/${res.data.id}/updateWorkCenter`);
this.$state.go('route.card.summary', {id: res.data.id});
this.$http.post(`Routes/${res.data.id}/updateWorkCenter`, null)
vicent marked this conversation as resolved Outdated
carlosjr commented 2022-07-15 12:41:39 +00:00
Outdated
Review
Copy Link

GET o POST?

GET o POST?
.then(() => {
vicent marked this conversation as resolved Outdated
carlosjr commented 2022-07-15 12:43:07 +00:00
Outdated
Review
Copy Link

estas redirigiendo a una ruta antes de saber si ha resuelto correctamente el POST* de updateWorkCenter.

esto es mala practica.

estas redirigiendo a una ruta antes de saber si ha resuelto correctamente el POST* de updateWorkCenter. esto es mala practica.
this.$state.go('route.card.summary', {id: res.data.id});
});
}
);
}