verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 67 Releases Wiki Activity

3069-client.shelving #1029

Merged
joan merged 16 commits from 3069-client.shelving into dev 2022-08-05 09:18:56 +00:00
Conversation 1 Commits 16 Files Changed 47 +1008 -7
vicent commented 2022-07-20 12:04:16 +00:00
Contributor
Copy Link
No description provided.
vicent added the
CR / Tests passed
 label 2022-07-20 12:04:16 +00:00
vicent added 12 commits 2022-07-20 12:04:18 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
c5683ab880 feat: added itemShelving
gitea/salix/pipeline/head There was a failure building this commit Details
f00fb0dc3f feat: add new module shelving
gitea/salix/pipeline/head There was a failure building this commit Details
5880efe966 refator: commented code deleted
gitea/salix/pipeline/head There was a failure building this commit Details
eba6c149ba refactor
gitea/salix/pipeline/head There was a failure building this commit Details
ac344d6edd refactor: add column id PK and updated column code UQ
gitea/salix/pipeline/head There was a failure building this commit Details
c56ac1c192 feat: add log
gitea/salix/pipeline/head There was a failure building this commit Details
7434532636 feat: add translate
gitea/salix/pipeline/head There was a failure building this commit Details
771c86ba4b fix: shelving log
gitea/salix/pipeline/head This commit looks good Details
af4e7be229 feat: add frontTest
gitea/salix/pipeline/head This commit looks good Details
26f8996936 refactor: set vn-focus and move sql to new folder
vicent removed the
CR / Tests passed
 label 2022-07-20 12:13:08 +00:00
vicent commented 2022-07-20 12:13:26 +00:00
Author
Contributor
Copy Link

Falta preguntar los ACL.

Falta preguntar los ACL.
vicent added the
CR / Tests passed
 label 2022-07-22 06:47:13 +00:00
carlosjr requested changes 2022-07-22 14:23:47 +00:00
modules/shelving/front/create/index.spec.js
@ -0,0 +1,29 @@
import './index';
import watcher from 'core/mocks/watcher';
fdescribe('Shelving', () => {
carlosjr commented 2022-07-22 14:15:54 +00:00
Contributor
Copy Link

fdescribe

fdescribe
vicent marked this conversation as resolved
modules/shelving/front/create/index.spec.js
@ -0,0 +22,4 @@
controller.onSubmit();
expect(controller.$state.go).toHaveBeenCalledWith('shelving.card.basicData', {id: 1234});
carlosjr commented 2022-07-22 14:16:13 +00:00
Contributor
Copy Link

de donde sale la id 1234? este test es raro

de donde sale la id 1234? este test es raro
vicent marked this conversation as resolved
modules/shelving/front/routes.json
@ -0,0 +56,4 @@
"state": "shelving.card.basicData",
"component": "vn-shelving-basic-data",
"description": "Basic data",
"acl": ["administrative"],
carlosjr commented 2022-07-22 14:21:29 +00:00
Contributor
Copy Link

Administrative es el ACL correcto?
Ha de etar solo basicData con ACL?

Administrative es el ACL correcto? Ha de etar solo basicData con ACL?
vicent marked this conversation as resolved
modules/shelving/front/search-panel/locale/es.yml Outdated
@ -0,0 +1 @@
Search shelvings by code: Busca matriculas por código
carlosjr commented 2022-07-22 14:23:14 +00:00
Contributor
Copy Link

Shelvings no traduce a matriculas sino a estanterías

puede que plate number sea lo que buscas si quieres traducir a matricula

Shelvings no traduce a matriculas sino a estanterías puede que plate number sea lo que buscas si quieres traducir a matricula
vicent commented 2022-07-29 11:42:26 +00:00
Author
Contributor
Copy Link

He hablado con Javi y la traducción que utilizan en Vn es shelving = carro.
Entonces lo he traducido por carro.

He hablado con Javi y la traducción que utilizan en Vn es shelving = carro. Entonces lo he traducido por carro.
vicent marked this conversation as resolved
carlosjr removed the
CR / Tests passed
 label 2022-07-22 14:23:59 +00:00
vicent added 1 commit 2022-07-27 11:01:13 +00:00
gitea/salix/pipeline/head This commit looks good Details
21701601e3 fix: update frontTest
vicent added 2 commits 2022-07-29 11:43:09 +00:00
gitea/salix/pipeline/head This commit looks good Details
990fe17f48 fix: correct transalte
vicent added the
CR / Tests passed
 label 2022-07-29 11:45:56 +00:00
vicent requested review from carlosjr 2022-07-29 11:45:59 +00:00
vicent added 1 commit 2022-07-29 11:47:52 +00:00
gitea/salix/pipeline/head This commit looks good Details
83e5a01649 fix: correct translation
joan approved these changes 2022-08-05 09:18:42 +00:00
joan left a comment
Contributor
Copy Link

LGTM

LGTM
joan merged commit cabc30ef87 into dev 2022-08-05 09:18:56 +00:00
joan deleted branch 3069-client.shelving 2022-08-05 09:18:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosjr
joan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1029
No description provided.
Delete Branch "3069-client.shelving"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?