verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 59 Releases Wiki Activity

4291-delete_it.warehouseFk #1035

Merged
joan merged 9 commits from 4291-delete_it.warehouseFk into dev 2022-09-13 10:00:39 +00:00
Conversation 1 Commits 9 Files Changed 10 +66 -42
vicent commented 2022-07-29 11:40:10 +00:00
Contributor
Copy Link
No description provided.
vicent added the
CR / Tests passed
 label 2022-07-29 11:40:10 +00:00
vicent added 7 commits 2022-07-29 11:40:11 +00:00
gitea/salix/pipeline/head This commit looks good Details
6f3d4792d5 update backTest
gitea/salix/pipeline/head This commit is unstable Details
7bf9a8c100 delete itemType.warehouseFk
gitea/salix/pipeline/head This commit is unstable Details
605da52286 fix: replace it.warehouseFk by userConfig.warehouseFk
gitea/salix/pipeline/head This commit is unstable Details
840e792d13 fix: backTest
gitea/salix/pipeline/head This commit looks good Details
224ea61a62 fix: delete warehouseFk from itemType model
vicent removed the
CR / Tests passed
 label 2022-07-29 12:19:22 +00:00
vicent commented 2022-07-29 12:20:27 +00:00
Author
Contributor
Copy Link

Queda eliminar itemType.warehouseFk del proc vn2008.buy_tarifas_T3_pf

Queda eliminar itemType.warehouseFk del proc vn2008.buy_tarifas_T3_pf
joan requested changes 2022-08-05 08:48:14 +00:00
modules/entry/back/methods/entry/latestBuysFilter.js Outdated
@ -202,3 +204,3 @@
AND v.calc_id = @calc_id
JOIN item i ON i.id = lb.item_id
JOIN itemType it ON it.id = i.typeFk AND lb.warehouse_id = it.warehouseFk
JOIN itemType it ON it.id = i.typeFk AND lb.warehouse_id = ${userConfig.warehouseFk}
joan commented 2022-08-05 08:48:00 +00:00
Contributor
Copy Link

Se debe parametrizar con "?" para prevenir inyección SQL

Se debe parametrizar con "?" para prevenir inyección SQL
vicent marked this conversation as resolved
modules/item/back/methods/item/filter.js Outdated
@ -180,3 +183,3 @@
LEFT JOIN producer pr ON pr.id = i.producerFk
LEFT JOIN origin ori ON ori.id = i.originFk
LEFT JOIN cache.last_buy lb ON lb.item_id = i.id AND lb.warehouse_id = it.warehouseFk
LEFT JOIN cache.last_buy lb ON lb.item_id = i.id AND lb.warehouse_id = ${userConfig.warehouseFk}
joan commented 2022-08-05 08:48:08 +00:00
Contributor
Copy Link

Se debe parametrizar con "?" para prevenir inyección SQL

Se debe parametrizar con "?" para prevenir inyección SQL
vicent marked this conversation as resolved
vicent added 1 commit 2022-08-10 07:19:35 +00:00
gitea/salix/pipeline/head This commit looks good Details
8f54365350 refator: parametrizardo con ?
vicent requested review from joan 2022-08-10 07:19:48 +00:00
vicent added the
CR / Tests passed
 label 2022-09-13 05:28:50 +00:00
vicent removed the
CR / Tests passed
 label 2022-09-13 07:07:04 +00:00
vicent added 1 commit 2022-09-13 09:38:31 +00:00
vicent added the
CR / Tests passed
 label 2022-09-13 09:42:30 +00:00
joan approved these changes 2022-09-13 10:00:14 +00:00
joan left a comment
Contributor
Copy Link

LGTM

LGTM
joan merged commit 1f850d13e9 into dev 2022-09-13 10:00:39 +00:00
joan deleted branch 4291-delete_it.warehouseFk 2022-09-13 10:00:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
joan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1035
No description provided.
Delete Branch "4291-delete_it.warehouseFk"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?