verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 59 Releases Wiki Activity

4616-ticket.sale_mana #1088

Merged
vicent merged 14 commits from 4616-ticket.sale_mana into dev 2022-11-02 13:48:21 +00:00
Conversation 0 Commits 14 Files Changed 5 +66 -60
vicent commented 2022-10-17 06:13:16 +00:00
Contributor
Copy Link
No description provided.
vicent added the
CR / Tests passed
 label 2022-10-17 06:13:16 +00:00
vicent added 7 commits 2022-10-17 06:13:19 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
86b7e9cabe fix: only can exists 'mana' or 'manaClaim' discount. Never both
gitea/salix/pipeline/head There was a failure building this commit Details
40075e7e21 fix: testFront
gitea/salix/pipeline/head This commit looks good Details
06ecceb478 refactor: lines to long
gitea/salix/pipeline/head This commit looks good Details
cdce628038 refactor: delete line break
vicent added
Missing tests
 and removed
CR / Tests passed
 labels 2022-10-17 06:16:22 +00:00
vicent added 1 commit 2022-10-17 06:29:20 +00:00
gitea/salix/pipeline/head This commit looks good Details
787d10aac6 fix: select one result only
vicent added
CR / Tests passed
 and removed
Missing tests
 labels 2022-10-17 06:38:40 +00:00
joan requested changes 2022-10-17 08:33:14 +00:00
modules/ticket/back/methods/ticket/updateDiscount.js Outdated
@ -122,0 +143,4 @@
await createSaleComponent(sale.id, value, componentId, myOptions);
} else
await createSaleComponent(sale.id, value, componentId, myOptions);
joan commented 2022-10-17 08:31:24 +00:00
Contributor
Copy Link

Esta linea está repetida en ambos casos, se puede extraer fuera del condicional

Esta linea está repetida en ambos casos, se puede extraer fuera del condicional
vicent marked this conversation as resolved
vicent added 1 commit 2022-10-17 12:01:36 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
f85c2e9700 refactor: delete code repeated
vicent requested review from joan 2022-10-17 12:01:46 +00:00
vicent added 1 commit 2022-10-17 12:01:57 +00:00
gitea/salix/pipeline/head This commit looks good Details
bec33c095f Merge branch 'dev' into 4616-ticket.sale_mana
joan requested changes 2022-10-25 07:31:32 +00:00
modules/ticket/back/methods/ticket/updateDiscount.js Outdated
@ -122,0 +133,4 @@
}
}, myOptions);
let newComponent;
joan commented 2022-10-25 07:29:49 +00:00
Contributor
Copy Link

No utilizar variables globales, es más dificil de hacer seguimiento

No utilizar variables globales, es más dificil de hacer seguimiento
vicent marked this conversation as resolved
modules/ticket/back/methods/ticket/updateDiscount.js Outdated
@ -122,0 +139,4 @@
saleFk: sale.id,
componentFk: oldComponent.componentFk
};
await models.SaleComponent.destroyAll(filter, myOptions);
joan commented 2022-10-25 07:31:19 +00:00
Contributor
Copy Link

Asignar el resultado de esta función (Promesa) a una variable, y hacer el push al array.

Asignar el resultado de esta función (Promesa) a una variable, y hacer el push al array.
vicent marked this conversation as resolved
vicent added 1 commit 2022-10-26 06:11:31 +00:00
vicent added 1 commit 2022-10-26 06:23:47 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
925565d3d2 refator: borrada variable global y añadida Promesa al array
vicent requested review from joan 2022-10-26 06:24:27 +00:00
joan approved these changes 2022-11-02 06:42:29 +00:00
joan added 1 commit 2022-11-02 06:42:44 +00:00
gitea/salix/pipeline/head This commit looks good Details
177b448441 Merge branch 'dev' into 4616-ticket.sale_mana
vicent added 1 commit 2022-11-02 13:42:33 +00:00
gitea/salix/pipeline/head This commit looks good Details
7eaafa36a0 Merge branch 'dev' into 4616-ticket.sale_mana
vicent merged commit c01b1c06a7 into dev 2022-11-02 13:48:21 +00:00
vicent deleted branch 4616-ticket.sale_mana 2022-11-02 13:48:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
joan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1088
No description provided.
Delete Branch "4616-ticket.sale_mana"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?