verdnatura/salix
verdnatura
/
salix
3
5
Fork 2
Code Issues Pull Requests 71 Releases Wiki Activity

4616-ticket.sale_mana #1088

Merged
vicent merged 14 commits from 4616-ticket.sale_mana into dev 2022-11-02 13:48:21 +00:00
Conversation 0 Commits 14 Files Changed 5 +5 -5
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 925565d3d2 - Show all commits

10
modules/ticket/back/methods/ticket/updateDiscount.js
View File

@ -133,20 +133,20 @@ module.exports = Self => {
} }
}, myOptions); }, myOptions);
let newComponent; let deletedComponent;
vicent marked this conversation as resolved Outdated
joan commented 2022-10-25 07:29:49 +00:00
Outdated
Review
Copy Link

No utilizar variables globales, es más dificil de hacer seguimiento

No utilizar variables globales, es más dificil de hacer seguimiento
if (oldComponent) { if (oldComponent) {
const filter = { const filter = {
saleFk: sale.id, saleFk: sale.id,
componentFk: oldComponent.componentFk componentFk: oldComponent.componentFk
}; };
await models.SaleComponent.destroyAll(filter, myOptions); deletedComponent = await models.SaleComponent.destroyAll(filter, myOptions);
vicent marked this conversation as resolved Outdated
joan commented 2022-10-25 07:31:19 +00:00
Outdated
Review
Copy Link

Asignar el resultado de esta función (Promesa) a una variable, y hacer el push al array.

Asignar el resultado de esta función (Promesa) a una variable, y hacer el push al array.
} }
await createSaleComponent(sale.id, value, componentId, myOptions); const newComponent = await createSaleComponent(sale.id, value, componentId, myOptions);
vicent marked this conversation as resolved Outdated
joan commented 2022-10-17 08:31:24 +00:00
Outdated
Review
Copy Link

Esta linea está repetida en ambos casos, se puede extraer fuera del condicional

Esta linea está repetida en ambos casos, se puede extraer fuera del condicional
const updatedSale = sale.updateAttribute('discount', newDiscount, myOptions); const updatedSale = sale.updateAttribute('discount', newDiscount, myOptions);
promises.push(newComponent, updatedSale); promises.push(newComponent, updatedSale, deletedComponent);
const change = `${oldDiscount}% ➔ *${newDiscount}%*`; const change = `${oldDiscount}% ➔ *${newDiscount}%*`;
changesMade += `\r\n-${sale.itemFk}: ${sale.concept} (${sale.quantity}) ${change}`; changesMade += `\r\n-${sale.itemFk}: ${sale.concept} (${sale.quantity}) ${change}`;
@ -193,7 +193,7 @@ module.exports = Self => {
async function createSaleComponent(saleId, value, componentId, myOptions) { async function createSaleComponent(saleId, value, componentId, myOptions) {
const models = Self.app.models; const models = Self.app.models;
newComponent = models.SaleComponent.create({ return models.SaleComponent.create({
saleFk: saleId, saleFk: saleId,
value: value, value: value,
componentFk: componentId componentFk: componentId