2612-create-supplier #1089

Merged
joan merged 21 commits from 2612-create-supplier into dev 2022-10-25 10:42:10 +00:00
Contributor
No description provided.
pau added the
CR / Tests passed
label 2022-10-17 07:05:08 +00:00
pau added 4 commits 2022-10-17 07:05:10 +00:00
gitea/salix/pipeline/head This commit looks good Details
012cd68c89
Added menu to create a new supplier, not working
gitea/salix/pipeline/head This commit looks good Details
dc6c8f924d
feat: Create new Supplier
gitea/salix/pipeline/head There was a failure building this commit Details
594cee12f3
add checks to the existence of object variables
gitea/salix/pipeline/head This commit looks good Details
1603619d81
removed debugging elements
pau added 1 commit 2022-10-17 07:21:00 +00:00
gitea/salix/pipeline/head This commit looks good Details
0cdee89ac3
Button removed when user does not have permissions
pau added 1 commit 2022-10-17 07:23:05 +00:00
gitea/salix/pipeline/head This commit looks good Details
f0b1591b14
Remove debugging elements
pau requested review from joan 2022-10-17 07:32:29 +00:00
pau changed title from WIP: 2612-create-supplier to 2612-create-supplier 2022-10-17 07:32:39 +00:00
pau added 1 commit 2022-10-17 07:32:58 +00:00
gitea/salix/pipeline/head This commit looks good Details
dc53aac163
Merge branch 'dev' into 2612-create-supplier
pau changed title from 2612-create-supplier to WIP: 2612-create-supplier 2022-10-17 10:06:28 +00:00
pau added
Missing tests
Needs refactor
and removed
CR / Tests passed
labels 2022-10-17 10:06:40 +00:00
pau added 2 commits 2022-10-17 10:07:52 +00:00
pau added 1 commit 2022-10-17 12:02:39 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
9290cd6fb6
Finished back tests
pau removed the
Missing tests
Needs refactor
labels 2022-10-17 12:06:55 +00:00
pau added the
Needs refactor
label 2022-10-18 05:02:18 +00:00
pau added 1 commit 2022-10-18 05:15:34 +00:00
gitea/salix/pipeline/head This commit looks good Details
047076f189
changed tests
pau added 1 commit 2022-10-18 10:29:17 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
a204c6e2b0
Fixed the suppliers not appearing
pau added 1 commit 2022-10-18 10:58:57 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
470b4485d5
Fixed test and DB structure
pau added 1 commit 2022-10-18 11:07:24 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
db12ceb369
removed async from the redirect function
pau added
CR / Tests passed
and removed
Needs refactor
labels 2022-10-18 11:10:00 +00:00
pau changed title from WIP: 2612-create-supplier to 2612-create-supplier 2022-10-18 12:00:57 +00:00
pau added 1 commit 2022-10-18 12:01:14 +00:00
gitea/salix/pipeline/head Build queued... Details
73a69051a8
Merge branch 'dev' into 2612-create-supplier
pau added 2 commits 2022-10-18 12:23:07 +00:00
joan requested changes 2022-10-25 07:42:46 +00:00
@ -0,0 +1,2 @@
INSERT INTO vn.payDem (id,payDem)
Contributor

Nombre de esquema y tabla entre template strings ``

Nombre de esquema y tabla entre template strings ``
pau marked this conversation as resolved
@ -0,0 +1,2 @@
INSERT INTO salix.ACL (model,property,accessType,principalId)
Contributor

Poner el nombre del esquema y la tabla entre template string (``), de lo contrario fallará al importar los cambios en producción.

Poner el nombre del esquema y la tabla entre template string (``), de lo contrario fallará al importar los cambios en producción.
pau marked this conversation as resolved
@ -0,0 +1,5 @@
ALTER TABLE vn.supplier MODIFY COLUMN payMethodFk tinyint(3) unsigned DEFAULT NULL NULL;
Contributor

Poner nombres de esquema y tabla entre template string

Poner nombres de esquema y tabla entre template string
pau marked this conversation as resolved
@ -0,0 +1 @@
ALTER TABLE vn.supplier MODIFY COLUMN payMethodFk tinyint(3) unsigned NULL;
Contributor

Nombre de esquema y tabla entre template strings ``

Nombre de esquema y tabla entre template strings ``
pau marked this conversation as resolved
@ -0,0 +1 @@
ALTER TABLE vn.supplier MODIFY COLUMN supplierActivityFk varchar(45) CHARACTER SET utf8mb3 COLLATE utf8mb3_general_ci DEFAULT NULL NULL;
Contributor

Nombre de esquema y tabla entre template strings ``

Nombre de esquema y tabla entre template strings ``
pau marked this conversation as resolved
@ -0,0 +1,44 @@
module.exports = Self => {
Self.remoteMethod('newSupplier', {
description: 'returns the created item',
Contributor

Corregir descripción

Corregir descripción
pau marked this conversation as resolved
@ -0,0 +21,4 @@
const models = Self.app.models;
const myOptions = {};
params.payDemFk = 1;
Contributor

Esta propiedad no especificarla

Esta propiedad no especificarla
pau marked this conversation as resolved
@ -0,0 +23,4 @@
params.payDemFk = 1;
if (!myOptions.transaction) {
Contributor

Únicamente debería asignar la transacción si se la pasan a la función newSupplier(). No debe crear una transacción para una sola consulta.

Únicamente debería asignar la transacción si se la pasan a la función newSupplier(). No debe crear una transacción para una sola consulta.
pau marked this conversation as resolved
@ -0,0 +24,4 @@
const createdSupplier = await app.models.Supplier.findById(result.id);
expect(createdSupplier.id).toEqual(result.id);
Contributor

Mantener únicamente los expects de los valores que esperas que estén rellenados (id, name, socialName)

Mantener únicamente los expects de los valores que esperas que estén rellenados (id, name, socialName)
pau marked this conversation as resolved
@ -0,0 +5,4 @@
insert-mode="true"
form="form">
</vn-watcher>
<vn-crud-model
Contributor

Este crud model parece que no se utiliza

Este crud model parece que no se utiliza
pau marked this conversation as resolved
@ -0,0 +9,4 @@
onSubmit() {
this.$.watcher.submit().then(
json => {
this.$state.go('item.card.basicData', {id: json.data.id});
Contributor

Supplier fiscaldata

Supplier fiscaldata
pau marked this conversation as resolved
@ -0,0 +13,4 @@
redirect(this.$.$ctrl);
async function redirect(ctrl) {
Contributor

Se debería utilizar únicamente el $state.go(), la función de abajo no es necesaria.

Se debería utilizar únicamente el $state.go(), la función de abajo no es necesaria.
pau marked this conversation as resolved
@ -54,0 +56,4 @@
"url": "/create",
"state": "supplier.create",
"component": "vn-supplier-create",
"description": "New supplier"
Contributor

Falta especificar el ACL administrative

Falta especificar el ACL administrative
pau marked this conversation as resolved
pau added 1 commit 2022-10-25 08:43:55 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
9089ba7346
requested changes
pau requested review from joan 2022-10-25 09:45:14 +00:00
pau added 1 commit 2022-10-25 09:45:38 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
76d248131c
Merge branch 'dev' into 2612-create-supplier
pau added 1 commit 2022-10-25 10:00:30 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
7b04464848
Merge branch 'dev' into 2612-create-supplier
pau added 1 commit 2022-10-25 10:26:13 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
296a743d8a
Fix test, remove console log
joan approved these changes 2022-10-25 10:40:57 +00:00
joan merged commit 418ba65c2e into dev 2022-10-25 10:42:10 +00:00
joan deleted branch 2612-create-supplier 2022-10-25 10:42:11 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1089
No description provided.