verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

3888-ticket.expedition_moveExpedition #1097

Merged
vicent merged 26 commits from 3888-ticket.expedition_moveExpedition into dev 2022-11-02 13:54:11 +00:00
Conversation 1 Commits 26 Files Changed 13 +489 -59
vicent commented 2022-10-20 08:22:12 +00:00
Contributor
Copy Link
No description provided.
vicent added the
CR / Tests passed
 label 2022-10-20 08:22:12 +00:00
vicent added 23 commits 2022-10-20 08:22:14 +00:00
gitea/salix/pipeline/head This commit is unstable Details
2a64fde57c feat: add option "move expedition"
gitea/salix/pipeline/head This commit looks good Details
c4649352a9 feat: add totalChecked
gitea/salix/pipeline/head There was a failure building this commit Details
11484edd10 feat: create new ticket
gitea/salix/pipeline/head Something is wrong with the build of this commit Details
a3a432c753 fix: delete one or more expeditions
gitea/salix/pipeline/head There was a failure building this commit Details
37601934f5 feat: first option to delete and update
gitea/salix/pipeline/head This commit looks good Details
deb8a00dfb feat: add backRoutes
gitea/salix/pipeline/head This commit looks good Details
bb26fa6502 feat: add tFront
gitea/salix/pipeline/head This commit looks good Details
843f67919c feat: add backTest
gitea/salix/pipeline/head There was a failure building this commit Details
ea1714240e fix: test e2e
gitea/salix/pipeline/head There was a failure building this commit Details
5fce93abd5 refactor: change variables name
gitea/salix/pipeline/head There was a failure building this commit Details
ae3e3c3c49 fix: id model duplicated
gitea/salix/pipeline/head There was a failure building this commit Details
9ea427dbfe refactor: move front to back funcionality
gitea/salix/pipeline/head There was a failure building this commit Details
51cad75298 fix: testFront
gitea/salix/pipeline/head There was a failure building this commit Details
bcc9acac0a fix: tBack
gitea/salix/pipeline/head This commit looks good Details
5824fee213 feat: add e2e
gitea/salix/pipeline/head This commit looks good Details
dd15d06f5e delete focus test
joan requested changes 2022-10-25 08:19:50 +00:00
loopback/locale/es.json Outdated
@ -237,2 +237,3 @@
"Modifiable password only via recovery or by an administrator": "Contraseña modificable solo a través de la recuperación o por un administrador",
"Not enough privileges to edit a client": "No tienes suficientes privilegios para editar un cliente"
"Not enough privileges to edit a client": "No tienes suficientes privilegios para editar un cliente",
"This route not exists": "Esta ruta no existe"
joan commented 2022-10-25 08:04:19 +00:00
Contributor
Copy Link

This route does not exists

This route does not exists
vicent marked this conversation as resolved
modules/ticket/back/methods/expedition/deleteExpeditions.js Outdated
@ -0,0 +33,4 @@
}
try {
const deletedExpeditions = await models.Expedition.destroyAll({
joan commented 2022-10-25 08:11:47 +00:00
Contributor
Copy Link

Utilizar destroyById() en un bucle. La función destroyAll() no es segura

Utilizar destroyById() en un bucle. La función destroyAll() no es segura
vicent marked this conversation as resolved
modules/ticket/back/methods/expedition/moveExpeditions.js Outdated
@ -0,0 +75,4 @@
const ticket = await models.Ticket.new(ctx, myOptions);
const promises = [];
for (let expeditionsId of args.expeditionIds) {
const expeditionToUpdate = await models.Expedition.findById(expeditionsId);
joan commented 2022-10-25 08:13:37 +00:00
Contributor
Copy Link

pasar transacción null, myOptions

pasar transacción null, myOptions
vicent marked this conversation as resolved
modules/ticket/front/expedition/locale/es.yml Outdated
@ -2,0 +3,4 @@
Move: Mover
New ticket without route: Nuevo ticket sin ruta
New ticket with route: Nuevo ticket con ruta
Id route: Id ruta
joan commented 2022-10-25 08:19:44 +00:00
Contributor
Copy Link

Route id

Route id
vicent marked this conversation as resolved
vicent added 2 commits 2022-10-26 06:39:19 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
d4e2783630 refactor: corregidas traducciones, eliminado destroyAll y añadida transacción
vicent requested review from joan 2022-10-26 06:39:26 +00:00
joan approved these changes 2022-11-02 11:55:13 +00:00
vicent added 1 commit 2022-11-02 13:49:50 +00:00
alexm approved these changes 2022-11-02 13:52:30 +00:00
alexm commented 2022-11-02 13:54:01 +00:00
Member
Copy Link

Este PR ya había sido aprobado, solo se ha actualizado la rama.

Este PR ya había sido aprobado, solo se ha actualizado la rama.
vicent merged commit b2cfcab569 into dev 2022-11-02 13:54:11 +00:00
vicent deleted branch 3888-ticket.expedition_moveExpedition 2022-11-02 13:54:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
joan
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1097
No description provided.
Delete Branch "3888-ticket.expedition_moveExpedition"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?