verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

3095-item.shelving #1102

Merged
vicent merged 15 commits from 3095-item.shelving into dev 2022-11-02 14:12:56 +00:00
Conversation 0 Commits 15 Files Changed 17 +432 -10
vicent commented 2022-10-25 05:59:56 +00:00
Contributor
Copy Link
No description provided.
vicent added the
CR / Tests passed
 label 2022-10-25 05:59:56 +00:00
vicent added 11 commits 2022-10-25 05:59:58 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
2f17257e46 feat: add new sub section itemShelving
gitea/salix/pipeline/head There was a failure building this commit Details
ddbe1057ad feat: add new section
gitea/salix/pipeline/head There was a failure building this commit Details
9c52508a88 feat: add total labels
gitea/salix/pipeline/head There was a failure building this commit Details
1a38fc307f delete: duplicated keybinding
gitea/salix/pipeline/head This commit looks good Details
bfefec397e feat: add testFront
gitea/salix/pipeline/head There was a failure building this commit Details
7f1dd801a5 refactor: change ACLs
joan requested changes 2022-10-25 08:38:11 +00:00
modules/item/back/methods/item-shelving/deleteItemShelvings.js Outdated
@ -0,0 +1,47 @@
module.exports = Self => {
Self.remoteMethod('deleteItemShelvings', {
description: 'Deletes the selected orders',
joan commented 2022-10-25 08:30:49 +00:00
Contributor
Copy Link

Rectificar descripción

Rectificar descripción
vicent marked this conversation as resolved
modules/item/back/methods/item-shelving/deleteItemShelvings.js Outdated
@ -0,0 +32,4 @@
}
try {
const deletedItemShelvings = await models.ItemShelving.destroyAll({
joan commented 2022-10-25 08:31:18 +00:00
Contributor
Copy Link

Utilizar destroyById()

Utilizar destroyById()
vicent marked this conversation as resolved
modules/shelving/front/routes.json Outdated
@ -13,9 +13,6 @@
{"state": "shelving.card.log", "icon": "history"}
]
},
"keybindings": [
joan commented 2022-10-25 08:38:07 +00:00
Contributor
Copy Link

porqué se elimina el atajo?

porqué se elimina el atajo?
vicent commented 2022-10-26 07:13:47 +00:00
Author
Contributor
Copy Link

Cuando cree ese atajo, lo cree en inglés "s" de shelving. Luego me di cuenta de que los atajos son en español y en español seria "c" de carro. Pero la "c" ya esta en uso. Por ese motivo lo elimine.

Cuando cree ese atajo, lo cree en inglés "s" de shelving. Luego me di cuenta de que los atajos son en español y en español seria "c" de carro. Pero la "c" ya esta en uso. Por ese motivo lo elimine.
vicent marked this conversation as resolved
vicent added 1 commit 2022-10-26 06:05:20 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
07a18dc736 delete sql
vicent requested review from joan 2022-10-26 07:14:53 +00:00
vicent added 1 commit 2022-10-26 07:30:28 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
21e2945d4f refactor: delete destroyAll
joan approved these changes 2022-11-02 06:43:38 +00:00
joan added 1 commit 2022-11-02 06:43:50 +00:00
gitea/salix/pipeline/head This commit looks good Details
fe3ebe8e0c Merge branch 'dev' into 3095-item.shelving
vicent added 1 commit 2022-11-02 14:06:14 +00:00
gitea/salix/pipeline/head This commit looks good Details
8c4e70c11d Merge branch 'dev' into 3095-item.shelving
vicent merged commit 0c73391565 into dev 2022-11-02 14:12:56 +00:00
vicent deleted branch 3095-item.shelving 2022-11-02 14:12:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
joan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1102
No description provided.
Delete Branch "3095-item.shelving"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?