verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refs #2596 drag and drop implementado #1119

Merged
alexandre merged 5 commits from 2596-arrastrar-ficheros into dev 2022-11-10 07:42:01 +00:00
Conversation 1 Commits 5 Files Changed 2 +11 -3
alexandre commented 2022-11-02 07:22:00 +00:00
Contributor
Copy Link
No description provided.
alexandre added the
CR / Tests passed
 label 2022-11-02 07:22:00 +00:00
alexandre added 1 commit 2022-11-02 07:22:02 +00:00
gitea/salix/pipeline/head This commit looks good Details
aaaa73644d refs #2596 drag and drop implementado
alexandre requested review from joan 2022-11-02 07:22:19 +00:00
joan requested review from juan 2022-11-02 13:01:13 +00:00
joan refused to review 2022-11-02 13:01:18 +00:00
juan requested changes 2022-11-02 16:52:33 +00:00
juan left a comment
Owner
Copy Link

Ho veig be, pero mira si pots canviar el que he ficat.

Ho veig be, pero mira si pots canviar el que he ficat.
front/core/components/input-file/index.html Outdated
@ -12,1 +10,3 @@
tabindex="0">
class="value"
ng-click="$ctrl.openFileSelector()"
tabindex="0">
juan commented 2022-11-02 16:50:28 +00:00
Owner
Copy Link

Acò deuria d'anar tabulat una posició com estava.

Acò deuria d'anar tabulat una posició com estava.
front/core/components/input-file/index.html Outdated
@ -15,3 +15,3 @@
type="file"
accept="{{$ctrl.accept}}"
style="display: none;">
style="position: absolute; top: 0; opacity: 0;">
juan commented 2022-11-02 16:51:58 +00:00
Owner
Copy Link

Per separar estil de estructura, millor ficar-ho en el fitxer css.

Per separar estil de estructura, millor ficar-ho en el fitxer css.
alexandre added 1 commit 2022-11-03 07:18:41 +00:00
gitea/salix/pipeline/head This commit looks good Details
e1eeb81696 refs #2596 tabulación y css
alexandre requested review from juan 2022-11-03 07:19:28 +00:00
juan requested changes 2022-11-03 07:23:40 +00:00
front/core/components/input-file/style.scss Outdated
@ -7,1 +10,4 @@
position: absolute;
top: 0;
opacity: 0;
}
juan commented 2022-11-03 07:23:20 +00:00
Owner
Copy Link

No gastes ids, son unics a nivell global de tota la web, pots ficar-ho dins de .vn-input-file amb un selector input[type=file]

No gastes ids, son unics a nivell global de tota la web, pots ficar-ho dins de `.vn-input-file` amb un selector `input[type=file]`
alexandre added 1 commit 2022-11-03 14:29:10 +00:00
gitea/salix/pipeline/head This commit looks good Details
f3085bef66 refs #2596 css actualizado
alexandre commented 2022-11-03 14:30:01 +00:00
Author
Contributor
Copy Link

he tingut que posar-li també el css al section perque sinó no m'ho agafava bé

he tingut que posar-li també el css al section perque sinó no m'ho agafava bé
alexandre requested review from juan 2022-11-03 14:30:23 +00:00
alexandre added 1 commit 2022-11-03 14:45:51 +00:00
gitea/salix/pipeline/head This commit looks good Details
07b2ac99ce refs #2596 css corregido
joan added this to the (deleted) milestone 2022-11-04 08:18:44 +00:00
joan added this to the v9.0.0 - November milestone 2022-11-04 08:24:46 +00:00
juan approved these changes 2022-11-09 15:50:05 +00:00
alexandre added 1 commit 2022-11-10 07:40:18 +00:00
gitea/salix/pipeline/head This commit looks good Details
897a7d079d Merge branch 'dev' into 2596-arrastrar-ficheros
alexandre scheduled this pull request to auto merge when all checks succeed 2022-11-10 07:40:46 +00:00
alexandre merged commit 817f231a29 into dev 2022-11-10 07:42:01 +00:00
alexandre deleted branch 2596-arrastrar-ficheros 2022-11-10 07:42:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
juan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
v9.0.0 - November
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1119
No description provided.
Delete Branch "2596-arrastrar-ficheros"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?