verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

4492-item.create-same-as-item.isLaid #1125

Merged
pau merged 10 commits from 4492-item.create-same-as-item.isLaid into dev 2022-11-16 08:04:56 +00:00
Conversation 0 Commits 10 Files Changed 4 +20
pau commented 2022-11-04 07:19:02 +00:00
Contributor
Copy Link
No description provided.
pau added the
CR / Tests passed
 label 2022-11-04 07:19:02 +00:00
pau added 4 commits 2022-11-04 07:19:04 +00:00
gitea/salix/pipeline/head This commit looks good Details
7d7af6eb49 Modified model to allow modifications to isLaid
gitea/salix/pipeline/head This commit looks good Details
11cf1ba414 fix back test error
gitea/salix/pipeline/head This commit looks good Details
37292cee89 remove comments
pau added 1 commit 2022-11-04 07:22:46 +00:00
joan added this to the (deleted) milestone 2022-11-04 08:07:41 +00:00
joan removed this from the (deleted) milestone 2022-11-04 08:13:18 +00:00
joan added this to the (deleted) milestone 2022-11-04 08:18:44 +00:00
joan added this to the v9.0.0 - November milestone 2022-11-04 08:24:47 +00:00
joan removed this from the v9.0.0 - November milestone 2022-11-04 08:26:34 +00:00
joan added this to the v9.0.0 - November milestone 2022-11-04 08:30:57 +00:00
joan requested changes 2022-11-08 07:33:14 +00:00
modules/item/back/methods/item/new.js Outdated
@ -51,6 +51,12 @@ module.exports = Self => {
const item = await models.Item.create(params, myOptions);
const itemType = await models.ItemType.findById(item.typeFk, myOptions);
joan commented 2022-11-08 07:31:57 +00:00
Contributor
Copy Link

Mover esta linea arriba del create para poder crearlo directamente con el valor de la propiedad isLaid

Mover esta linea arriba del create para poder crearlo directamente con el valor de la propiedad isLaid
pau marked this conversation as resolved
modules/item/back/methods/item/new.js Outdated
@ -54,0 +55,4 @@
item.isLaid = itemType.isLaid;
await item.save(myOptions);
joan commented 2022-11-08 07:32:12 +00:00
Contributor
Copy Link

Evitar el save para no hacer dos consultas a la bd

Evitar el save para no hacer dos consultas a la bd
pau marked this conversation as resolved
modules/item/back/models/item-type.json Outdated
@ -28,1 +28,4 @@
"type": "number"
},
"isLaid": {
"type": "number"
joan commented 2022-11-08 07:32:52 +00:00
Contributor
Copy Link

boolean

boolean
pau marked this conversation as resolved
pau added 1 commit 2022-11-10 06:15:17 +00:00
pau added 2 commits 2022-11-10 06:18:10 +00:00
pau added 1 commit 2022-11-15 06:08:06 +00:00
pau requested review from joan 2022-11-15 06:08:16 +00:00
joan approved these changes 2022-11-16 07:21:12 +00:00
pau added 1 commit 2022-11-16 07:29:22 +00:00
pau merged commit 78ba047df0 into dev 2022-11-16 08:04:56 +00:00
pau deleted branch 4492-item.create-same-as-item.isLaid 2022-11-16 08:04:56 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
joan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
v9.0.0 - November
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1125
No description provided.
Delete Branch "4492-item.create-same-as-item.isLaid"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?