verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

Closes #288 translation for vn.state using i18n #1152

Merged
pau merged 16 commits from #288-traducir-state-i18n into dev 2022-12-23 08:15:37 +00:00
Conversation 0 Commits 16 Files Changed 2 +80
pau commented 2022-11-16 12:54:39 +00:00
Contributor
Copy Link
No description provided.
pau added the
CR / Tests passed
 label 2022-11-16 12:54:39 +00:00
pau added 1 commit 2022-11-16 12:54:41 +00:00
gitea/salix/pipeline/head This commit looks good Details
58c90b3bbc refs #288
pau added 1 commit 2022-11-16 12:54:57 +00:00
gitea/salix/pipeline/head This commit looks good Details
8059e54a26 Merge branch 'dev' into #288-traducir-state-i18n
pau changed title from refs #288 to Closes #288 translation for vn.state using i18n 2022-11-16 12:58:36 +00:00
joan requested review from juan 2022-11-22 13:15:05 +00:00
juan requested changes 2022-11-23 17:59:10 +00:00
juan left a comment
Owner
Copy Link

He puesto 2 cambios, el resto está bien.

He puesto 2 cambios, el resto está bien.
db/changes/10503-november/01-Create_stateI18n.sql Outdated
@ -0,0 +2,4 @@
`stateFk` tinyint(3) unsigned NOT NULL,
`lang`
set
('en', 'es') NOT NULL,
juan commented 2022-11-23 17:57:45 +00:00
Owner
Copy Link

En lugar del tipo SET utilizar CHAR(2) ya que los idiomas no están limitados solo a esy en.

En lugar del tipo `SET` utilizar `CHAR(2)` ya que los idiomas no están limitados solo a `es`y `en`.
pau marked this conversation as resolved
db/changes/10503-november/01-Create_stateI18n.sql Outdated
@ -0,0 +5,4 @@
('en', 'es') NOT NULL,
`name` varchar(255) NOT NULL,
PRIMARY KEY (`stateFk`, `lang`),
KEY `stateFk` (`stateFk`),
juan commented 2022-11-23 17:58:17 +00:00
Owner
Copy Link

Este indice no es necesario

Este indice no es necesario
pau marked this conversation as resolved
pau added 1 commit 2022-11-24 13:07:00 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
15f14062ca Requested changes
pau added 1 commit 2022-11-24 13:18:43 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
0b15236129 Merge branch 'dev' into #288-traducir-state-i18n
pau added 2 commits 2022-11-25 06:09:10 +00:00
pau requested review from juan 2022-11-25 06:10:24 +00:00
juan approved these changes 2022-12-02 11:30:38 +00:00
pau added 2 commits 2022-12-19 06:41:33 +00:00
gitea/salix/pipeline/head This commit looks good Details
d356e5352b delete old files
pau added 1 commit 2022-12-19 06:56:13 +00:00
gitea/salix/pipeline/head This commit looks good Details
07d52f551d Merge branch 'dev' into #288-traducir-state-i18n
pau added 1 commit 2022-12-19 08:14:12 +00:00
gitea/salix/pipeline/head This commit looks good Details
a34c006dc9 Merge branch 'dev' into #288-traducir-state-i18n
juan requested changes 2022-12-19 10:12:20 +00:00
db/changes/225001/01-create_stateI18n.sql Outdated
@ -0,0 +4,4 @@
`name` varchar(255) NOT NULL,
KEY `stateFk` (`stateFk`),
CONSTRAINT `stateI18n_state_id` FOREIGN KEY (`stateFk`) REFERENCES `vn`.`state` (`id`)
) ENGINE = InnoDB DEFAULT CHARSET = utf8;
juan commented 2022-12-19 10:12:07 +00:00
Owner
Copy Link

Añadir: PRIMARY KEY (stateFk, lang)
Quitar: KEY stateFk (stateFk)

Añadir: `PRIMARY KEY (stateFk, lang)` Quitar: `KEY stateFk (stateFk)`
pau marked this conversation as resolved
pau added 20 commits 2022-12-22 07:08:25 +00:00
gitea/salix/pipeline/head This commit looks good Details
c5fb565484 refs #4503 message added
gitea/salix/pipeline/head There was a failure building this commit Details
95967a29db refs #4928 email template added and proc modified
gitea/salix/pipeline/head There was a failure building this commit Details
f00fdcff7c refactor sql
gitea/salix/pipeline/head This commit looks good Details
33196acac6 refs #4928 fixture notification, fix test supplier
gitea/salix/pipeline/head There was a failure building this commit Details
522000cd04 refs #4928 fix fixtures
gitea/salix/pipeline/head There was a failure building this commit Details
5cc8764a3f acquireTimeout 10000
gitea/salix/pipeline/head This commit looks good Details
bab6fa0c9d acquireTimeout: 60000
gitea/salix/pipeline/head This commit looks good Details
b8a0d179f1 Merge branch 'dev' into 4928-supplier-payMethod-notify
gitea/salix/pipeline/head This commit looks good Details
0a18c855e7 Merge branch 'dev' into 4928-supplier-payMethod-notify
gitea/salix/pipeline/head This commit looks good Details
6130547420 Merge branch 'dev' into 4503-opcion-rocket
gitea/salix/pipeline/head This commit looks good Details
0009f27462 Merge branch 'dev' into 4503-opcion-rocket
gitea/salix/pipeline/head This commit looks good Details
6517e9e6ce Merge pull request 'fixes #4503 Añadir opción de rocket si o rocket no' (!1145) from 4503-opcion-rocket into dev 
Reviewed-on: #1145
Reviewed-by: Juan Ferrer <juan@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
cd71a59dfe Merge branch 'dev' into 4928-supplier-payMethod-notify
gitea/salix/pipeline/head This commit looks good Details
2bb37e733a Merge pull request 'fixes #4928 Supplier payMethod notify' (!1202) from 4928-supplier-payMethod-notify into dev 
Reviewed-on: #1202
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
pau added 2 commits 2022-12-22 07:25:04 +00:00
gitea/salix/pipeline/head This commit looks good Details
c0d285856b move sql files
pau added 1 commit 2022-12-22 07:25:40 +00:00
gitea/salix/pipeline/head This commit looks good Details
ea6d399cf1 Merge branch 'dev' into #288-traducir-state-i18n
juan approved these changes 2022-12-23 08:01:46 +00:00
pau added 1 commit 2022-12-23 08:09:40 +00:00
gitea/salix/pipeline/head This commit looks good Details
fc86e913c4 Merge branch 'dev' into #288-traducir-state-i18n
pau merged commit 1978d228ff into dev 2022-12-23 08:15:37 +00:00
pau deleted branch #288-traducir-state-i18n 2022-12-23 08:15:37 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
juan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1152
No description provided.
Delete Branch "#288-traducir-state-i18n"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?