fixes #3963 Adelantar la fecha de preparacion de tickets #1155

Merged
alexandre merged 38 commits from 3963-ticket-advance into dev 2022-12-21 07:37:23 +00:00
Contributor
No description provided.
alexandre added the
CR / Tests passed
label 2022-11-16 14:47:59 +00:00
alexandre added 23 commits 2022-11-16 14:48:01 +00:00
gitea/salix/pipeline/head This commit looks good Details
896a7eb6f0
refs #4700 arreglar filtro y traducciones
gitea/salix/pipeline/head This commit looks good Details
ff00066138
refs #4700 tests front y fixtures
gitea/salix/pipeline/head There was a failure building this commit Details
117e2c03f5
refs #4700 tests back y empezando e2e
gitea/salix/pipeline/head This commit looks good Details
c16210dd8a
refs #4700 working on e2e
gitea/salix/pipeline/head This commit looks good Details
0ef64481b9
refs #4700 e2e finished
gitea/salix/pipeline/head This commit looks good Details
03ea2b4f11
refs #4700 translations
gitea/salix/pipeline/head This commit looks good Details
05f0eba741
Merge branch 'split-tour' into 3963-ticket-advance
gitea/salix/pipeline/head This commit looks good Details
7dd87b1ea8
refs #4700 icons future
gitea/salix/pipeline/head This commit looks good Details
99aa674995
refs #3963 working on mockup
gitea/salix/pipeline/head This commit looks good Details
23ed6c6031
refs #3963 test front done
gitea/salix/pipeline/head This commit looks good Details
01607c71b6
fix rocket message and order table
gitea/salix/pipeline/head This commit looks good Details
97a6aff499
fix workerFk
gitea/salix/pipeline/head This commit looks good Details
b7c9d6ea50
refs #3963 front and back tests fixed
gitea/salix/pipeline/head This commit looks good Details
78dc7db7a7
correcciones
gitea/salix/pipeline/head This commit looks good Details
4feb2bea2c
working on e2e
gitea/salix/pipeline/head This commit looks good Details
489df60afc
suggested filter added
gitea/salix/pipeline/head This commit looks good Details
edb495c744
fix describe
alexandre requested review from jgallego 2022-11-16 14:50:32 +00:00
alexandre added 1 commit 2022-11-17 07:57:05 +00:00
gitea/salix/pipeline/head This commit looks good Details
c4430b4bca
fix acl
alexandre added 2 commits 2022-11-21 10:45:05 +00:00
alexandre added 1 commit 2022-11-21 10:48:31 +00:00
gitea/salix/pipeline/head This commit looks good Details
6ddd2d95a5
insert acl
alexandre added 2 commits 2022-11-22 09:20:55 +00:00
alexandre added 1 commit 2022-11-24 09:00:10 +00:00
alexandre added 1 commit 2022-11-24 09:28:38 +00:00
gitea/salix/pipeline/head This commit looks good Details
4fdcbb3077
Merge branch 'dev' into 3963-ticket-advance
alexandre added 2 commits 2022-11-25 09:26:04 +00:00
alexandre added 1 commit 2022-11-25 09:27:56 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
9f10129152
sql moved to 10510
alexandre added 1 commit 2022-11-25 11:47:08 +00:00
alexandre added 1 commit 2022-11-25 11:56:55 +00:00
jgallego requested review from joan 2022-11-29 07:15:15 +00:00
joan requested changes 2022-11-29 07:42:12 +00:00
@ -0,0 +1,104 @@
DROP PROCEDURE IF EXISTS vn.ticket_canAdvance;
Contributor

Template strings

Template strings
alexandre marked this conversation as resolved
@ -130,2 +130,2 @@
it('should search for the ticket with id 31 once again', async() => {
await page.accessToSearchResult('31');
it('should search for the ticket with id 32 once again', async() => {
await page.accessToSearchResult('32');
Contributor

Buscar por nickname del ticket u otro valor para evitar buscar por id

Buscar por nickname del ticket u otro valor para evitar buscar por id
alexandre marked this conversation as resolved
@ -0,0 +21,4 @@
required: true
},
{
arg: 'tfShipped',
Contributor

No utilizar abreviaturas

No utilizar abreviaturas
alexandre marked this conversation as resolved
@ -0,0 +88,4 @@
const where = buildFilter(ctx.args, (param, value) => {
switch (param) {
// case 'shipped':
Contributor

Esto sobra?

Esto sobra?
alexandre marked this conversation as resolved
@ -0,0 +20,4 @@
const ctx = { req: { accessToken: { userId: 9 } }, args };
const result = await models.Ticket.getTicketsAdvance(ctx, options);
expect(result.length).toEqual(1);
Contributor

Utilizar mejor .toBeGreatherThan()

Utilizar mejor .toBeGreatherThan()
alexandre marked this conversation as resolved
@ -176,3 +176,3 @@
const result = await models.Ticket.filter(ctx, filter, options);
expect(result.length).toEqual(26);
expect(result.length).toEqual(27);
Contributor

toBeGreatherThan()

toBeGreatherThan()
alexandre marked this conversation as resolved
@ -0,0 +1,12 @@
{
"name": "TicketAdvance",
Contributor

Eliminar modelo y mover rutas al modelo de ticket

Eliminar modelo y mover rutas al modelo de ticket
alexandre marked this conversation as resolved
@ -0,0 +65,4 @@
label="Warehouse"
ng-model="filter.warehouseFk"
url="Warehouses"
required="true">
Contributor

Esta propiedad parece que no es necesaria

Esta propiedad parece que no es necesaria
Author
Contributor

El procedimiento necesita como parámetros la fecha de los tickets que se quieren adelantar y el almacén

El procedimiento necesita como parámetros la fecha de los tickets que se quieren adelantar y el almacén
Contributor

Me refiero a la propiedad required

Me refiero a la propiedad required
alexandre marked this conversation as resolved
@ -0,0 +1,147 @@
<vn-crud-model
vn-id="model"
url="Tickets/getTicketsAdvance"
limit="20">
Contributor

No es necesario especificar limit 20 si es el predeterminado

No es necesario especificar limit 20 si es el predeterminado
alexandre marked this conversation as resolved
@ -0,0 +54,4 @@
<span translate>Destination ID</span>
</th>
<th field="destETD">
<span translate>Destination ETD</span>
Contributor

Añadir title con el nombre completo (Estimated time delivery..)

Añadir title con el nombre completo (Estimated time delivery..)
alexandre marked this conversation as resolved
@ -0,0 +56,4 @@
<th field="destETD">
<span translate>Destination ETD</span>
</th>
<th field="tfState">
Contributor

Quitar abreviaturas

Quitar abreviaturas
alexandre marked this conversation as resolved
@ -0,0 +16,4 @@
searchable: false
},
{
field: 'tfState',
Contributor

Abreviaturas

Abreviaturas
alexandre marked this conversation as resolved
alexandre added 1 commit 2022-11-29 07:51:08 +00:00
alexandre added 1 commit 2022-11-29 09:29:31 +00:00
gitea/salix/pipeline/head This commit looks good Details
cd8d5efa88
corrections
alexandre requested review from joan 2022-11-30 13:25:51 +00:00
jgallego requested changes 2022-12-09 13:50:08 +00:00
@ -0,0 +2,4 @@
DELIMITER $$
$$
CREATE DEFINER=`root`@`localhost` PROCEDURE `vn`.`ticket_canAdvance`(vDated DATE, vWarehouseFk INT)
Owner

vShipped o vLanded quedaria mes clar

vShipped o vLanded quedaria mes clar
alexandre marked this conversation as resolved
@ -0,0 +1,5 @@
Advance tickets: Adelantar tickets
Fruits and vegetables: Frutas y verduras
Owner

Ja no treballem amb açò, pot ser dinamic?

Ja no treballem amb açò, pot ser dinamic?
alexandre marked this conversation as resolved
@ -0,0 +1,6 @@
Advance tickets: Advance tickets
Success: Tickets moved successfully!
Fruits and vegetables: Fruits and vegetables
Owner

la mateix que dalt, intentar fer dinamic

la mateix que dalt, intentar fer dinamic
alexandre marked this conversation as resolved
@ -0,0 +4,4 @@
Success: Tickets movidos correctamente
Lines: Líneas
Liters: Litros
Fruits and vegetables: Frutas y verduras
Owner

traducir con i18n

traducir con i18n
alexandre marked this conversation as resolved
@ -36,3 +36,5 @@ import './sms';
import './boxing';
import './future';
import './future-search-panel';
import './advance'
Owner

;

;
alexandre marked this conversation as resolved
alexandre added 1 commit 2022-12-13 11:38:32 +00:00
alexandre added 1 commit 2022-12-13 13:01:16 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
dce48a8a93
refs #4700 corrections
alexandre added 1 commit 2022-12-13 13:03:58 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
050010c09f
refs #4700 success translation
alexandre requested review from jgallego 2022-12-13 14:07:07 +00:00
jgallego approved these changes 2022-12-13 16:48:20 +00:00
alexandre added 1 commit 2022-12-15 13:26:31 +00:00
alexandre added 1 commit 2022-12-16 06:57:00 +00:00
alexandre added 5 commits 2022-12-16 08:52:17 +00:00
alexandre added 3 commits 2022-12-16 12:45:49 +00:00
joan requested changes 2022-12-19 08:15:39 +00:00
@ -20,3 +20,3 @@
},
{
field: 'destETD',
field: 'tfShipped',
Contributor

Qué es tf? Evitar abreviaturas

Qué es tf? Evitar abreviaturas
alexandre marked this conversation as resolved
alexandre added 2 commits 2022-12-20 08:55:10 +00:00
alexandre added 2 commits 2022-12-20 10:37:15 +00:00
alexandre added 3 commits 2022-12-20 10:54:42 +00:00
alexandre added 1 commit 2022-12-20 11:10:17 +00:00
gitea/salix/pipeline/head This commit looks good Details
9291f4a380
refs #3963 sql moved
alexandre requested review from joan 2022-12-20 11:18:34 +00:00
alexandre requested review from jgallego 2022-12-20 14:20:16 +00:00
alexandre added 1 commit 2022-12-20 14:20:34 +00:00
gitea/salix/pipeline/head This commit looks good Details
140509202b
Merge branch 'dev' into 3963-ticket-advance
jgallego approved these changes 2022-12-21 06:31:51 +00:00
joan approved these changes 2022-12-21 07:29:31 +00:00
alexandre added 1 commit 2022-12-21 07:30:25 +00:00
gitea/salix/pipeline/head This commit looks good Details
081ef7fc99
Merge branch 'dev' into 3963-ticket-advance
alexandre merged commit ebb81a3377 into dev 2022-12-21 07:37:22 +00:00
alexandre deleted branch 3963-ticket-advance 2022-12-21 07:37:23 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1155
No description provided.