verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 67 Releases Wiki Activity

fixes #4557 duplicate-tickets-in-routes #1169

Merged
pau merged 6 commits from 4557-duplicate-tickets-in-routes into dev 2022-11-29 11:07:33 +00:00
Conversation 0 Commits 6 Files Changed 1 +30 -30
pau commented 2022-11-23 08:24:47 +00:00
Contributor
Copy Link
No description provided.
pau added the
CR / Tests passed
 label 2022-11-23 08:24:47 +00:00
pau added 2 commits 2022-11-23 08:24:48 +00:00
gitea/salix/pipeline/head This commit looks good Details
0f17c082a3 refs #4557 @1h left join note only delivery
joan requested changes 2022-11-24 08:08:40 +00:00
modules/route/back/methods/route/getTickets.js Outdated
@ -57,3 +57,3 @@
LEFT JOIN state st ON st.id = ts.stateFk
LEFT JOIN warehouse wh ON wh.id = t.warehouseFk
LEFT JOIN ticketObservation tob ON tob.ticketFk = t.id
LEFT JOIN ticketObservation tob ON tob.ticketFk = t.id AND tob.observationTypeFk = 3
joan commented 2022-11-24 08:08:37 +00:00
Contributor
Copy Link

No se pueden poner ID's directamente en el código. Hay que buscar otra solución, como buscar el observationType por código. Si no existe la columna, crearla.

No se pueden poner ID's directamente en el código. Hay que buscar otra solución, como buscar el observationType por código. Si no existe la columna, crearla.
pau marked this conversation as resolved
pau added 1 commit 2022-11-24 10:47:40 +00:00
gitea/salix/pipeline/head This commit looks good Details
37a7a12f87 requested change
pau added 1 commit 2022-11-24 11:06:30 +00:00
gitea/salix/pipeline/head This commit looks good Details
001c3ec2ac requested changes
pau requested review from joan 2022-11-25 06:05:02 +00:00
pau added 1 commit 2022-11-25 06:05:15 +00:00
joan approved these changes 2022-11-29 07:14:08 +00:00
pau added 1 commit 2022-11-29 08:22:08 +00:00
pau merged commit 3596700513 into dev 2022-11-29 11:07:33 +00:00
pau deleted branch 4557-duplicate-tickets-in-routes 2022-11-29 11:07:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
joan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1169
No description provided.
Delete Branch "4557-duplicate-tickets-in-routes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?