verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

4649-bookEntriesIncorrectly_notification #1188

Merged
joan merged 16 commits from 4649-bookEntriesIncorrectly_notification into dev 2022-12-22 10:43:22 +00:00
Conversation 1 Commits 16 Files Changed 11 +693 -3
vicent commented 2022-11-30 07:24:39 +00:00
Contributor
Copy Link
No description provided.
vicent added the
CR / Tests passed
 label 2022-11-30 07:24:39 +00:00
vicent added 4 commits 2022-11-30 07:24:40 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
c258587e02 feat: plantilla email para asientos contables importados incorrectamente
gitea/salix/pipeline/head There was a failure building this commit Details
89e9722027 refactor: cambiados varchar por text, para q no falle en local
gitea/salix/pipeline/head There was a failure building this commit Details
5c1b88fa44 detele: fixtures en español
vicent requested review from joan 2022-11-30 07:25:37 +00:00
vicent added 1 commit 2022-12-12 12:53:59 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
3d47ee1cd9 feat: inseet in notificationSubscription
joan requested changes 2022-12-13 07:45:20 +00:00
Dismissed
db/changes/10510-december/00-accountingMovements_add.sql Outdated
@ -0,0 +1,438 @@
DROP PROCEDURE IF EXISTS `sage`.`accountingMovements_add`;
joan commented 2022-12-13 07:35:44 +00:00
Contributor
Copy Link

Cambiar a carpeta actual

Cambiar a carpeta actual
vicent marked this conversation as resolved
db/changes/10510-december/00-notification_send.sql Outdated
@ -0,0 +13,4 @@
* @param vAuthorFk The notification author or %NULL if there is no author
* @return The notification id
*/
DECLARE vNotificationFk INT;
joan commented 2022-12-13 07:39:14 +00:00
Contributor
Copy Link

Eliminar variable

Eliminar variable
vicent marked this conversation as resolved
vicent added 2 commits 2022-12-13 08:56:19 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
91f955ccf5 refactor: move sql changes
vicent added 1 commit 2022-12-13 09:03:34 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
b852ab8e1f delete change
vicent requested review from joan 2022-12-13 09:03:56 +00:00
vicent added 1 commit 2022-12-15 13:33:07 +00:00
joan requested changes 2022-12-16 07:03:22 +00:00
Dismissed
db/changes/10510-december/00-notification_send.sql Outdated
@ -0,0 +1,24 @@
DROP FUNCTION IF EXISTS `util`.`notification_send`;
joan commented 2022-12-16 07:03:16 +00:00
Contributor
Copy Link

Si son cambios nuevos, moverlos todos a la última versión

Si son cambios nuevos, moverlos todos a la última versión
vicent marked this conversation as resolved
vicent added 2 commits 2022-12-16 07:59:44 +00:00
gitea/salix/pipeline/head This commit looks good Details
85148ab929 refactor: movidos changes sql
vicent requested review from joan 2022-12-16 07:59:59 +00:00
vicent added 2 commits 2022-12-20 09:53:25 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
d178800c14 movidos change sql
joan approved these changes 2022-12-21 07:01:09 +00:00
Dismissed
joan left a comment
Contributor
Copy Link

Revisar el test que falla de notificaciones

Revisar el test que falla de notificaciones
joan dismissed joan’s review 2022-12-21 07:01:33 +00:00
joan requested changes 2022-12-21 07:01:48 +00:00
joan left a comment
Contributor
Copy Link

Revisar tests

Revisar tests
vicent added 1 commit 2022-12-21 07:13:49 +00:00
vicent added 1 commit 2022-12-21 08:26:36 +00:00
gitea/salix/pipeline/head This commit looks good Details
6634ebcec5 fix: id duplicado en util.notification
vicent added 1 commit 2022-12-21 08:27:01 +00:00
vicent commented 2022-12-21 08:27:35 +00:00
Author
Contributor
Copy Link

Revisar tests

Ya se ha corregido, era por una fixture nueva que estaba dando conflicto

> Revisar tests Ya se ha corregido, era por una fixture nueva que estaba dando conflicto
vicent requested review from joan 2022-12-21 08:27:39 +00:00
joan approved these changes 2022-12-22 10:43:12 +00:00
joan merged commit 7c33cd2691 into dev 2022-12-22 10:43:22 +00:00
joan deleted branch 4649-bookEntriesIncorrectly_notification 2022-12-22 10:43:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
joan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1188
No description provided.
Delete Branch "4649-bookEntriesIncorrectly_notification"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?