verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

fixes #4962 Refactor Ticket Tour a Futuro #1212

Merged
alexandre merged 9 commits from 4700-split-tour into dev 2022-12-20 14:17:41 +00:00
Conversation 0 Commits 9 Files Changed 25 +346 -498
alexandre commented 2022-12-16 12:50:55 +00:00
Contributor
Copy Link
No description provided.
alexandre added 6 commits 2022-12-16 12:50:58 +00:00
gitea/salix/pipeline/head This commit looks good Details
dc33a46eee refs #4926 ticket tour future refactor
gitea/salix/pipeline/head There was a failure building this commit Details
f80f851e8d refs #4962 model TicketFuture deleted
gitea/salix/pipeline/head This commit looks good Details
98c9e0ac50 refs #4962 autoload added and second header
alexandre requested review from jgallego 2022-12-16 12:51:11 +00:00
jgallego approved these changes 2022-12-19 07:43:49 +00:00
e2e/helpers/selectors.js
@ -758,3 +756,2 @@
tableTfId: 'vn-textfield[name="ticketFuture"]',
tableLiters: 'vn-textfield[name="litersMax"]',
tableLines: 'vn-textfield[name="linesMax"]',
tableLiters: 'vn-textfield[name="liters"]',
jgallego commented 2022-12-19 07:38:19 +00:00
Owner
Copy Link

perque canvies el nom? l'anterior a mi em pareixia correcte, no son litros exactes, sino litros màxims

perque canvies el nom? l'anterior a mi em pareixia correcte, no son litros exactes, sino litros màxims
alexandre commented 2022-12-20 08:38:17 +00:00
Author
Contributor
Copy Link

Ho he tingut que posar aixina perque com en el procediment se diu 'lines' i 'liters' al ordenar me donava error. En veritat no passa res perque en el buscador ja apareix que son litres i linies màximes.

Ho he tingut que posar aixina perque com en el procediment se diu 'lines' i 'liters' al ordenar me donava error. En veritat no passa res perque en el buscador ja apareix que son litres i linies màximes.
modules/ticket/back/methods/ticket/merge.js Outdated
@ -46,2 +46,2 @@
originDated: dateUtil.toString(new Date(ticket.originETD)),
futureDated: dateUtil.toString(new Date(ticket.destETD)),
originDated: dateUtil.toString(new Date(ticket.shipped)),
futureDated: dateUtil.toString(new Date(ticket.tfShipped)),
jgallego commented 2022-12-19 07:40:34 +00:00
Owner
Copy Link

que es tf? llegint veig que es abreviatura de ticket future.
Com ticket ja es sap jo posaria ticket.futureShipped

que es tf? llegint veig que es abreviatura de ticket future. Com ticket ja es sap jo posaria ticket.futureShipped
alexandre marked this conversation as resolved
jgallego requested review from juan 2022-12-19 07:44:07 +00:00
juan approved these changes 2022-12-19 10:08:38 +00:00
alexandre added 1 commit 2022-12-20 08:54:44 +00:00
alexandre added 1 commit 2022-12-20 10:37:58 +00:00
alexandre added 1 commit 2022-12-20 10:54:08 +00:00
gitea/salix/pipeline/head This commit looks good Details
4c6a735235 refs #4962 moved sql and methods to ticket
alexandre requested review from jgallego 2022-12-20 11:11:11 +00:00
jgallego approved these changes 2022-12-20 14:16:22 +00:00
alexandre merged commit c949b7f6c7 into dev 2022-12-20 14:17:41 +00:00
alexandre deleted branch 4700-split-tour 2022-12-20 14:17:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
juan
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1212
No description provided.
Delete Branch "4700-split-tour"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?