verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 58 Releases Wiki Activity

Fix missing report for the invoice electronic notification #1216

Merged
pau merged 9 commits from Hotfix-crear-report-Factura-Electronica into master 2022-12-27 08:04:33 +00:00
Conversation 0 Commits 9 Files Changed 8 +51 -2
pau commented 2022-12-20 13:22:19 +00:00
Contributor
Copy Link
No description provided.
pau added the
CR / Tests passed
 label 2022-12-20 13:22:19 +00:00
pau added 1 commit 2022-12-20 13:22:21 +00:00
pau requested review from joan 2022-12-20 13:28:03 +00:00
pau changed target branch from dev to master 2022-12-20 13:39:09 +00:00
joan approved these changes 2022-12-21 06:53:35 +00:00
Dismissed
joan requested review from alexm 2022-12-21 06:53:55 +00:00
alexm requested changes 2022-12-21 07:15:17 +00:00
modules/ticket/front/descriptor-menu/index.js
@ -255,3 +255,3 @@
if (client.hasElectronicInvoice) {
this.$http.post(`NotificationQueues`, {
notificationFk: 'invoiceElectronic',
notificationFk: 'invoice-electronic',
alexm commented 2022-12-21 07:06:32 +00:00
Member
Copy Link

Cambia la fixture de invoiceElectronic a invoice-electronic

Cambia la fixture de invoiceElectronic a invoice-electronic
pau marked this conversation as resolved
pau added 1 commit 2022-12-22 06:13:12 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
314bd69d6e Merge branch 'master' into Hotfix-crear-report-Factura-Electronica
pau added 2 commits 2022-12-22 06:16:39 +00:00
pau requested review from alexm 2022-12-22 06:18:36 +00:00
alexm requested changes 2022-12-22 06:52:10 +00:00
db/changes/225001/00-insert_notification_invoiceE.sql Outdated
@ -0,0 +1 @@
insert into `util`.`notification` (`id`, `name`,`description`) values (2, 'invoice-electronic', 'A electronic invoice has been generated');
alexm commented 2022-12-22 06:52:04 +00:00
Member
Copy Link

Poner en fixtures id:2

Poner en fixtures id:2
pau marked this conversation as resolved
pau added 1 commit 2022-12-22 09:41:17 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
fce0352986 add fixtures
pau added 1 commit 2022-12-22 09:41:36 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
c2390c9f9f Merge branch 'master' into Hotfix-crear-report-Factura-Electronica
pau requested review from alexm 2022-12-22 09:41:43 +00:00
alexm approved these changes 2022-12-22 10:47:29 +00:00
joan dismissed joan’s review 2022-12-23 07:08:35 +00:00
joan requested changes 2022-12-23 07:10:35 +00:00
joan left a comment
Contributor
Copy Link

Mover cambios SQL a versión 225002 (Tendrás que crear la carpeta, para versión minor del sprint 2250.x)

La versión 225001 ya está aplicada en producción y no aplicará estos cambios cuando suba a master

Mover cambios SQL a versión 225002 (Tendrás que crear la carpeta, para versión minor del sprint 2250.x) La versión 225001 ya está aplicada en producción y no aplicará estos cambios cuando suba a master
pau added 1 commit 2022-12-26 06:18:52 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
1c1cc93ef4 Merge branch 'master' into Hotfix-crear-report-Factura-Electronica
pau added 1 commit 2022-12-26 06:23:14 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
8696d554d6 Change SQL folder
pau requested review from joan 2022-12-26 06:23:47 +00:00
alexm requested changes 2022-12-27 06:10:50 +00:00
db/changes/225002/00-insert_notification_invoiceE.sql Outdated
@ -0,0 +1 @@
insert into `util`.`notification` (`id`, `name`,`description`) values (2, 'invoice-electronic', 'A electronic invoice has been generated');
alexm commented 2022-12-27 06:10:42 +00:00
Member
Copy Link

Si el insert ja esta fet en produccio i també esta possat en una fixture jo crec q no cal possarlo també aci.

Si el insert ja esta fet en produccio i també esta possat en una fixture jo crec q no cal possarlo també aci.
pau marked this conversation as resolved
pau added 1 commit 2022-12-27 06:23:36 +00:00
gitea/salix/pipeline/head This commit looks good Details
7aeeddcf18 removed the sql
pau requested review from alexm 2022-12-27 06:24:06 +00:00
alexm approved these changes 2022-12-27 06:28:26 +00:00
pau merged commit 6e6dc73d59 into master 2022-12-27 08:04:33 +00:00
pau deleted branch Hotfix-crear-report-Factura-Electronica 2022-12-27 08:04:34 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
joan
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1216
No description provided.
Delete Branch "Hotfix-crear-report-Factura-Electronica"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?