fixes #4927 supplier.fiscal-data permitir 'Razón social' duplicada #1230

Merged
joan merged 24 commits from 4927-permitir-razonSocial-duplicada into dev 2023-02-02 07:47:39 +00:00
Contributor
No description provided.
alexandre added the
CR / Tests passed
label 2022-12-27 09:44:52 +00:00
alexandre added 1 commit 2022-12-27 09:44:54 +00:00
gitea/salix/pipeline/head This commit looks good Details
5eda1388ef
refs #4927 unique key added
alexandre requested review from joan 2022-12-27 09:45:11 +00:00
alexandre added 1 commit 2023-01-02 06:07:28 +00:00
alexandre added 1 commit 2023-01-03 11:31:56 +00:00
joan approved these changes 2023-01-05 07:32:53 +00:00
alexandre added 1 commit 2023-01-05 07:45:03 +00:00
alexandre requested review from joan 2023-01-05 07:56:51 +00:00
joan approved these changes 2023-01-10 07:28:13 +00:00
alexandre added 1 commit 2023-01-10 08:49:46 +00:00
alexandre scheduled this pull request to auto merge when all checks succeed 2023-01-10 08:50:37 +00:00
alexandre requested review from joan 2023-01-10 08:58:47 +00:00
alexandre added 1 commit 2023-01-10 10:45:03 +00:00
joan requested review from jgallego 2023-01-12 07:42:00 +00:00
joan refused to review 2023-01-12 07:42:02 +00:00
alexandre added 2 commits 2023-01-12 13:11:15 +00:00
alexandre added 1 commit 2023-01-13 07:38:42 +00:00
gitea/salix/pipeline/head This commit looks good Details
41671e8a3a
refs #4927 modified hook to check name & country
alexandre requested review from joan 2023-01-13 08:10:58 +00:00
alexandre added 1 commit 2023-01-16 09:33:46 +00:00
jgallego requested changes 2023-01-16 18:04:44 +00:00
@ -131,0 +127,4 @@
if (nameChanged || countryChanged) {
if (!isAlpha(name)) throw new UserError('The social name has an invalid format');
const supplier = await Self.app.models.Supplier.findOne({where: {name, countryFk}, fields: ['id']});
Owner

Esta duplicada la validació, que confirme Juan açò

Esta duplicada la validació, que confirme Juan açò
Owner

Si, en principio con la clave UNIQUE que se crea en la tabla es suficiente

Si, en principio con la clave UNIQUE que se crea en la tabla es suficiente
alexandre requested review from juan 2023-01-17 08:01:50 +00:00
joan refused to review 2023-01-17 11:32:13 +00:00
alexandre added 1 commit 2023-01-19 08:34:49 +00:00
juan requested changes 2023-01-19 20:07:36 +00:00
@ -130,1 +121,3 @@
throw new UserError('The social name has an invalid format');
if (hasChanges) {
const name = changes.name || orgData.name;
const nameChanged = hasChanges && orgData.name != name;
Owner

hasChanges ya se esta evaluando en el if, no es necesario repetirlo aquí

`hasChanges` ya se esta evaluando en el if, no es necesario repetirlo aquí
@ -131,0 +122,4 @@
const name = changes.name || orgData.name;
const nameChanged = hasChanges && orgData.name != name;
const countryFk = changes.countryFk || orgData.countryFk;
const countryChanged = hasChanges && orgData.countryFk != countryFk;
Owner

No es necesario evaluar hasChanges

No es necesario evaluar `hasChanges`
alexandre added 2 commits 2023-01-20 06:15:17 +00:00
alexandre added 1 commit 2023-01-20 09:03:17 +00:00
gitea/salix/pipeline/head This commit looks good Details
f30b1ecff1
refs #4927 changed hook for validateAsync
alexandre added 1 commit 2023-01-20 09:05:57 +00:00
alexandre added 1 commit 2023-01-20 09:33:37 +00:00
gitea/salix/pipeline/head This commit looks good Details
b281a51d90
refs #4927 refresh structure
alexandre requested review from juan 2023-01-20 10:02:42 +00:00
alexandre added 1 commit 2023-01-23 12:44:30 +00:00
juan approved these changes 2023-01-26 16:19:25 +00:00
alexandre added 1 commit 2023-01-27 06:59:23 +00:00
alexandre requested review from jgallego 2023-01-27 08:02:37 +00:00
alexandre requested review from joan 2023-01-27 08:02:45 +00:00
jgallego approved these changes 2023-01-27 10:03:23 +00:00
alexandre added 1 commit 2023-01-27 10:09:38 +00:00
joan requested changes 2023-01-30 11:14:17 +00:00
CHANGELOG.md Outdated
@ -29,6 +29,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
- (Reclamaciones -> Descriptor) Cambiado el campo Agencia por Zona
- (Tickets -> Líneas preparadas) Actualizada sección para que sea más visual
- (Proveedores -> Crear/Editar) Permite añadir Proveedores con la misma razón social pero con países distintos
Contributor

Este cambio debería ir en la versión actual

Este cambio debería ir en la versión actual
alexandre added 2 commits 2023-01-30 11:22:15 +00:00
alexandre added 1 commit 2023-01-30 11:26:15 +00:00
gitea/salix/pipeline/head This commit looks good Details
03d75c5b72
refs #4927 changelog modified
alexandre requested review from joan 2023-01-30 11:27:31 +00:00
alexandre added 1 commit 2023-02-01 07:46:40 +00:00
jgallego approved these changes 2023-02-01 08:39:47 +00:00
alexandre added 1 commit 2023-02-02 07:41:04 +00:00
joan approved these changes 2023-02-02 07:43:58 +00:00
joan merged commit 85bde58752 into dev 2023-02-02 07:47:39 +00:00
joan deleted branch 4927-permitir-razonSocial-duplicada 2023-02-02 07:47:40 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1230
No description provided.