verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 67 Releases Wiki Activity

fixes #4951 Comprobar longitud de cuentas contables al generar asientos #1238

Merged
alexandre merged 5 commits from 4951-longitud-cuentaContables into dev 2023-01-17 07:30:37 +00:00
Conversation 0 Commits 5 Files Changed 1 +73
alexandre commented 2023-01-04 07:38:07 +00:00
Contributor
Copy Link
No description provided.
alexandre added 1 commit 2023-01-04 07:38:09 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
f499311a16 refs #4951 changed triggers and added checkLength
alexandre added 1 commit 2023-01-04 09:38:14 +00:00
gitea/salix/pipeline/head This commit looks good Details
a4e591c5f5 refs #4951 triggers modified
alexandre added the
CR / Tests passed
 label 2023-01-04 09:38:29 +00:00
alexandre requested review from joan 2023-01-04 09:38:37 +00:00
alexandre changed title from WIP: #4951 Comprobar longitud de cuentas contables al genera asientos to fixes #4951 Comprobar longitud de cuentas contables al generar asientos 2023-01-04 09:38:48 +00:00
joan requested review from jgallego 2023-01-05 07:28:57 +00:00
joan refused to review 2023-01-05 07:31:39 +00:00
jgallego requested changes 2023-01-10 06:41:12 +00:00
db/changes/230201/00-triggersXDiario.sql
@ -0,0 +8,4 @@
FOR EACH ROW
BEGIN
IF NOT NEW.SUBCTA <=> OLD.SUBCTA THEN
IF NEW.SUBCTA <=> '' THEN
jgallego commented 2023-01-10 06:40:41 +00:00
Owner
Copy Link

Este if, sobraria, perque si li pases '' la funció length ja et trau el fallo

Este if, sobraria, perque si li pases '' la funció length ja et trau el fallo
alexandre commented 2023-01-10 07:00:44 +00:00
Author
Contributor
Copy Link

Ho gaste per a transformar '' en NULL. Me digué Carlos que ho posara aixina perque lo correcte seria que no se pogueren tindre camps buits (que es el que passa si borres directament el camp en la base de dades), sinó camps en NULL.

Ho gaste per a transformar '' en NULL. Me digué Carlos que ho posara aixina perque lo correcte seria que no se pogueren tindre camps buits (que es el que passa si borres directament el camp en la base de dades), sinó camps en NULL.
jgallego commented 2023-01-11 10:32:04 +00:00
Owner
Copy Link

Ho entenc, pero si just baix valides la longitud, en cap cas insertes '' ni null, sino que trau fallo.

Ho entenc, pero si just baix valides la longitud, en cap cas insertes '' ni null, sino que trau fallo.
alexandre commented 2023-01-11 10:39:54 +00:00
Author
Contributor
Copy Link

En el casos que siga '' o NULL no trau fallo, només trau fallo si la cadena no és null i la longitud no és 10

En el casos que siga '' o NULL no trau fallo, només trau fallo si la cadena no és null i la longitud no és 10
db/changes/230201/00-triggersXDiario.sql Outdated
@ -0,0 +11,4 @@
IF NEW.SUBCTA <=> '' THEN
SET NEW.SUBCTA = NULL;
END IF;
IF NEW.SUBCTA IS NOT NULL AND NOT util.checkStringLength(NEW.SUBCTA, 10) THEN
jgallego commented 2023-01-10 06:38:53 +00:00
Owner
Copy Link

has valorat posar directament LENGTH(vString) <=> 10 en el if?
i així no creem la funcio?

has valorat posar directament LENGTH(vString) <=> 10 en el if? i així no creem la funcio?
alexandre commented 2023-01-10 07:01:44 +00:00
Author
Contributor
Copy Link

Me va dir Carlos que creara la funció i la posara en util perque aixina se pot gastar en més llocs

Me va dir Carlos que creara la funció i la posara en util perque aixina se pot gastar en més llocs
jgallego commented 2023-01-11 07:46:07 +00:00
Owner
Copy Link

He parlat en Juan i ell tampoc crearia una funció, ni aporta molta legibilitat, ni lleva linies de codi.
No es justifica.

He parlat en Juan i ell tampoc crearia una funció, ni aporta molta legibilitat, ni lleva linies de codi. No es justifica.
alexandre added 1 commit 2023-01-11 07:49:07 +00:00
alexandre added 1 commit 2023-01-11 08:13:33 +00:00
gitea/salix/pipeline/head This commit looks good Details
a42723210f refs #4951 delete function
alexandre requested review from jgallego 2023-01-11 08:14:19 +00:00
jgallego approved these changes 2023-01-16 18:09:30 +00:00
alexandre added 1 commit 2023-01-17 06:59:36 +00:00
gitea/salix/pipeline/head This commit looks good Details
ba3335b9a2 Merge branch 'dev' into 4951-longitud-cuentaContables
alexandre merged commit be1f9bdd1b into dev 2023-01-17 07:30:37 +00:00
alexandre deleted branch 4951-longitud-cuentaContables 2023-01-17 07:30:37 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1238
No description provided.
Delete Branch "4951-longitud-cuentaContables"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?