fixes #5036 Regularizar históricos #1244

Merged
alexandre merged 32 commits from 5036-regularizar-historicos into dev 2023-03-16 07:26:33 +00:00
Contributor
No description provided.
alexandre added 1 commit 2023-01-09 12:50:29 +00:00
gitea/salix/pipeline/head This commit looks good Details
e0fa7609cb
refs #5036 transaction added
alexandre added 1 commit 2023-01-09 13:36:08 +00:00
alexandre added 1 commit 2023-01-10 14:24:39 +00:00
gitea/salix/pipeline/head This commit looks good Details
bebbe1c846
refs #5036 fixed transaction
alexandre added 1 commit 2023-01-11 12:25:13 +00:00
gitea/salix/pipeline/head This commit looks good Details
a0491de9f9
refs #5036 refactor transaction and fixing ticket logs
alexandre added 1 commit 2023-01-17 09:11:32 +00:00
alexandre added 1 commit 2023-01-18 12:22:44 +00:00
alexandre added 1 commit 2023-01-23 12:26:20 +00:00
alexandre added 1 commit 2023-01-25 07:56:26 +00:00
alexandre added the
CR / Tests passed
label 2023-01-26 14:43:41 +00:00
alexandre added 1 commit 2023-01-26 14:49:02 +00:00
alexandre added 1 commit 2023-01-26 14:49:45 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
d69b204c4c
refs #5036 loggable refactored, tests fixed
alexandre changed title from WIP: #5036 Regularizar historicos to fixes #5036 Regularizar históricos 2023-01-26 14:51:34 +00:00
alexandre requested review from juan 2023-01-26 14:51:40 +00:00
juan requested changes 2023-01-26 15:58:50 +00:00
@ -222,0 +304,4 @@
'updateOrCreate',
'replaceOrCreate',
'replaceById',
'updateAttributes',
Owner

Llevar updateAttributes

Llevar `updateAttributes`
alexandre marked this conversation as resolved
@ -222,0 +306,4 @@
'replaceById',
'updateAttributes',
'update'
]);
Owner

Declarar-ho fora de la funció per a que no ho faça cada vegada.

Declarar-ho fora de la funció per a que no ho faça cada vegada.
alexandre marked this conversation as resolved
@ -222,0 +314,4 @@
update: [
'update',
'replaceById',
'updateAttributes',
Owner

Llevar updateAttributes

Llevar `updateAttributes`
alexandre marked this conversation as resolved
@ -222,0 +333,4 @@
for (const op in opOpts) {
for (const met of opOpts[op])
opMap.set(met, op);
}
Owner

Declarar opOpts i opMap fora de la funció per a que no ho faça cada vegada.

Declarar `opOpts` i `opMap` fora de la funció per a que no ho faça cada vegada.
alexandre marked this conversation as resolved
@ -222,0 +357,4 @@
const res = await new Promise(resolve => {
const fnArgs = args.slice(0, -2);
fnArgs.push(opts);
fnArgs.push((...args) => resolve(args));
Owner

Pots afegir els dos arguments en una instrucció fnArgs.push(opts, (...args) => resolve(args));

Pots afegir els dos arguments en una instrucció `fnArgs.push(opts, (...args) => resolve(args));`
alexandre marked this conversation as resolved
@ -222,0 +514,4 @@
// Delete unchanged properties
if (oldI) {
Object.keys(oldI).forEach(prop => {
if (newI[prop] == oldI[prop]) {
Owner

Ficar igual estricte ===, no està tenint en compte les dates

Ficar igual estricte `===`, no està tenint en compte les dates
Owner

Com has resolt açò? Continue vejent ===, les dates no es poden comparar aixina

Com has resolt açò? Continue vejent `===`, les dates no es poden comparar aixina
alexandre marked this conversation as resolved
alexandre added 1 commit 2023-01-27 07:52:45 +00:00
gitea/salix/pipeline/head This commit looks good Details
a12f629690
refs #5036 corrections
alexandre requested review from juan 2023-01-27 07:59:45 +00:00
alexandre added 1 commit 2023-01-27 07:59:53 +00:00
gitea/salix/pipeline/head This commit looks good Details
355c9d855d
Merge branch 'dev' into 5036-regularizar-historicos
alexandre added 1 commit 2023-02-02 08:41:00 +00:00
gitea/salix/pipeline/head This commit looks good Details
3b0e8c2412
Merge branch 'dev' into 5036-regularizar-historicos
juan requested changes 2023-02-03 09:03:26 +00:00
@ -222,0 +324,4 @@
try {
// Fetch old values (update|delete) or login
await this.grabUserLog(model, opts, 'login');
Owner

Si grabUser està habilitat, els disparadors de la taula ja creen els logs, despres de açò no has de fer res mes a part de logout i finalitzar transacció

Si grabUser està habilitat, els disparadors de la taula ja creen els logs, despres de açò no has de fer res mes a part de logout i finalitzar transacció
alexandre marked this conversation as resolved
@ -222,0 +414,4 @@
buildSelectStmt(op, data, idName, model, where, limit) {
const Model = this.getModelDefinition(model).model;
const settings = Model.definition.settings;
Owner

Nomes es gasta en la línia 419, no es necesari definir la variable

Nomes es gasta en la línia 419, no es necesari definir la variable
alexandre marked this conversation as resolved
@ -222,0 +416,4 @@
const Model = this.getModelDefinition(model).model;
const settings = Model.definition.settings;
const properties = Object.keys(Model.definition.properties);
const log = settings.log;
Owner

Nomes es gasta en el else, declarar dins del else: const log = Model.definition.settings.log;

Nomes es gasta en el `else`, declarar dins del else: `const log = Model.definition.settings.log;`
alexandre marked this conversation as resolved
alexandre added 2 commits 2023-02-03 11:04:15 +00:00
alexandre added 1 commit 2023-02-16 07:54:57 +00:00
gitea/salix/pipeline/head This commit looks good Details
f42fbb80ec
refs #5036 changes
alexandre added 1 commit 2023-02-16 07:55:21 +00:00
gitea/salix/pipeline/head This commit looks good Details
ad5dcf5d75
Merge branch 'dev' into 5036-regularizar-historicos
alexandre added 2 commits 2023-02-20 08:20:48 +00:00
alexandre added 1 commit 2023-02-22 08:27:54 +00:00
alexandre added 1 commit 2023-02-24 07:55:15 +00:00
gitea/salix/pipeline/head This commit looks good Details
6590c6f1fa
refs #5036 transferSales also transfer sale's logs
alexandre added 1 commit 2023-02-27 06:05:34 +00:00
gitea/salix/pipeline/head This commit looks good Details
76cd2d160e
Merge branch 'dev' into 5036-regularizar-historicos
alexandre requested review from juan 2023-02-27 06:06:24 +00:00
juan requested changes 2023-02-28 14:57:11 +00:00
juan left a comment
Owner

Si grabUser està habilitat salix no ha de crear logs, nomes fer login i logout

Si grabUser està habilitat salix no ha de crear logs, nomes fer login i logout
alexandre added 1 commit 2023-03-07 12:10:16 +00:00
alexandre added 1 commit 2023-03-07 12:10:27 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
59a3ff0f7b
Merge branch 'dev' into 5036-regularizar-historicos
alexandre requested review from juan 2023-03-07 12:12:18 +00:00
alexandre added 2 commits 2023-03-07 13:11:14 +00:00
alexandre added 1 commit 2023-03-08 06:48:27 +00:00
alexandre added 1 commit 2023-03-08 10:43:59 +00:00
gitea/salix/pipeline/head This commit looks good Details
9dd242908e
.
alexandre added 1 commit 2023-03-09 06:50:43 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
9ff920c67e
Merge branch 'dev' into 5036-regularizar-historicos
juan requested changes 2023-03-10 08:44:27 +00:00
@ -222,0 +411,4 @@
else if(action == 'logout')
await this.executeP(`CALL account.myUser_logout()`, null, opts);
}
Owner

El funcionamiento de esta función es confuso y además su código no se reutiliza.

Quitar la función y mover cada bloque de código a su sitio correspondiente.

El funcionamiento de esta función es confuso y además su código no se reutiliza. Quitar la función y mover cada bloque de código a su sitio correspondiente.
alexandre marked this conversation as resolved
alexandre added 1 commit 2023-03-10 09:02:43 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
e66974f77f
refs #5036 removed grabUserLog function
alexandre added 1 commit 2023-03-10 09:03:04 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
0cac62da76
Merge branch 'dev' into 5036-regularizar-historicos
alexandre requested review from juan 2023-03-10 09:03:37 +00:00
juan approved these changes 2023-03-16 06:42:20 +00:00
alexandre added 151 commits 2023-03-16 06:42:50 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
b406551f52
delete: old section
gitea/salix/pipeline/head There was a failure building this commit Details
7b8a9791b4
refactor: code
gitea/salix/pipeline/head There was a failure building this commit Details
4295ae0108
delete
gitea/salix/pipeline/head There was a failure building this commit Details
4579758ba6
refactor: add translation
gitea/salix/pipeline/head There was a failure building this commit Details
3801436dc0
feat: mostrar fallos, mostrar más datos y actualizar estilo
gitea/salix/pipeline/head This commit looks good Details
2b62e16164
fix: test
gitea/salix/pipeline/head This commit looks good Details
d16235cba9
fix: show error when is negative base
gitea/salix/pipeline/head This commit looks good Details
5a5e4c5afb
feat: solo coge los tickets que no esten eliminados
gitea/salix/pipeline/head This commit looks good Details
84788afc10
delete: old button
gitea/salix/pipeline/head This commit looks good Details
e659f0f020
refacotor: delete duplicated variable
gitea/salix/pipeline/head This commit looks good Details
3e920e6a2f
corregida traduccion
gitea/salix/pipeline/head This commit looks good Details
020068006c
fix: manejado error si no se selecciona una empresa
gitea/salix/pipeline/head This commit looks good Details
caff537f2e
feat: imprime las facturas
gitea/salix/pipeline/head This commit looks good Details
9042eaaf9f
add fixtures
gitea/salix/pipeline/head This commit looks good Details
b801ac676c
feat: updated production db
gitea/salix/pipeline/head This commit looks good Details
f7ee6c18ca
refactor: movido codigo que imprime pdf dentro del try
gitea/salix/pipeline/head This commit looks good Details
76fe32924c
fix: update url
gitea/salix/pipeline/head This commit looks good Details
eef926d09d
fix: fixtures
gitea/salix/pipeline/head This commit looks good Details
41914f9e4f
feat: añadido desplegable impresora
gitea/salix/pipeline/head This commit looks good Details
adc2c32ac4
feat: add changes sql
gitea/salix/pipeline/head Something is wrong with the build of this commit Details
ae051c73f2
feat: añadir clientes al principio del array y borrarlos si han sido OK
gitea/salix/pipeline/head There was a failure building this commit Details
facaee6f95
feat: añadido contador y porcetaje
gitea/salix/pipeline/head There was a failure building this commit Details
61b0aa079a
refactor
gitea/salix/pipeline/head There was a failure building this commit Details
06b4e03320
feat: muestra en número de clientes en vez de su id
gitea/salix/pipeline/head There was a failure building this commit Details
f22f045444
refactor: add css
gitea/salix/pipeline/head There was a failure building this commit Details
6ea1415895
refactor: traducciones
gitea/salix/pipeline/head There was a failure building this commit Details
77340c8459
refactor: html
gitea/salix/pipeline/head There was a failure building this commit Details
0ba95bd163
feat: mostrar error
gitea/salix/pipeline/head There was a failure building this commit Details
67127554f9
feat: solo muestra los clientes con error y muestra los datos de manera distinta
gitea/salix/pipeline/head There was a failure building this commit Details
f7fa082294
refator: name endpoint
gitea/salix/pipeline/head Something is wrong with the build of this commit Details
0ffbb5fe2c
feat: actualizada visualizacion de datos
gitea/salix/pipeline/head There was a failure building this commit Details
3b94f916b7
refactor
gitea/salix/pipeline/head This commit looks good Details
cda7a6e3fd
fix: no mostraba los numeros de la semana al inicio
gitea/salix/pipeline/head This commit looks good Details
be539a54ce
delete console.log
gitea/salix/pipeline/head There was a failure building this commit Details
4754dc7bda
feat: actualizada sql intrastat
gitea/salix/pipeline/head There was a failure building this commit Details
e61af5286b
fix: actualizada sql intrastat
gitea/salix/pipeline/head There was a failure building this commit Details
05d91ed50e
feat: actualizada interfaz
gitea/salix/pipeline/head This commit looks good Details
35b47c6da2
refactor code
gitea/salix/pipeline/head There was a failure building this commit Details
4cc6485cbd
refs #5000 Invoicing RC
gitea/salix/pipeline/head There was a failure building this commit Details
7f60335a91
refs #5000 Invoicing: front tests refactor & fixes
gitea/salix/pipeline/head This commit looks good Details
9310e92223
refactor
gitea/salix/pipeline/head There was a failure building this commit Details
ffdfd1a7e5
refs #5000 Invoicing change structure
gitea/salix/pipeline/head There was a failure building this commit Details
6f5e25493d
invoicing test
gitea/salix/pipeline/head There was a failure building this commit Details
7c24b940b3
feat: colorea los numeros de la semana al inicio y cada vez que canvias de mes
gitea/salix/pipeline/head This commit looks good Details
497d756af6
fix: autocompletar el switf/bic
gitea/salix/pipeline/head This commit looks good Details
e39690c2c9
merge with dev
gitea/salix/pipeline/head There was a failure building this commit Details
a98bb59479
fix: test front
gitea/salix/pipeline/head This commit looks good Details
4830f8489a
remove unnecessary fixtures
gitea/salix/pipeline/head This commit looks good Details
b6e993dadf
fix: e2e
gitea/salix/pipeline/head There was a failure building this commit Details
760690a625
fix: test front
gitea/salix/pipeline/head There was a failure building this commit Details
0396d3707c
refator: creada ruta de back, en vez de hacer peticiones http anidadas en el front
gitea/salix/pipeline/head There was a failure building this commit Details
f461c75af1
feat: add front test
gitea/salix/pipeline/head There was a failure building this commit Details
79023fbfaf
feat: add backTest
gitea/salix/pipeline/head There was a failure building this commit Details
07edacd557
fix: frontTest
gitea/salix/pipeline/head This commit looks good Details
32429a58e0
refs #5000 remove consolelog
gitea/salix/pipeline/head There was a failure building this commit Details
6d7874d3ab
refs #5380 JSON modificado HTML arreglado
gitea/salix/pipeline/head There was a failure building this commit Details
0c22c1b0de
refs #5368 Fix expedition-pallet-label
gitea/salix/pipeline/head There was a failure building this commit Details
c46d325e23
fix: add transaction
gitea/salix/pipeline/head There was a failure building this commit Details
2363828092
hotfix clientUnpaid
gitea/salix/pipeline/head There was a failure building this commit Details
223b8f6d00
fix: intermittentBack test
gitea/salix/pipeline/head This commit looks good Details
c105316a04
delete testBack
gitea/salix/pipeline/head There was a failure building this commit Details
08254e28bb
refs #5380 mod label max m3
gitea/salix/pipeline/head This commit looks good Details
5a0b567908
Merge branch 'dev' into 5380-m3/itemMaxSize
gitea/salix/pipeline/head This commit looks good Details
901a8ab112
refs #5151 botones
gitea/salix/pipeline/head This commit looks good Details
19fcf5d536
feat: add column 'description'
gitea/salix/pipeline/head There was a failure building this commit Details
63ccb26bf3
refs #5151
gitea/salix/pipeline/head There was a failure building this commit Details
1ef454681c
fix: faltaba this delante de formateDate
gitea/salix/pipeline/head This commit looks good Details
9bc86b1617
Added missing relation
gitea/salix/pipeline/head This commit looks good Details
1b984f4325
Event callback
gitea/salix/pipeline/head This commit looks good Details
6cc7017475
Merge branch 'dev' into 4856-worker.time-control
gitea/salix/pipeline/head This commit looks good Details
b58135f611
Merge pull request '5035-tryToSolve_intermittentBackTest' (!1379) from 5035-tryToSolve_intermittentBackTest into dev
Reviewed-on: #1379
Reviewed-by: Joan Sanchez <joan@verdnatura.es>
gitea/salix/pipeline/head There was a failure building this commit Details
63d7dafcde
feat(print): added reusable pdf print functions
Refs #5182
gitea/salix/pipeline/head There was a failure building this commit Details
e947672c69
Merge branch 'dev' into 5352-worker.create_swift/bic
gitea/salix/pipeline/head There was a failure building this commit Details
2be7320d89
refs #4856 fix: backTest
gitea/salix/pipeline/head This commit looks good Details
6495e016a8
Endpoints refactor
gitea/salix/pipeline/head There was a failure building this commit Details
28730f3262
Attachment fixes
gitea/salix/pipeline/head Build queued... Details
6d3fa34624
refs #5000 invoiceOutGlobal
gitea/salix/pipeline/head This commit looks good Details
cd40705ecd
Merge branch 'dev' into 5182-print_publish
gitea/salix/pipeline/head This commit looks good Details
6b375cbaaa
refs #5000 InvoiceOut
gitea/salix/pipeline/head There was a failure building this commit Details
1047ac0b64
refs #4980 fix: la sección no estaba filtrando por el filtro por defecto
gitea/salix/pipeline/head This commit looks good Details
4e0567eb0c
Merge pull request '5000-invoiceOut.global-invoicing' (!1322) from 5000-invoiceOut.global-invoicing into dev
Reviewed-on: #1322
Reviewed-by: Javi Gallego <jgallego@verdnatura.es>
gitea/salix/pipeline/head There was a failure building this commit Details
5f64c23495
Merge branch 'dev' into 5352-worker.create_swift/bic
gitea/salix/pipeline/head There was a failure building this commit Details
59a87ba519
Merge branch 'dev' into 5151-claim.descriptor-2-botones-mas
gitea/salix/pipeline/head There was a failure building this commit Details
dc936fe690
Merge branch 'dev' into 5182-print_publish
gitea/salix/pipeline/head This commit looks good Details
da5886243e
refs #5120 refactor: no utilizar receipt directamente
gitea/salix/pipeline/head This commit looks good Details
286bc541b6
refs #5120 delete console.log
gitea/salix/pipeline/head This commit looks good Details
a947666838
refactor(imageQueue): remplaced sharp with gm
gitea/salix/pipeline/head This commit looks good Details
defa1b660c
test
gitea/salix/pipeline/head This commit looks good Details
0f0bec8769
Merge pull request 'refs #5151 botones' (!1383) from 5151-claim.descriptor-2-botones-mas into dev
Reviewed-on: #1383
Reviewed-by: Vicent Llopis <vicent@verdnatura.es>
gitea/salix/pipeline/head There was a failure building this commit Details
0d5272de30
Merge branch 'dev' into 5182-print_publish
gitea/salix/pipeline/head Something is wrong with the build of this commit Details
596a017cfd
Don't throw error on file unlink
gitea/salix/pipeline/head Something is wrong with the build of this commit Details
4f0ad00a6f
Merge branch 'test' of https://gitea.verdnatura.es/verdnatura/salix into dev
gitea/salix/pipeline/head This commit looks good Details
1f52326091
Merge pull request 'feat(print): added reusable pdf print functions' (!1390) from 5182-print_publish into dev
Reviewed-on: #1390
Reviewed-by: Alexandre Riera <alexandre@verdnatura.es>
Reviewed-by: Vicent Llopis <vicent@verdnatura.es>
gitea/salix/pipeline/head Build queued... Details
d9296c139d
Merge pull request 'fix: autocompletar el switf/bic' (!1388) from 5352-worker.create_swift/bic into dev
Reviewed-on: #1388
Reviewed-by: Javi Gallego <jgallego@verdnatura.es>
Reviewed-by: Joan Sanchez <joan@verdnatura.es>
gitea/salix/pipeline/head There was a failure building this commit Details
a8049c5b2c
Merge pull request '5380-m3/itemMaxSize' (!1377) from 5380-m3/itemMaxSize into dev
Reviewed-on: #1377
Reviewed-by: Javi Gallego <jgallego@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
d373d80b12
Merge pull request '5120-reports_loopback' (!1389) from 5120-reports_loopback into dev
Reviewed-on: #1389
Reviewed-by: Joan Sanchez <joan@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
ab5a592434
refs #4856 add changelog
gitea/salix/pipeline/head This commit looks good Details
8fda595c2e
Merge pull request '4856-worker.time-control' (!1375) from 4856-worker.time-control into dev
Reviewed-on: #1375
Reviewed-by: Joan Sanchez <joan@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
387576d63a
Merge branch 'dev' into 5036-regularizar-historicos
alexandre scheduled this pull request to auto merge when all checks succeed 2023-03-16 07:26:22 +00:00
alexandre merged commit cd8695741c into dev 2023-03-16 07:26:33 +00:00
alexandre deleted branch 5036-regularizar-historicos 2023-03-16 07:26:50 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1244
No description provided.