verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

4975-mdbVersion-last-method #1245

Merged
guillermo merged 12 commits from 4975-mdbVersion-last-method into dev 2023-01-16 11:40:23 +00:00
Conversation 1 Commits 12 Files Changed 6 +125 -16
guillermo commented 2023-01-09 17:40:28 +00:00
Member
Copy Link
No description provided.
guillermo added 6 commits 2023-01-09 17:40:30 +00:00
gitea/salix/pipeline/head This commit looks good Details
a46c2ced7c refs #4975: Added last mdbVersion/last method
gitea/salix/pipeline/head This commit looks good Details
dc82e610b7 refs #4975 Minor changes
gitea/salix/pipeline/head This commit looks good Details
d97a2738a4 refs #4975 Upload method modified and addedd model
gitea/salix/pipeline/head This commit looks good Details
5a25b0ef4c refs #4975 Added model MdbVersionTree
gitea/salix/pipeline/head There was a failure building this commit Details
2803de9445 refs #4975 Return JSON {version:xxx}
gitea/salix/pipeline/head There was a failure building this commit Details
f23eb9f4ad refs #4975 Added call to last method in upload
guillermo requested review from joan 2023-01-09 17:41:02 +00:00
guillermo added 1 commit 2023-01-09 17:46:29 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
e0e34595f4 refs #4975 Added translations
joan requested changes 2023-01-10 07:24:55 +00:00
modules/mdb/back/methods/mdbVersion/last.js
@ -0,0 +1,46 @@
const UserError = require('vn-loopback/util/user-error');
module.exports = Self => {
Self.remoteMethodCtx('last', {
joan commented 2023-01-10 07:21:08 +00:00
Contributor
Copy Link

Si este método devuelve la última versión, quizás sería mejor nombrarlo last-version?

Si este método devuelve la última versión, quizás sería mejor nombrarlo last-version?
guillermo commented 2023-01-11 14:30:36 +00:00
Author
Member
Copy Link

Como está dentro de mdbVersion, ¿ya se intuye que obtienes la última version no?

Sabiendo esto, ¿hago el cambio de nombre de last → last-version?

Como está dentro de **mdbVersion**, ¿ya se intuye que obtienes la última version no? Sabiendo esto, ¿hago el cambio de nombre de **last → last-version**?
joan commented 2023-01-12 07:28:35 +00:00
Contributor
Copy Link

Ahora que lo comentas, si tiene sentido.

Ahora que lo comentas, si tiene sentido.
modules/mdb/back/methods/mdbVersion/last.js Outdated
@ -0,0 +2,4 @@
module.exports = Self => {
Self.remoteMethodCtx('last', {
description: 'Upload and attach a access file',
joan commented 2023-01-10 07:19:13 +00:00
Contributor
Copy Link

Cambiar la descripción

Cambiar la descripción
modules/mdb/back/methods/mdbVersion/upload.js Outdated
@ -36,3 +39,3 @@
});
Self.upload = async(ctx, appName, newVersion, branch, options) => {
Self.upload = async(ctx, appName, toVersion, branch, fromVersion, options) => {
joan commented 2023-01-10 07:22:45 +00:00
Contributor
Copy Link

Si se le pasan muchos argumentos como parámetro, también se pueden obtener desde ctx

const args = ctx.args

console.log(args.toVersion)

Si se le pasan muchos argumentos como parámetro, también se pueden obtener desde ctx const args = ctx.args console.log(args.toVersion)
guillermo commented 2023-01-11 14:38:17 +00:00
Author
Member
Copy Link

¿Entonces que argumentos le dejaría? ¿Te refieres a que lo deje así?

Self.upload = async(ctx, appName, options) => {
const toVersion = ctx.toVersion;
const branch = ctx.branch;
const fromVersion = ctx.fromVersion;
...
}
¿Entonces que argumentos le dejaría? ¿Te refieres a que lo deje así? ``` Self.upload = async(ctx, appName, options) => { const toVersion = ctx.toVersion; const branch = ctx.branch; const fromVersion = ctx.fromVersion; ... } ```
joan commented 2023-01-13 11:40:47 +00:00
Contributor
Copy Link

Si, normalmente dejamos el identificador o propiedad principal con el que trabaja ese endpoint.

Si, normalmente dejamos el identificador o propiedad principal con el que trabaja ese endpoint.
guillermo added 1 commit 2023-01-11 14:39:43 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
d448f41ac1 refs #4975 Changed description of last method
joan approved these changes 2023-01-12 07:28:41 +00:00
guillermo added 1 commit 2023-01-12 14:25:57 +00:00
guillermo requested review from joan 2023-01-12 14:26:33 +00:00
guillermo commented 2023-01-12 14:27:33 +00:00
Author
Member
Copy Link

He resuelto conflictos con cambios que habia realizado Vicent en el método mdbVersionupdate

He resuelto conflictos con cambios que habia realizado Vicent en el método mdbVersionupdate
guillermo added 1 commit 2023-01-16 06:04:34 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
7186b76063 Merge branch 'dev' into 4975-mdbVersion-last-method
joan approved these changes 2023-01-16 11:09:47 +00:00
guillermo added 2 commits 2023-01-16 11:26:25 +00:00
joan approved these changes 2023-01-16 11:26:55 +00:00
guillermo merged commit 5d81cfc121 into dev 2023-01-16 11:40:23 +00:00
guillermo deleted branch 4975-mdbVersion-last-method 2023-01-16 11:40:23 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
joan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1245
No description provided.
Delete Branch "4975-mdbVersion-last-method"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?