verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

fixes #4945 Dejar de buscar por tag 'Nombre temporal' #1258

Merged
alexandre merged 9 commits from 4945-dejar-buscar-tag-nombreTemporal into dev 2023-01-23 06:04:41 +00:00
Conversation 0 Commits 9 Files Changed 9 +92 -16
alexandre commented 2023-01-17 09:03:33 +00:00
Contributor
Copy Link
No description provided.
alexandre added the
CR / Tests passed
 label 2023-01-17 09:03:33 +00:00
alexandre added 1 commit 2023-01-17 09:03:34 +00:00
gitea/salix/pipeline/head This commit looks good Details
4e1c43eb4d refs #4945 nombre temporal removed
alexandre requested review from jgallego 2023-01-17 09:03:47 +00:00
alexandre added 1 commit 2023-01-17 09:10:50 +00:00
jgallego requested changes 2023-01-18 08:08:17 +00:00
modules/item/back/methods/item/new.js Outdated
@ -46,10 +48,14 @@ module.exports = Self => {
}
try {
const validPriorities = new Set([1, 2, 3]);
jgallego commented 2023-01-18 08:08:10 +00:00
Owner
Copy Link

açò? pregunta a Juan pero jo no ho veig, crec que deuria estar en taula config

açò? pregunta a Juan pero jo no ho veig, crec que deuria estar en taula config
modules/item/front/create/index.js Outdated
@ -7,2 +7,3 @@
this.item = {
relevancy: 0
relevancy: 0,
priority: 2,
jgallego commented 2023-01-18 08:07:47 +00:00
Owner
Copy Link

Has de vore la forma de llevar el 2 del codi

Has de vore la forma de llevar el 2 del codi
alexandre added 1 commit 2023-01-18 12:15:02 +00:00
alexandre added 1 commit 2023-01-18 12:15:29 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
200a256016 Merge branch 'dev' into 4945-dejar-buscar-tag-nombreTemporal
alexandre requested review from jgallego 2023-01-18 12:16:59 +00:00
alexandre added 2 commits 2023-01-18 13:51:14 +00:00
jgallego requested changes 2023-01-20 06:20:05 +00:00
db/dump/fixtures.sql
@ -2721,1 +2721,4 @@
INSERT INTO `vn`.`itemConfig` (`id`, `isItemTagTriggerDisabled`, `monthToDeactivate`, `wasteRecipients`, `validPriorities`, `defaultPriority`, `defaultTag`)
VALUES
(0, 0, 24, '', '[1,2,3]', 2, 56);
jgallego commented 2023-01-20 06:20:00 +00:00
Owner
Copy Link

A comentar en Juan en la revisio semanal de hui

A comentar en Juan en la revisio semanal de hui
modules/item/back/methods/item/new.js Outdated
@ -37,7 +37,8 @@ module.exports = Self => {
'typeFk',
'intrastatFk',
'originFk',
'relevancy'
jgallego commented 2023-01-20 06:17:08 +00:00
Owner
Copy Link

perque s'ha lleva't la relevancia?

perque s'ha lleva't la relevancia?
alexandre added 1 commit 2023-01-20 07:01:34 +00:00
gitea/salix/pipeline/head This commit looks good Details
a3b580e27d refs #4945 item.relevancy comment
alexandre added 1 commit 2023-01-20 09:12:14 +00:00
alexandre added 1 commit 2023-01-20 11:01:28 +00:00
gitea/salix/pipeline/head This commit looks good Details
a473d3a6f9 refs #4945 changed input-number for autocomplete
alexandre requested review from jgallego 2023-01-20 11:11:23 +00:00
jgallego approved these changes 2023-01-20 17:51:24 +00:00
alexandre merged commit be86e7cac1 into dev 2023-01-23 06:04:41 +00:00
alexandre deleted branch 4945-dejar-buscar-tag-nombreTemporal 2023-01-23 06:04:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1258
No description provided.
Delete Branch "4945-dejar-buscar-tag-nombreTemporal"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?