verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 67 Releases Wiki Activity

fixes #5070 route-tickets city is now a link to buscaman #1282

Merged
joan merged 5 commits from 5070-route-tickets-link-maps into dev 2023-03-02 06:33:05 +00:00
Conversation 0 Commits 5 Files Changed 6 +65 -17
pau commented 2023-01-30 11:38:51 +00:00
Contributor
Copy Link

En caso de que se quiera cambiar el enlace a google maps

'https://www.google.com/maps/search/?api=1&query=' + encodeURI(addresses)

De momento esta puesto que enlace al buscaman, comentame tu que opción deberia de estar puesta javi

En caso de que se quiera cambiar el enlace a google maps ``` 'https://www.google.com/maps/search/?api=1&query=' + encodeURI(addresses) ``` De momento esta puesto que enlace al buscaman, comentame tu que opción deberia de estar puesta javi
pau added the
CR / Tests passed
 label 2023-01-30 11:38:51 +00:00
pau added 1 commit 2023-01-30 11:38:52 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
6709012e59 refs #5070 @2h refactor goToBuscaman method
pau added 1 commit 2023-01-30 11:39:23 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
977987699d Merge branch 'dev' into 5070-route-tickets-link-maps
pau requested review from jgallego 2023-01-30 12:50:41 +00:00
pau added 1 commit 2023-01-30 12:51:41 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
2218197188 Merge branch 'dev' into 5070-route-tickets-link-maps
jgallego requested review from juan 2023-01-30 13:59:00 +00:00
jgallego refused to review 2023-01-30 13:59:04 +00:00
pau changed title from closes #5070 route-tickets city is now a link to buscaman to fixes #5070 route-tickets city is now a link to buscaman 2023-02-01 08:19:12 +00:00
joan requested changes 2023-02-02 07:43:34 +00:00
modules/route/front/tickets/index.html Outdated
@ -92,3 +92,3 @@
</vn-td>
<vn-td expand title="{{::ticket.street}}">{{::ticket.street}}</vn-td>
<vn-td expand>{{::ticket.city}}</vn-td>
<vn-td
joan commented 2023-02-02 07:43:19 +00:00
Contributor
Copy Link

Siempre es mejor añadir una etiqueta que envuelva al texto (Por ejemplo un span) en vez de poner el evento click sobre la celda.

Si se pone el evento click en la celda se lanzará el evento aunque no hagas click sobre el enlace. El enlace debería ser el texto

Siempre es mejor añadir una etiqueta que envuelva al texto (Por ejemplo un span) en vez de poner el evento click sobre la celda. Si se pone el evento click en la celda se lanzará el evento aunque no hagas click sobre el enlace. El enlace debería ser el texto
juan approved these changes 2023-02-21 07:35:13 +00:00
alexandre added 1 commit 2023-03-01 10:20:39 +00:00
alexandre added 1 commit 2023-03-01 13:22:36 +00:00
gitea/salix/pipeline/head This commit looks good Details
d62fbab3f1 refs #5070 refactor and added tests
joan approved these changes 2023-03-02 06:32:59 +00:00
joan merged commit 8834d4d0a4 into dev 2023-03-02 06:33:05 +00:00
joan deleted branch 5070-route-tickets-link-maps 2023-03-02 06:33:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
juan
joan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1282
No description provided.
Delete Branch "5070-route-tickets-link-maps"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?