verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 65 Releases Wiki Activity

hotFix #5223 Mostrar cliente compensado al enviar email #1327

Merged
alexandre merged 4 commits from 5223-cliente-compensado into master 2023-02-16 13:40:35 +00:00
Conversation 1 Commits 4 Files Changed 10 +115 -44
alexandre commented 2023-02-14 11:48:32 +00:00
Contributor
Copy Link
No description provided.
alexandre added 2 commits 2023-02-14 11:48:32 +00:00
gitea/salix/pipeline/head This commit looks good Details
ea2fd59cdc refs #5223 changed ref and email text
alexandre added the
CR / Tests passed
 label 2023-02-14 11:48:40 +00:00
alexandre requested review from joan 2023-02-14 11:58:15 +00:00
joan commented 2023-02-15 07:45:53 +00:00
Contributor
Copy Link

Es necesari que aso se fasa merge en master? La cantitat de fitxers modificats no pareixen un hotfix.

Es necesari que aso se fasa merge en master? La cantitat de fitxers modificats no pareixen un hotfix.
joan requested changes 2023-02-15 10:40:05 +00:00
db/changes/230402/00-clienteCompensado.sql Outdated
@ -0,0 +1,3 @@
INSERT INTO `salix`.`ACL` (`model`, `property`, `accessType`, `permission`, `principalType`, `principalId`)
joan commented 2023-02-15 10:36:55 +00:00
Contributor
Copy Link

Este cambio no se aplicará, la versión 230402 ya está en producción. Debería ser 230403

Este cambio no se aplicará, la versión 230402 ya está en producción. Debería ser 230403
alexandre marked this conversation as resolved
modules/client/back/methods/client/getClientOrSupplierReference.js
@ -0,0 +16,4 @@
root: true
},
http: {
path: `/:bankAccount/getClientOrSupplierReference`,
joan commented 2023-02-15 10:39:19 +00:00
Contributor
Copy Link

El parámetro en :bankAccount deuría de ser el id de client, si sols fa falta el bankAccount no deuría de anar com a parámetro URL

El parámetro en :bankAccount deuría de ser el id de client, si sols fa falta el bankAccount no deuría de anar com a parámetro URL
alexandre marked this conversation as resolved
alexandre added 1 commit 2023-02-15 11:59:31 +00:00
gitea/salix/pipeline/head This commit looks good Details
e68afa3169 refs #5223 moved sql
alexandre added 1 commit 2023-02-15 12:15:05 +00:00
gitea/salix/pipeline/head This commit looks good Details
dca5ae0f72 refs #5223 added params
alexandre requested review from joan 2023-02-15 12:15:43 +00:00
joan approved these changes 2023-02-16 13:31:42 +00:00
alexandre merged commit ef12a428cd into master 2023-02-16 13:40:35 +00:00
alexandre deleted branch 5223-cliente-compensado 2023-02-16 13:40:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
joan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1327
No description provided.
Delete Branch "5223-cliente-compensado"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?