verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

fixes #5206 travel buscador en el lateral #1384

Merged
joan merged 11 commits from 5206-travel-buscadorLateral into dev 2023-03-30 05:21:26 +00:00
Conversation 0 Commits 11 Files Changed 22 +390 -335
alexandre commented 2023-03-10 09:06:36 +00:00
Contributor
Copy Link
No description provided.
alexandre added the
Missing tests
 label 2023-03-10 09:06:36 +00:00
alexandre added 4 commits 2023-03-10 09:06:36 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
be1993cf8b refs #5206 version with top-searcher and two fields for reference and id
gitea/salix/pipeline/head There was a failure building this commit Details
dbe42e3bf4 refs #5206 version with plane added, needs to implement general search
gitea/salix/pipeline/head There was a failure building this commit Details
ed5208c9e4 refs #5206 implemented general search, missing tests
gitea/salix/pipeline/head There was a failure building this commit Details
874fd0656c refs #5206 url gets params
alexandre added 1 commit 2023-03-23 09:53:28 +00:00
alexandre added 1 commit 2023-03-23 13:31:13 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
6738243534 refs #5206 added e2e
alexandre added 1 commit 2023-03-23 13:58:45 +00:00
alexandre added 1 commit 2023-03-24 07:13:05 +00:00
alexandre added 1 commit 2023-03-24 07:25:50 +00:00
gitea/salix/pipeline/head This commit looks good Details
0baccc4745 refs #5206 fix tests front
alexandre added 1 commit 2023-03-24 08:22:08 +00:00
gitea/salix/pipeline/head This commit looks good Details
cfe4570d3b refs #5206 e2es fixed
alexandre changed title from WIP: #5206 travel buscador en el lateral to fixes #5206 travel buscador en el lateral 2023-03-24 08:22:20 +00:00
alexandre requested review from joan 2023-03-24 08:22:27 +00:00
alexandre removed the
Missing tests
 label 2023-03-27 05:44:50 +00:00
alexandre added 1 commit 2023-03-27 06:38:57 +00:00
joan requested review from jgallego 2023-03-28 05:35:05 +00:00
joan requested changes 2023-03-28 05:41:01 +00:00
e2e/paths/10-travel/03_descriptor.spec.js
@ -10,3 +10,3 @@
page = browser.page;
await page.loginAndModule('buyer', 'travel');
await page.accessToSearchResult('1');
await page.write(selectors.travelIndex.generalSearchFilter, '1');
joan commented 2023-03-28 05:27:49 +00:00
Contributor
Copy Link

També desapareix la barra de búsqueda general, aso es lo que es vol fer? No es pot buscar desde dins de la entitat

També desapareix la barra de búsqueda general, aso es lo que es vol fer? No es pot buscar desde dins de la entitat
alexandre commented 2023-03-28 05:57:55 +00:00
Author
Contributor
Copy Link

Me varen dir que ho posara tot el en el buscador de la dreta, encara aixina també vaig implementar per a que si al filtrar te troba un únic resultat que te redirigixca a ell

Me varen dir que ho posara tot el en el buscador de la dreta, encara aixina també vaig implementar per a que si al filtrar te troba un únic resultat que te redirigixca a ell
modules/travel/front/search-panel/index.html
@ -110,0 +78,4 @@
ng-keydown="$ctrl.onKeyPress($event, 'totalEntries')">
</vn-input-number>
</vn-horizontal>
<div class="chips">
joan commented 2023-03-28 05:40:26 +00:00
Contributor
Copy Link

Els tags ho podríes automatitzar obtinguent les claus dels params aplicats al objecte filter

Exemple:

Object.keys($ctrl.filter).map(tag => ({
	label: tag,
    value: $ctrl.filter[tag]
}))

En Lilium ho fa aixi
https://gitea.verdnatura.es/verdnatura/salix-front/src/branch/dev/src/components/ui/VnFilterPanel.vue#L70

Els tags ho podríes automatitzar obtinguent les claus dels params aplicats al objecte filter Exemple: ``` Object.keys($ctrl.filter).map(tag => ({ label: tag, value: $ctrl.filter[tag] })) ``` En Lilium ho fa aixi https://gitea.verdnatura.es/verdnatura/salix-front/src/branch/dev/src/components/ui/VnFilterPanel.vue#L70
alexandre commented 2023-03-28 06:05:30 +00:00
Author
Contributor
Copy Link

Es que si ho feia d'ixa forma hi havia valors que no podia mostrar en els chips com els noms dels warehouses o els continents perque ho havia d'agafar del selection en el autocomplete, no del filter

Es que si ho feia d'ixa forma hi havia valors que no podia mostrar en els chips com els noms dels warehouses o els continents perque ho havia d'agafar del selection en el autocomplete, no del filter
jgallego approved these changes 2023-03-29 05:34:32 +00:00
joan approved these changes 2023-03-30 05:21:17 +00:00
joan merged commit cafb21d90b into dev 2023-03-30 05:21:26 +00:00
joan deleted branch 5206-travel-buscadorLateral 2023-03-30 05:21:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
joan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1384
No description provided.
Delete Branch "5206-travel-buscadorLateral"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?