verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 59 Releases Wiki Activity

5013-observaciones_facturas #1401

Merged
vicent merged 8 commits from 5013-observaciones_facturas into dev 2023-03-24 09:56:59 +00:00
Conversation 0 Commits 8 Files Changed 4 +25 -9
vicent commented 2023-03-22 08:11:50 +00:00
Contributor
Copy Link
No description provided.
vicent added the
CR / Tests passed
 label 2023-03-22 08:11:50 +00:00
vicent added 2 commits 2023-03-22 08:11:50 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
1d0024c538 refs #5013 feat: añadida observacion para cada ticket
gitea/salix/pipeline/head There was a failure building this commit Details
9ef5c0c560 refs #5013 mostrar las observaciones del ticket
vicent requested review from carlosap 2023-03-22 08:11:57 +00:00
vicent added 1 commit 2023-03-22 08:25:40 +00:00
carlosap approved these changes 2023-03-22 14:27:14 +00:00
vicent added 1 commit 2023-03-23 06:04:30 +00:00
gitea/salix/pipeline/head This commit looks good Details
d98bd7b92b Merge branch 'dev' into 5013-observaciones_facturas
vicent added 1 commit 2023-03-23 08:29:26 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
2b73fb5a7e Merge branch 'dev' into 5013-observaciones_facturas
vicent added 1 commit 2023-03-24 07:27:33 +00:00
carlosap requested changes 2023-03-24 08:05:07 +00:00
print/templates/reports/invoice/invoice.js
@ -26,2 +27,4 @@
map.set(ticket.id, ticket);
if (ticket.description) this.ticketObservations += ticket.description + ' ';
carlosap commented 2023-03-22 14:28:27 +00:00
Member
Copy Link

pots llevar el espai que es queda en blanc al final?
fent slice(0,-1)

pots llevar el espai que es queda en blanc al final? fent slice(0,-1)
vicent commented 2023-03-24 09:35:51 +00:00
Author
Contributor
Copy Link

el slice no fa lo que toca, he fet this.ticketObservations.trim(); que lo que fa es eliminar els espaic en blanc al final

el slice no fa lo que toca, he fet this.ticketObservations.trim(); que lo que fa es eliminar els espaic en blanc al final
vicent marked this conversation as resolved
vicent added 1 commit 2023-03-24 09:32:24 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
cbe79a964c refs #5013 eliminado espacio en blanco al final de la cadena y añadidas fixtures
vicent requested review from carlosap 2023-03-24 09:35:54 +00:00
carlosap approved these changes 2023-03-24 09:36:41 +00:00
vicent added 1 commit 2023-03-24 09:37:43 +00:00
gitea/salix/pipeline/head This commit looks good Details
91cc91716f Merge branch 'dev' into 5013-observaciones_facturas
vicent merged commit 6433e889c7 into dev 2023-03-24 09:56:59 +00:00
vicent deleted branch 5013-observaciones_facturas 2023-03-24 09:56:59 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosap
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1401
No description provided.
Delete Branch "5013-observaciones_facturas"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?