verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 58 Releases Wiki Activity

5410-client.defaulter_getChecked #1403

Merged
joan merged 13 commits from 5410-client.defaulter_getChecked into dev 2023-04-06 07:04:33 +00:00
Conversation 1 Commits 13 Files Changed 10 +188 -26
vicent commented 2023-03-22 09:15:46 +00:00
Contributor
Copy Link
No description provided.
vicent added the
CR / Tests passed
 label 2023-03-22 09:15:46 +00:00
vicent added 7 commits 2023-03-22 09:15:46 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
bc47fc35d6 refs #5410 feat: añadido filtro a las columnas created y defaulterSinced
gitea/salix/pipeline/head This commit looks good Details
98916bf5e1 refs #5410 add changelog
gitea/salix/pipeline/head There was a failure building this commit Details
41c79263c4 refs #5410 feat: envia email cuando se añade una nota
gitea/salix/pipeline/head This commit looks good Details
1b1bca28bd refs #5410 add frontTest
vicent added 1 commit 2023-03-24 08:44:27 +00:00
vicent requested review from joan 2023-03-24 08:45:19 +00:00
vicent added 1 commit 2023-03-24 09:06:31 +00:00
gitea/salix/pipeline/head This commit looks good Details
f689d35100 refs #5410 fix test
joan requested review from juan 2023-03-28 05:12:28 +00:00
joan commented 2023-03-28 05:13:48 +00:00
Contributor
Copy Link

@juan Creo que no es buena idea dar permisos para employee para insertar directamente en la tabla Mail. Tiene sentido? Creo que podrían suplantar a otras personas.

Crear una ruta de back, para evitar dar permisos.

@juan Creo que no es buena idea dar permisos para employee para insertar directamente en la tabla Mail. Tiene sentido? Creo que podrían suplantar a otras personas. **Crear una ruta de back, para evitar dar permisos.**
joan requested changes 2023-03-28 05:17:39 +00:00
modules/client/front/defaulter/index.js Outdated
@ -117,0 +137,4 @@
text: this.defaulter.observation
});
params.push({
joan commented 2023-03-28 05:16:47 +00:00
Contributor
Copy Link

@jgallego @juan
Esto no debería enviarse a través de las notificaciones de correo (util.notification)?

@jgallego @juan Esto no debería enviarse a través de las notificaciones de correo (util.notification)?
joan marked this conversation as resolved
jgallego approved these changes 2023-03-29 05:27:13 +00:00
vicent added 1 commit 2023-04-04 11:40:42 +00:00
vicent added 1 commit 2023-04-04 12:10:03 +00:00
gitea/salix/pipeline/head This commit looks good Details
3630c7d398 refs #5410 creada ruta de back para enviar emails
vicent requested review from joan 2023-04-04 12:12:14 +00:00
vicent added 1 commit 2023-04-04 12:12:59 +00:00
vicent added 1 commit 2023-04-04 12:27:24 +00:00
gitea/salix/pipeline/head This commit looks good Details
35d19e586a add translatiojn
joan approved these changes 2023-04-06 07:04:26 +00:00
joan merged commit 033927d5b4 into dev 2023-04-06 07:04:33 +00:00
joan deleted branch 5410-client.defaulter_getChecked 2023-04-06 07:04:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
juan
jgallego
joan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1403
No description provided.
Delete Branch "5410-client.defaulter_getChecked"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?