verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

5540-validarSupplierIsVies #1438

Merged
carlossa merged 27 commits from 5540-validarSupplierIsVies into dev 2023-05-02 09:29:10 +00:00
Conversation 0 Commits 27 Files Changed 12 +47 -23
carlossa commented 2023-04-12 12:58:53 +00:00
Member
Copy Link
No description provided.
carlossa added 3 commits 2023-04-12 12:58:54 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
117849f093 refs #5540 supplier js
gitea/salix/pipeline/head This commit looks good Details
60103fa80a refs #5540 validacion nif
gitea/salix/pipeline/head This commit looks good Details
747efc4342 refs #5540 sql mod
carlossa requested review from carlosap 2023-04-12 12:59:53 +00:00
carlossa requested review from joan 2023-04-12 12:59:59 +00:00
carlosap refused to review 2023-04-12 13:49:48 +00:00
carlossa added 1 commit 2023-04-13 06:30:52 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
ad267c933c refs #5540 country.code
joan requested review from jgallego 2023-04-17 06:44:44 +00:00
joan refused to review 2023-04-17 06:44:45 +00:00
jgallego approved these changes 2023-04-17 07:07:04 +00:00
carlossa added 1 commit 2023-04-20 09:56:06 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
d6e6dab03b Merge branch 'dev'
carlossa added the
CR / Tests passed
 label 2023-04-20 12:30:24 +00:00
carlossa added 1 commit 2023-04-20 13:28:00 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
088f2f9181 Merge branch 'dev' into 5540-validarSupplierIsVies
carlossa added 2 commits 2023-04-21 07:14:42 +00:00
carlossa added 1 commit 2023-04-21 08:42:04 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
397d8f658e refs #5540 error trad
carlossa requested review from jgallego 2023-04-21 09:52:09 +00:00
jgallego approved these changes 2023-04-23 15:46:21 +00:00
carlossa added 1 commit 2023-04-24 06:48:49 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
cd4f66e292 refs #5540 arreglar e2e
carlossa added 1 commit 2023-04-24 06:51:45 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
67db2f0476 Merge branch 'dev' into 5540-validarSupplierIsVies
carlossa added 2 commits 2023-04-27 08:40:09 +00:00
carlossa added 1 commit 2023-04-27 09:31:37 +00:00
gitea/salix/pipeline/head Build queued... Details
07148f6c29 refs #5540 mon message
carlossa added 1 commit 2023-04-27 09:40:56 +00:00
carlossa added 1 commit 2023-04-27 10:49:23 +00:00
carlossa requested review from jgallego 2023-04-27 10:51:00 +00:00
carlossa added 1 commit 2023-04-27 11:26:31 +00:00
gitea/salix/pipeline/head This commit looks good Details
e1864fec09 arreglo json
jgallego requested changes 2023-04-28 05:33:21 +00:00
modules/client/back/models/client.js Outdated
@ -23,6 +23,23 @@ module.exports = Self => {
message: 'TIN must be unique'
});
Self.validateAsync('fi', fiInvalid, {
jgallego commented 2023-04-28 05:33:17 +00:00
Owner
Copy Link

codi repetit.

agafa com a exemple validateIban que es similar, tant client i supplier el validen pero no repentim codi.

codi repetit. agafa com a exemple validateIban que es similar, tant client i supplier el validen pero no repentim codi.
carlossa added 1 commit 2023-04-28 07:07:17 +00:00
gitea/salix/pipeline/head This commit looks good Details
b8f7f7bd69 refs #5540 create validateIban
carlossa added 1 commit 2023-04-28 08:22:05 +00:00
gitea/salix/pipeline/head Build queued... Details
cdbbec9d36 refs #5540 validate
carlossa added 1 commit 2023-04-28 10:12:35 +00:00
carlossa added 1 commit 2023-04-28 12:03:32 +00:00
carlossa added 1 commit 2023-04-28 12:23:54 +00:00
carlossa added 1 commit 2023-04-28 12:38:56 +00:00
carlossa requested review from jgallego 2023-04-28 13:02:07 +00:00
carlossa added 1 commit 2023-04-28 13:02:15 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
06c01f3e94 Merge branch 'dev' into 5540-validarSupplierIsVies
carlossa added 1 commit 2023-05-02 06:07:22 +00:00
gitea/salix/pipeline/head This commit looks good Details
d9aae670f7 Merge branch 'dev' into 5540-validarSupplierIsVies
jgallego requested changes 2023-05-02 07:41:31 +00:00
modules/client/back/models/client.js Outdated
@ -4,6 +4,7 @@ const isMultiple = require('vn-loopback/util/hook').isMultiple;
const validateTin = require('vn-loopback/util/validateTin');
const validateIban = require('vn-loopback/util/validateIban');
const LoopBackContext = require('loopback-context');
const { ConsoleReporter } = require('jasmine');
jgallego commented 2023-05-02 07:41:23 +00:00
Owner
Copy Link

revisar en @alexm

revisar en @alexm
alexm commented 2023-05-02 08:03:01 +00:00
Member
Copy Link

Lo hemos revisado y no hemos encontrado el motivo, puede que haya sido al escribir mal alguna palabra haya hecho la importación automáticamente.

Lo dejará anotado en su redmine por si se nos ocurriera el motivo

Lo hemos revisado y no hemos encontrado el motivo, puede que haya sido al escribir mal alguna palabra haya hecho la importación automáticamente. Lo dejará anotado en su redmine por si se nos ocurriera el motivo
jgallego requested review from alexm 2023-05-02 07:41:42 +00:00
carlossa added 2 commits 2023-05-02 08:01:02 +00:00
carlossa requested review from jgallego 2023-05-02 08:03:47 +00:00
alexm approved these changes 2023-05-02 08:04:07 +00:00
jgallego approved these changes 2023-05-02 08:59:20 +00:00
carlossa merged commit 754c5488bf into dev 2023-05-02 09:29:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1438
No description provided.
Delete Branch "5540-validarSupplierIsVies"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?