verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

fix e2e #1450

Merged
alexm merged 4 commits from fix_e2e into dev 2023-04-17 12:20:07 +00:00
Conversation 0 Commits 4 Files Changed 5 +7 -3
alexm commented 2023-04-17 10:47:05 +00:00
Member
Copy Link
No description provided.
alexm added the
CR / Tests passed
 label 2023-04-17 10:47:05 +00:00
alexm added 2 commits 2023-04-17 10:47:08 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
f97d169cbf observationEmail
gitea/salix/pipeline/head This commit looks good Details
6144c24a44 fix(ticket_edit): fix e2e
alexm requested review from vicent 2023-04-17 10:47:57 +00:00
alexm requested review from alexandre 2023-04-17 10:47:57 +00:00
alexandre requested changes 2023-04-17 10:53:29 +00:00
db/changes/231601/00-observationEmailACL.sql Outdated
@ -0,0 +1,2 @@
INSERT INTO `salix`.`ACL` (`model`, `property`, `accessType`, `permission`, `principalType`, `principalId`)
VALUES ('Defaulter', 'observationEmail', 'WRITE', 'ALLOW', 'ROLE', 'employee');
alexandre commented 2023-04-17 10:50:56 +00:00
Contributor
Copy Link

Jo ho posaria tabulat com en les fixtures

Jo ho posaria tabulat com en les fixtures
alexm marked this conversation as resolved
e2e/helpers/selectors.js Outdated
@ -990,3 +990,3 @@
},
workerNotes: {
addNoteFloatButton: 'vn-float-button',
addNoteFloatButton: 'a vn-float-button',
alexandre commented 2023-04-17 10:53:00 +00:00
Contributor
Copy Link

No sé si se vol que tinga primer el nom del component (com posa en firstNoteText)

No sé si se vol que tinga primer el nom del component (com posa en firstNoteText)
alexm marked this conversation as resolved
alexm added 1 commit 2023-04-17 10:59:10 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
b5434c5e4e tab
alexandre approved these changes 2023-04-17 11:00:54 +00:00
alexm added 1 commit 2023-04-17 11:03:48 +00:00
gitea/salix/pipeline/head This commit looks good Details
6a0a08be95 typo
alexandre approved these changes 2023-04-17 11:05:53 +00:00
vicent approved these changes 2023-04-17 12:18:00 +00:00
alexm merged commit 2a8383f9cc into dev 2023-04-17 12:20:07 +00:00
alexm deleted branch fix_e2e 2023-04-17 12:20:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexandre
vicent
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1450
No description provided.
Delete Branch "fix_e2e"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?