#4797 Seccion Worker/Notification #1494

Merged
alexm merged 26 commits from 4797-worker-notification-selector into dev 2023-11-10 09:47:42 +00:00
Contributor
No description provided.
alexandre added 1 commit 2023-05-02 06:08:12 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
c2de5c5ff4
refs #4797 added redirection section
alexandre added 1 commit 2023-05-02 07:51:17 +00:00
gitea/salix/pipeline/head This commit looks good Details
70c46efe27
refs #4797 fix back test
alexandre added 1 commit 2023-05-02 09:38:17 +00:00
alexandre changed title from WIP: #4797 Seccion Worker/Notification to fixes #4797 Seccion Worker/Notification 2023-05-02 12:04:38 +00:00
alexandre requested review from alexm 2023-05-02 12:05:00 +00:00
alexandre added 1 commit 2023-05-02 12:26:58 +00:00
gitea/salix/pipeline/head This commit looks good Details
4c0ec6faf5
changedModel sms
alexandre added 1 commit 2023-05-02 12:30:58 +00:00
alexm added 1 commit 2023-05-03 05:09:40 +00:00
alexandre added 1 commit 2023-05-09 06:14:54 +00:00
alexandre added 1 commit 2023-05-09 09:34:43 +00:00
gitea/salix/pipeline/head This commit looks good Details
e7d16dc8ba
refs #4797 fix test, add getList
alexandre added 1 commit 2023-05-09 12:20:30 +00:00
gitea/salix/pipeline/head This commit looks good Details
5171e63188
refs #4797 minor fixes
alexm requested changes 2023-05-09 13:06:14 +00:00
@ -0,0 +44,4 @@
where: {
roleFk: {
inq: roles.map(role => {
return role.roleId;
Member

La siguiente forma es más breve
roles.map(role => role.roleId);

La siguiente forma es más breve `roles.map(role => role.roleId);`
alexandre marked this conversation as resolved
@ -0,0 +50,4 @@
}
}, myOptions);
for (subscription of activeNotifications) {
Member

Refactorizar
Pasar availableNotifications a Set (clave valor). El name como clave.
Luego recorrer activeNotifications y que machaque availableNotifications.

Pensar en los "errores" que pudiera haber si esta en activeNotifications y no en availableNotifications

Refactorizar Pasar availableNotifications a Set (clave valor). El name como clave. Luego recorrer activeNotifications y que machaque availableNotifications. Pensar en los "errores" que pudiera haber si esta en activeNotifications y no en availableNotifications
alexandre marked this conversation as resolved
@ -20,3 +15,3 @@
}
await models.NotificationSubscription.deleteNotification(ctx, notification.id, options);
expect(error.message).toContain('You dont have permission to modify this user');
Member

Falta traducción. creo que falta de antes

Falta traducción. creo que falta de antes
alexandre marked this conversation as resolved
alexm requested changes 2023-05-10 06:38:23 +00:00
@ -60,0 +30,4 @@
const worker = await models.Worker.findById(workerId, {fields: ['id', 'bossFk']});
const notificationsAvailables = await models.NotificationSubscription.getList(workerId);
const hasAcl = notificationsAvailables.some(function(available) {
Member

Crec que se pot substituir per:

(available) => available.notificationFk === notificationFk;
Crec que se pot substituir per: ``` (available) => available.notificationFk === notificationFk; ```
alexandre marked this conversation as resolved
alexandre added 1 commit 2023-05-10 12:10:10 +00:00
gitea/salix/pipeline/head This commit looks good Details
f9e7963e74
refs #4797 minor fixes
alexandre added 1 commit 2023-05-10 12:13:48 +00:00
alexandre added 1 commit 2023-05-11 05:19:09 +00:00
gitea/salix/pipeline/head This commit looks good Details
33ef9bdf61
refs #4797 refactor
alexandre requested review from alexm 2023-05-15 09:36:37 +00:00
alexm added 1 commit 2023-05-15 09:41:14 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
931514a8e8
Merge branch 'dev' into 4797-worker-notification-selector
alexandre scheduled this pull request to auto merge when all checks succeed 2023-05-15 09:42:27 +00:00
alexm reviewed 2023-05-15 12:05:31 +00:00
@ -0,0 +35,4 @@
}, myOptions);
const availableNotifications = await models.NotificationAcl.find({
include: {relation: 'notification'},
Member

Igual faltaria possar fields: [...]

Igual faltaria possar fields: [...]
alexandre marked this conversation as resolved
alexm reviewed 2023-05-15 12:05:38 +00:00
@ -0,0 +44,4 @@
}, myOptions);
const activeNotifications = await models.NotificationSubscription.find({
include: {relation: 'notification'},
Member

Igual faltaria possar fields: [...]

Igual faltaria possar fields: [...]
alexandre marked this conversation as resolved
alexm approved these changes 2023-05-15 12:05:41 +00:00
Dismissed
alexm requested review from jgallego 2023-05-15 12:05:51 +00:00
alexandre added 2 commits 2023-05-15 12:28:08 +00:00
alexandre added 1 commit 2023-05-15 12:34:41 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
2c254cbc08
refs #4797 added fields
alexandre added 1 commit 2023-05-16 07:22:16 +00:00
alexandre requested review from alexm 2023-05-16 07:34:49 +00:00
alexm approved these changes 2023-05-16 09:13:35 +00:00
Dismissed
jgallego approved these changes 2023-05-16 14:46:08 +00:00
Dismissed
Owner

Antes de pujar-ho mirem el funcionament a nivell d'interfaç gràfica.

Antes de pujar-ho mirem el funcionament a nivell d'interfaç gràfica.
alexandre added 1 commit 2023-05-18 12:52:45 +00:00
alexandre added 1 commit 2023-05-18 12:53:18 +00:00
gitea/salix/pipeline/head This commit looks good Details
8db7a5b16a
refs #4797 moved sql
alexm added 1 commit 2023-05-23 05:55:12 +00:00
alexandre changed title from fixes #4797 Seccion Worker/Notification to WIP: #4797 Seccion Worker/Notification 2023-05-30 09:50:01 +00:00
alexm added 1 commit 2023-11-03 13:58:55 +00:00
alexm dismissed alexm’s review 2023-11-03 13:58:55 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexm dismissed alexm’s review 2023-11-03 13:58:55 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexm dismissed jgallego’s review 2023-11-03 13:58:55 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexm added 1 commit 2023-11-03 14:16:02 +00:00
gitea/salix/pipeline/head This commit looks good Details
8c5e40c27f
refs #4797 fix: correct sql folder
alexm added 2 commits 2023-11-08 13:57:07 +00:00
alexm added 2 commits 2023-11-09 08:34:34 +00:00
alexm changed title from WIP: #4797 Seccion Worker/Notification to #4797 Seccion Worker/Notification 2023-11-09 10:01:59 +00:00
alexm approved these changes 2023-11-09 10:02:08 +00:00
alexm reviewed 2023-11-09 10:03:14 +00:00
@ -11,3 +11,3 @@
"[javascript]": {
"editor.defaultFormatter": "dbaeumer.vscode-eslint"
}
},
Member

Aço es si gastes la extencio "Code Spell Checker", te revisa si esta ben escrites les coses en angles.
Aixina fas q no te marque salix com a una paraula mal.

Puc llevar-ho

Aço es si gastes la extencio "Code Spell Checker", te revisa si esta ben escrites les coses en angles. Aixina fas q no te marque salix com a una paraula mal. Puc llevar-ho
jgallego approved these changes 2023-11-10 06:56:44 +00:00
alexm merged commit ad07c4ec97 into dev 2023-11-10 09:47:42 +00:00
alexm deleted branch 4797-worker-notification-selector 2023-11-10 09:47:43 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1494
No description provided.