#4797 Seccion Worker/Notification #1494
Labels
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: verdnatura/salix#1494
Loading…
Reference in New Issue
No description provided.
Delete Branch "4797-worker-notification-selector"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
WIP: #4797 Seccion Worker/Notificationto fixes #4797 Seccion Worker/Notification@ -0,0 +44,4 @@
where: {
roleFk: {
inq: roles.map(role => {
return role.roleId;
La siguiente forma es más breve
roles.map(role => role.roleId);
@ -0,0 +50,4 @@
}
}, myOptions);
for (subscription of activeNotifications) {
Refactorizar
Pasar availableNotifications a Set (clave valor). El name como clave.
Luego recorrer activeNotifications y que machaque availableNotifications.
Pensar en los "errores" que pudiera haber si esta en activeNotifications y no en availableNotifications
@ -20,3 +15,3 @@
}
await models.NotificationSubscription.deleteNotification(ctx, notification.id, options);
expect(error.message).toContain('You dont have permission to modify this user');
Falta traducción. creo que falta de antes
@ -60,0 +30,4 @@
const worker = await models.Worker.findById(workerId, {fields: ['id', 'bossFk']});
const notificationsAvailables = await models.NotificationSubscription.getList(workerId);
const hasAcl = notificationsAvailables.some(function(available) {
Crec que se pot substituir per:
@ -0,0 +35,4 @@
}, myOptions);
const availableNotifications = await models.NotificationAcl.find({
include: {relation: 'notification'},
Igual faltaria possar fields: [...]
@ -0,0 +44,4 @@
}, myOptions);
const activeNotifications = await models.NotificationSubscription.find({
include: {relation: 'notification'},
Igual faltaria possar fields: [...]
Antes de pujar-ho mirem el funcionament a nivell d'interfaç gràfica.
fixes #4797 Seccion Worker/Notificationto WIP: #4797 Seccion Worker/NotificationNew commits pushed, approval review dismissed automatically according to repository settings
New commits pushed, approval review dismissed automatically according to repository settings
New commits pushed, approval review dismissed automatically according to repository settings
WIP: #4797 Seccion Worker/Notificationto #4797 Seccion Worker/Notification@ -11,3 +11,3 @@
"[javascript]": {
"editor.defaultFormatter": "dbaeumer.vscode-eslint"
}
},
Aço es si gastes la extencio "Code Spell Checker", te revisa si esta ben escrites les coses en angles.
Aixina fas q no te marque salix com a una paraula mal.
Puc llevar-ho