verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 59 Releases Wiki Activity

1625-worker_department_treeview #15

Manually merged
carlosjr merged 12 commits from 1625-worker_department_treeview into dev 2019-10-08 11:12:52 +00:00
Conversation 0 Commits 12 Files Changed 33 +837 -486
joan commented 2019-10-08 07:27:18 +00:00
Contributor
Copy Link

Ready for code review & merge

Ready for code review & merge
joan self-assigned this 2019-10-08 07:27:18 +00:00
juan was assigned by joan 2019-10-08 07:27:18 +00:00
carlosjr reviewed 2019-10-08 10:06:25 +00:00
loopback/locale/es.json Outdated
carlosjr commented 2019-10-08 10:06:25 +00:00
Contributor
Copy Link

missing translation :)

missing translation :)
carlosjr reviewed 2019-10-08 10:11:00 +00:00
modules/worker/back/methods/department/getLeaves.js Outdated
carlosjr commented 2019-10-08 10:11:00 +00:00
Contributor
Copy Link

parentFk doesn't point to a column, it should be parentId

parentFk doesn't point to a column, it should be parentId
carlosjr reviewed 2019-10-08 10:11:51 +00:00
modules/worker/back/methods/department/removeChild.js Outdated
carlosjr commented 2019-10-08 10:11:51 +00:00
Contributor
Copy Link

not cool XD

not cool XD
carlosjr requested changes 2019-10-08 10:18:26 +00:00
carlosjr left a comment
Contributor
Copy Link

please amend

please amend
carlosjr approved these changes 2019-10-08 10:54:15 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr approved these changes 2019-10-08 10:55:13 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr closed this pull request 2019-10-08 11:12:52 +00:00
joan deleted branch 1625-worker_department_treeview 2019-10-08 11:21:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
joan
juan
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#15
No description provided.
Delete Branch "1625-worker_department_treeview"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?