verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 59 Releases Wiki Activity

5638-ticket.summary_states #1538

Merged
vicent merged 9 commits from 5638-ticket.summary_states into dev 2023-05-19 11:35:32 +00:00
Conversation 0 Commits 9 Files Changed 3 +28 -39
vicent commented 2023-05-18 07:52:57 +00:00
Contributor
Copy Link
No description provided.
vicent added the
CR / Tests passed
 label 2023-05-18 07:52:57 +00:00
vicent added 8 commits 2023-05-18 07:52:58 +00:00
gitea/salix/pipeline/head This commit looks good Details
404acdab6f refs #5638 fix: solucionado problema con el limit
gitea/salix/pipeline/head This commit looks good Details
b66362d313 refs #5638 fix: cambiado nombre de variable
gitea/salix/pipeline/head This commit looks good Details
463d209d77 refs #5638 refactor: eliminado if innecesario
gitea/salix/pipeline/head This commit looks good Details
d33a84c39f refs #5638 feat: updated backTest
gitea/salix/pipeline/head This commit looks good Details
703ab3439a refs #5638 fix: intermittent e2e
vicent requested review from alexm 2023-05-18 07:53:29 +00:00
alexm requested changes 2023-05-18 12:02:58 +00:00
modules/ticket/back/methods/state/editableStates.js
@ -20,3 +21,3 @@
const models = Self.app.models;
const userId = ctx.req.accessToken.userId;
const myOptions = {};
const myOptions = {...(options || {})};
alexm commented 2023-05-18 12:02:56 +00:00
Member
Copy Link

Revisar

Revisar
vicent marked this conversation as resolved
modules/ticket/back/methods/state/editableStates.js Outdated
@ -31,3 +27,2 @@
if (isProduction || isAdministrative)
return statesList;
const where = (isProduction || isAdministrative) ? undefined : {alertLevel: 0};
alexm commented 2023-05-18 12:02:43 +00:00
Member
Copy Link

Refactor, ho tens en rocket

Refactor, ho tens en rocket
vicent marked this conversation as resolved
vicent added 1 commit 2023-05-19 06:03:24 +00:00
gitea/salix/pipeline/head This commit looks good Details
8cf988b7d2 refs #5638 refactor: code
vicent requested review from alexm 2023-05-19 06:10:30 +00:00
alexm approved these changes 2023-05-19 06:24:04 +00:00
vicent merged commit f81e9ec23e into dev 2023-05-19 11:35:32 +00:00
vicent deleted branch 5638-ticket.summary_states 2023-05-19 11:35:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1538
No description provided.
Delete Branch "5638-ticket.summary_states"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?