verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 51 Releases Wiki Activity

5638-ticket.summary_states #1538

Merged
vicent merged 9 commits from 5638-ticket.summary_states into dev 2023-05-19 11:35:32 +00:00
Conversation 0 Commits 9 Files Changed 3 +4 -8
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 463d209d77 - Show all commits

12
modules/ticket/back/methods/state/editableStates.js
View File

@ -20,21 +20,17 @@ module.exports = Self => {
Self.editableStates = async(ctx, filter, options) => { Self.editableStates = async(ctx, filter, options) => {
const models = Self.app.models; const models = Self.app.models;
const userId = ctx.req.accessToken.userId; const userId = ctx.req.accessToken.userId;
const myOptions = {...(options || {})}; const myOptions = {...(options || {})};
vicent marked this conversation as resolved
alexm commented 2023-05-18 12:02:56 +00:00
Review
Copy Link

Revisar

Revisar
const isProduction = await models.VnUser.hasRole(userId, 'production', myOptions); const isProduction = await models.VnUser.hasRole(userId, 'production', myOptions);
const isSalesPerson = await models.VnUser.hasRole(userId, 'salesPerson', myOptions);
const isAdministrative = await models.VnUser.hasRole(userId, 'administrative', myOptions); const isAdministrative = await models.VnUser.hasRole(userId, 'administrative', myOptions);
let where = {alertLevel: 0}; const where = (isProduction || isAdministrative) ? undefined : {alertLevel: 0};
vicent marked this conversation as resolved Outdated
alexm commented 2023-05-18 12:02:43 +00:00
Outdated
Review
Copy Link

Refactor, ho tens en rocket

Refactor, ho tens en rocket
if (isSalesPerson)
where = {or: [{alertLevel: 0}, {code: 'PICKER_DESIGNED'}]};
else if (isProduction || isAdministrative)
where = undefined;
filter = mergeFilters(filter, {where}); filter = mergeFilters(filter, {where});
return models.State.find(filter, myOptions); const states = await models.State.find(filter, myOptions);
return states;
}; };
}; };