verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refs #5678 feat(sale_canEdit): handle exist sale #1555

Merged
alexm merged 5 commits from 5678-sale-canEdit-notSale into dev 2023-05-25 08:03:59 +00:00
Conversation 0 Commits 5 Files Changed 3 +34 -14
alexm commented 2023-05-24 09:21:05 +00:00
Member
Copy Link
No description provided.
alexm added the
CR / Tests passed
 label 2023-05-24 09:21:05 +00:00
alexm added 1 commit 2023-05-24 09:21:05 +00:00
gitea/salix/pipeline/head This commit looks good Details
30c896c975 refs #5678 feat(sale_canEdit): handle exist sale
alexm requested review from jgallego 2023-05-24 09:21:18 +00:00
jgallego requested changes 2023-05-24 10:49:01 +00:00
loopback/locale/es.json Outdated
@ -84,6 +84,7 @@
"The current ticket can't be modified": "El ticket actual no puede ser modificado",
"The current claim can't be modified": "La reclamación actual no puede ser modificada",
"The sales of this ticket can't be modified": "Las lineas de este ticket no pueden ser modificadas",
"The sales do not exist": "La(s) linea(s) seleccionada no(s) exite(n)",
jgallego commented 2023-05-24 10:47:19 +00:00
Owner
Copy Link

no(s) sustituir per no

no(s) sustituir per no
alexm marked this conversation as resolved
modules/ticket/back/methods/sale/specs/canEdit.spec.js Outdated
@ -17,6 +17,32 @@ describe('sale canEdit()', () => {
});
});
describe('sale not exist', () => {
jgallego commented 2023-05-24 10:48:00 +00:00
Owner
Copy Link

exists

exists
alexm marked this conversation as resolved
modules/ticket/back/methods/sale/specs/canEdit.spec.js Outdated
@ -18,2 +18,4 @@
});
describe('sale not exist', () => {
it('should return error if sale not exist', async() => {
jgallego commented 2023-05-24 10:47:50 +00:00
Owner
Copy Link

exists

exists
alexm marked this conversation as resolved
alexm added 1 commit 2023-05-24 11:00:06 +00:00
gitea/salix/pipeline/head This commit looks good Details
6b66eb3bb2 refs #5679 typo
alexm requested review from jgallego 2023-05-24 11:00:19 +00:00
jgallego requested changes 2023-05-24 11:25:17 +00:00
loopback/locale/es.json Outdated
@ -84,6 +84,7 @@
"The current ticket can't be modified": "El ticket actual no puede ser modificado",
"The current claim can't be modified": "La reclamación actual no puede ser modificada",
"The sales of this ticket can't be modified": "Las lineas de este ticket no pueden ser modificadas",
"The sales do not exists": "La(s) linea(s) seleccionada(s) no exite(n)",
jgallego commented 2023-05-24 11:24:38 +00:00
Owner
Copy Link

exite.. existen

exite.. existen
alexm marked this conversation as resolved
alexm added 1 commit 2023-05-24 11:38:20 +00:00
gitea/salix/pipeline/head This commit looks good Details
292d9e038d typo
alexm requested review from jgallego 2023-05-24 11:38:37 +00:00
jgallego approved these changes 2023-05-24 13:49:47 +00:00
alexm added 1 commit 2023-05-25 05:35:04 +00:00
alexm requested review from vicent 2023-05-25 06:21:11 +00:00
vicent approved these changes 2023-05-25 07:49:24 +00:00
alexm added 1 commit 2023-05-25 07:49:44 +00:00
gitea/salix/pipeline/head This commit looks good Details
a0da78700b Merge branch 'dev' into 5678-sale-canEdit-notSale
alexm merged commit 1a4ae400c7 into dev 2023-05-25 08:03:59 +00:00
alexm deleted branch 5678-sale-canEdit-notSale 2023-05-25 08:03:59 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
vicent
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1555
No description provided.
Delete Branch "5678-sale-canEdit-notSale"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?