verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refs #5398 fix #1579

Merged
carlossa merged 2 commits from 5398-fixAgenciesWarehouses into dev 2023-06-01 07:49:39 +00:00
Conversation 0 Commits 2 Files Changed 2 +2 -2
carlossa commented 2023-05-31 12:46:46 +00:00
Member
Copy Link
No description provided.
carlossa added the
CR / Tests passed
 label 2023-05-31 12:46:46 +00:00
carlossa added 1 commit 2023-05-31 12:46:46 +00:00
gitea/salix/pipeline/head This commit looks good Details
967e07933d refs #5398 fix
carlossa requested review from vicent 2023-05-31 12:46:53 +00:00
vicent requested changes 2023-05-31 13:04:03 +00:00
modules/route/front/agency-term-search-panel/index.html Outdated
@ -3,3 +3,3 @@
auto-load="true"
url="Agencies"
data="agencies">
data="Agencies">
vicent commented 2023-05-31 13:01:07 +00:00
Contributor
Copy Link

els data sempre ho posem en minuscules, seria data="agencies"

els data sempre ho posem en minuscules, seria data="agencies"
modules/route/front/agency-term-search-panel/index.html Outdated
@ -23,3 +23,3 @@
</vn-autocomplete>
<vn-autocomplete vn-one
url="Agencies"
data="Agencies"
vicent commented 2023-05-31 13:02:18 +00:00
Contributor
Copy Link

va en minuscules, data="agencies". Pq lo que fas en el crud-model de dalt es traure els datos de url="Agencies" y guardarlos en data="agencies".

va en minuscules, data="agencies". Pq lo que fas en el crud-model de dalt es traure els datos de url="Agencies" y guardarlos en data="agencies".
modules/worker/front/dms/create/index.html Outdated
@ -36,3 +36,3 @@
label="Warehouse"
ng-model="$ctrl.dms.warehouseId"
url="Warehouses"
data="Warehouses"
vicent commented 2023-05-31 13:03:59 +00:00
Contributor
Copy Link

lo mateix, es "warehouses" en minuscula.
Revisa tot el que has posat en la tarea original, pq he vist molts data que estaven en mayuscules.
Y comproba que funciona, pq ara si ho proves, el desplegable no te mostra ningun resultat

lo mateix, es "warehouses" en minuscula. Revisa tot el que has posat en la tarea original, pq he vist molts data que estaven en mayuscules. Y comproba que funciona, pq ara si ho proves, el desplegable no te mostra ningun resultat
carlossa added 1 commit 2023-06-01 05:52:34 +00:00
gitea/salix/pipeline/head This commit looks good Details
0ee8811c15 refs #5398 fix agencies, warehouses
carlossa requested review from vicent 2023-06-01 06:07:19 +00:00
vicent approved these changes 2023-06-01 06:14:10 +00:00
carlossa merged commit ffba5b2d7e into dev 2023-06-01 07:49:39 +00:00
carlossa deleted branch 5398-fixAgenciesWarehouses 2023-06-01 07:49:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
vicent
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1579
No description provided.
Delete Branch "5398-fixAgenciesWarehouses"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?