verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 58 Releases Wiki Activity

fixes #5749 Añadir clave primaria autoincrementable a la tabla vn.zoneIncluded #1590

Merged
pablone merged 14 commits from 5749-autoincrement-zoneIncluded into dev 2023-10-19 11:03:13 +00:00
Conversation 0 Commits 14 Files Changed 3 +39 -10
alexandre commented 2023-06-06 08:31:44 +00:00
Contributor
Copy Link
No description provided.
alexandre added 1 commit 2023-06-06 08:31:44 +00:00
gitea/salix/pipeline/head This commit looks good Details
6e4d7e8b01 refs #5749 added id
alexandre changed title from WIP: #5749 Añadir clave primaria autoincrementable a la tabla vn.zoneIncluded to fixes #5749 Añadir clave primaria autoincrementable a la tabla vn.zoneIncluded 2023-06-06 08:39:56 +00:00
alexandre requested review from juan 2023-06-06 08:40:05 +00:00
alexandre added 1 commit 2023-06-06 08:40:24 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
daf85368a0 Merge branch 'dev' into 5749-autoincrement-zoneIncluded
juan requested changes 2023-06-06 19:12:44 +00:00
modules/zone/back/methods/zone/toggleIsIncluded.js Outdated
@ -37,11 +37,16 @@ module.exports = Self => {
if (isIncluded === undefined)
return models.ZoneIncluded.destroyAll({zoneFk: id, geoFk: geoId}, myOptions);
else {
return models.ZoneIncluded.upsert({
juan commented 2023-06-06 19:12:30 +00:00
Owner
Copy Link

No hace falta quitar el upsert, en principio deberia continuar comportandose igual ya que hay una clave unique de zoneFk y geoFk

No hace falta quitar el upsert, en principio deberia continuar comportandose igual ya que hay una clave unique de zoneFk y geoFk
alexandre commented 2023-06-07 07:47:18 +00:00
Author
Contributor
Copy Link

Estiguerem mirant-ho alexm i jo ahir i no varem poder canviar el model de loopback de ZoneIncluded per a posar que zoneFk i geoFk foren clave unica composta

Estiguerem mirant-ho alexm i jo ahir i no varem poder canviar el model de loopback de ZoneIncluded per a posar que zoneFk i geoFk foren clave unica composta
alexandre added 1 commit 2023-06-16 07:01:25 +00:00
gitea/salix/pipeline/head This commit looks good Details
b6bdac3114 Merge branch 'dev' into 5749-autoincrement-zoneIncluded
alexandre added 2 commits 2023-06-16 11:21:27 +00:00
pablone added 1 commit 2023-09-12 13:47:03 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
740514c5a8 Merge branch 'dev' into 5749-autoincrement-zoneIncluded
pablone requested review from juan 2023-09-13 14:19:06 +00:00
pablone added 1 commit 2023-09-14 16:05:32 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
191b254acc Merge branch 'dev' into 5749-autoincrement-zoneIncluded
pablone added 1 commit 2023-09-18 06:56:55 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
44ec197ea0 Merge branch 'dev' into 5749-autoincrement-zoneIncluded
pablone added 2 commits 2023-10-17 13:05:01 +00:00
pablone requested review from alexm 2023-10-17 13:05:05 +00:00
alexm reviewed 2023-10-18 05:11:50 +00:00
db/changes/234201/00-zoneIncluded.sql
@ -0,0 +7,4 @@
ADD PRIMARY KEY (`id`),
ADD CONSTRAINT `zoneIncluded_FK_1` FOREIGN KEY (zoneFk) REFERENCES `vn`.`zone`(id) ON DELETE CASCADE ON UPDATE CASCADE,
ADD CONSTRAINT `zoneIncluded_FK_2` FOREIGN KEY (geoFk) REFERENCES `vn`.`zoneGeo`(id) ON DELETE CASCADE ON UPDATE CASCADE,
ADD CONSTRAINT `unique_zone_geo` UNIQUE (`zoneFk`, `geoFk`);
alexm commented 2023-10-18 05:11:50 +00:00
Member
Copy Link

Al fer DROP KEY geoFk_idx se perd el INDEX, faria falta possarli index?

Al fer DROP KEY `geoFk_idx` se perd el INDEX, faria falta possarli index?
pablone commented 2023-10-19 10:01:11 +00:00
Member
Copy Link

se crea un index para zoneFk y geoFk

se crea un index para zoneFk y geoFk
juan marked this conversation as resolved
alexm approved these changes 2023-10-18 05:11:53 +00:00
pablone added 1 commit 2023-10-18 11:07:32 +00:00
gitea/salix/pipeline/head This commit looks good Details
bf09f13aa2 Merge branch 'dev' into 5749-autoincrement-zoneIncluded
pablone added 1 commit 2023-10-18 11:24:12 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
3e96b3d0d2 Merge branch 'dev' into 5749-autoincrement-zoneIncluded
juan approved these changes 2023-10-19 10:14:16 +00:00
juan added 1 commit 2023-10-19 10:14:35 +00:00
gitea/salix/pipeline/head This commit looks good Details
39a0f13500 Merge branch 'dev' into 5749-autoincrement-zoneIncluded
pablone added 1 commit 2023-10-19 10:49:40 +00:00
gitea/salix/pipeline/head This commit looks good Details
71182d8630 Merge branch 'dev' into 5749-autoincrement-zoneIncluded
pablone merged commit 68975e0412 into dev 2023-10-19 11:03:13 +00:00
pablone deleted branch 5749-autoincrement-zoneIncluded 2023-10-19 11:03:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
juan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1590
No description provided.
Delete Branch "5749-autoincrement-zoneIncluded"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?