verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

#5576 Reestructurar el directorio de imagenes #1618

Open
alexandre wants to merge 37 commits from 5576-reestructurar-directorio-imagenes into dev
pull from: 5576-reestructurar-directorio-imagenes
merge into: verdnatura:dev
Conversation 0 Commits 37 Files Changed 12 +441 -96
alexandre commented 2023-06-15 11:52:13 +00:00
Contributor
Copy Link
No description provided.
alexandre added 1 commit 2023-06-15 11:52:14 +00:00
gitea/salix/pipeline/head This commit looks good Details
c01083d696 refs #5576 wip symlink
alexandre added 1 commit 2023-06-15 11:55:11 +00:00
jsegarra added 3 commits 2023-11-20 13:58:19 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
776055f167 refs #5576 test: image resize
jsegarra added 1 commit 2023-11-21 07:55:24 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
d0ff8ba57f Merge branch 'dev' into 5576-reestructurar-directorio-imagenes
jsegarra added 2 commits 2023-11-29 06:47:21 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
7cd7502a9f refs #5576 feat sh to generate symbolic links
jsegarra added 1 commit 2023-12-15 20:55:55 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
fc96038125 approach
jsegarra added 1 commit 2023-12-16 21:52:29 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
838c56d770 approach
jsegarra added 1 commit 2023-12-16 23:07:48 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
0da816ca35 approach
jsegarra added 1 commit 2023-12-16 23:34:19 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
166f25470d done
jsegarra added 2 commits 2023-12-18 10:33:41 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
f4f2333d36 refs #5576 perf update scripts sh
jsegarra added 1 commit 2023-12-19 07:14:04 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
b2f569262a Merge branch 'dev' into 5576-reestructurar-directorio-imagenes
jsegarra added 1 commit 2023-12-19 07:44:23 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
c1e245c2ea refs #5576 perf: remove bad comments
jsegarra requested review from juan 2023-12-19 07:44:30 +00:00
jsegarra changed title from WIP: #5576 Reestructurar el directorio de imagenes to #5576 Reestructurar el directorio de imagenes 2023-12-19 07:44:35 +00:00
jsegarra added 1 commit 2023-12-20 08:09:40 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
f450472915 Merge branch 'dev' into 5576-reestructurar-directorio-imagenes
jsegarra added 1 commit 2023-12-22 08:46:27 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
1196b32148 refs #5576 perf: remove bad code
jsegarra added 1 commit 2023-12-22 08:57:46 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
55b737f376 refs #5576 perf: remove echo from sh files
jsegarra added 1 commit 2024-01-20 11:22:46 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
16cb42761e refs #5576 perf: remove bad try/catch declarations
jsegarra added 2 commits 2024-01-22 11:47:43 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
f6d0cf7817 refs #5576 feat update db/change version
jsegarra added 1 commit 2024-01-30 14:01:50 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
57791d380d Merge branch 'dev' of https://gitea.verdnatura.es/verdnatura/salix into 5576-reestructurar-directorio-imagenes
jsegarra added 2 commits 2024-02-05 09:23:29 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
8fa9cf9054 Merge remote-tracking branch 'origin/dev' into 5576-reestructurar-directorio-imagenes
jsegarra added 1 commit 2024-02-21 13:45:22 +00:00
jsegarra added 2 commits 2024-03-07 11:43:49 +00:00
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
b486469f98 solve fixtures.before.sql merge
jsegarra added 3 commits 2024-03-12 10:46:36 +00:00
jsegarra added 1 commit 2024-04-01 09:38:36 +00:00
jsegarra added 1 commit 2024-04-01 10:12:52 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
68520e046a refs #5576 test: fix
jsegarra added 1 commit 2024-04-01 10:20:17 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
d2b4c8a3dc updates
jsegarra added 1 commit 2024-04-01 10:26:55 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
cc510758da refs #5576 test: updaload new image
jsegarra added 1 commit 2024-04-01 10:28:52 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
778c1aee71 revert gitignore
juan reviewed 2024-06-11 07:13:31 +00:00
juan left a comment
Owner
Copy Link

No puede aplicarse hasta que no este preparado el script que resuelva la ruta antigua durante la migración de directorios.

No puede aplicarse hasta que no este preparado el script que resuelva la ruta antigua durante la migración de directorios.
back/models/image.js
@ -41,0 +63,4 @@
try {
await fs.unlink(child);
} catch (e) {
throw new Error(e);
juan commented 2024-01-19 09:42:40 +00:00
Owner
Copy Link

Porque se pone un try ... catch si se vuelve a relanzar el error tal cual?

Porque se pone un `try ... catch` si se vuelve a relanzar el error tal cual?
back/models/image.js
@ -41,0 +76,4 @@
const exists = await fs.exists(parent);
exists && await fs.unlink(parent);
} catch (e) {
throw new Error(e);
juan commented 2024-01-19 09:42:50 +00:00
Owner
Copy Link

Porque se pone un try ... catch si se vuelve a relanzar el error tal cual?

Porque se pone un `try ... catch` si se vuelve a relanzar el error tal cual?
back/models/image.js
@ -41,0 +81,4 @@
try {
await fs.symlink(child, parent);
} catch (e) {
throw new Error(e);
juan commented 2024-01-19 09:42:53 +00:00
Owner
Copy Link

Porque se pone un try ... catch si se vuelve a relanzar el error tal cual?

Porque se pone un `try ... catch` si se vuelve a relanzar el error tal cual?
back/models/image.js Outdated
@ -80,0 +126,4 @@
try {
await fs.mkdir(fullSizePath, {recursive: true});
} catch (e) {
throw new Error(e);
juan commented 2024-01-19 09:43:11 +00:00
Owner
Copy Link

Porque se pone un try ... catch si se vuelve a relanzar el error tal cual?

Porque se pone un `try ... catch` si se vuelve a relanzar el error tal cual?
juan requested changes 2024-06-11 07:14:11 +00:00
juan left a comment
Owner
Copy Link

No puede aplicarse hasta que no este preparado el script que resuelva la ruta antigua durante la migración de directorios.

No puede aplicarse hasta que no este preparado el script que resuelva la ruta antigua durante la migración de directorios.
guillermo added 1 commit 2024-06-13 11:22:59 +00:00
This pull request has changes conflicting with the target branch.
  • back/models/image-config.json
  • db/dump/fixtures.before.sql
Sign in to join this conversation.
Reviewers
No reviewers
juan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1618
No description provided.
Delete Branch "5576-reestructurar-directorio-imagenes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?