verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refs #5874 feat: refactorizado proceso facturación #1658

Merged
vicent merged 3 commits from hotfix_makeInvoice-refactor into master 2023-07-11 09:49:37 +00:00
Conversation 0 Commits 3 Files Changed 18 +389 -225
vicent commented 2023-07-11 07:21:18 +00:00
Contributor
Copy Link
No description provided.
vicent added the
CR / Tests passed
 label 2023-07-11 07:21:18 +00:00
vicent added 1 commit 2023-07-11 07:21:20 +00:00
vicent requested review from alexm 2023-07-11 07:21:33 +00:00
alexm approved these changes 2023-07-11 07:29:34 +00:00
alexm requested review from jgallego 2023-07-11 07:29:43 +00:00
vicent added 1 commit 2023-07-11 07:33:03 +00:00
gitea/salix/pipeline/head This commit looks good Details
56247b5012 add acl
jgallego requested changes 2023-07-11 07:46:49 +00:00
modules/client/front/summary/index.html Outdated
@ -297,2 +297,4 @@
info="Value from 1 to 20. The higher the better value">
</vn-label-value>
<vn-label-value label="Recommended credit"
value="{{$ctrl.summary.recommendedCredit | currency: 'EUR': 2}}">
jgallego commented 2023-07-11 07:35:51 +00:00
Owner
Copy Link

sense decimals, aprofita y modifiques tb el crédit son int

sense decimals, aprofita y modifiques tb el crédit son int
vicent marked this conversation as resolved
modules/ticket/back/methods/ticket/invoiceTickets.js Outdated
@ -0,0 +88,4 @@
const models = Self.app.models;
await models.Ticket.rawSql(`
DROP TEMPORARY TABLE IF EXISTS tmp.ticketToInvoice;
jgallego commented 2023-07-11 07:43:20 +00:00
Owner
Copy Link

CREATE OR REPLACE

CREATE OR REPLACE
vicent marked this conversation as resolved
modules/ticket/back/methods/ticket/invoiceTickets.js
@ -0,0 +100,4 @@
const invoiceId = await models.Ticket.makeInvoice(ctx, 'R', companyId, Date.vnNew(), myOptions);
invoicesIds.push(invoiceId);
}
jgallego commented 2023-07-11 07:43:49 +00:00
Owner
Copy Link

tmp.ticketToInvoice crec que ací has de fer drop de la taula temporal

tmp.ticketToInvoice crec que ací has de fer drop de la taula temporal
vicent commented 2023-07-11 07:57:45 +00:00
Author
Contributor
Copy Link

Ho fa el proc invoiceOut_new, que se crida.

Ho fa el proc invoiceOut_new, que se crida.
vicent marked this conversation as resolved
modules/ticket/back/methods/ticket/specs/canBeInvoiced.spec.js Outdated
@ -25,2 +20,3 @@
const canBeInvoiced = await models.Ticket.canBeInvoiced([ticketId], options);
await models.Ticket.rawSql(`
DROP TEMPORARY TABLE IF EXISTS tmp.ticketToInvoice;
jgallego commented 2023-07-11 07:45:39 +00:00
Owner
Copy Link

create or replace

create or replace
vicent marked this conversation as resolved
vicent added 1 commit 2023-07-11 07:58:28 +00:00
gitea/salix/pipeline/head This commit looks good Details
da13f0811c refs 5887 cambiado drop y create por create or replace
vicent requested review from jgallego 2023-07-11 07:58:33 +00:00
jgallego approved these changes 2023-07-11 09:16:16 +00:00
jgallego left a comment
Owner
Copy Link

confirma els permisos

confirma els permisos
vicent merged commit 810021e23a into master 2023-07-11 09:49:37 +00:00
vicent deleted branch hotfix_makeInvoice-refactor 2023-07-11 09:49:37 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1658
No description provided.
Delete Branch "hotfix_makeInvoice-refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?