verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

5934-clientSms #1675

Merged
alexm merged 5 commits from 5934-clientSms into dev 2023-07-20 07:01:02 +00:00
Conversation 0 Commits 5 Files Changed 9 +140 -1
vicent commented 2023-07-18 11:02:06 +00:00
Contributor
Copy Link
No description provided.
vicent added the
CR / Tests passed
 label 2023-07-18 11:02:06 +00:00
vicent added 2 commits 2023-07-18 11:02:08 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
b3a7a170f0 refs #5934 feat: añadido clientSms log
gitea/salix/pipeline/head This commit looks good Details
3e8775149a refs #5934 feat: change icon
vicent requested review from alexm 2023-07-18 11:14:06 +00:00
alexm reviewed 2023-07-19 05:08:42 +00:00
db/changes/233001/00-clientSms.sql Outdated
@ -0,0 +7,4 @@
KEY `clientSms_FK_1` (`smsFk`),
CONSTRAINT `clientSms_FK` FOREIGN KEY (`clientFk`) REFERENCES `client` (`id`) ON UPDATE CASCADE,
CONSTRAINT `clientSms_FK_1` FOREIGN KEY (`smsFk`) REFERENCES `sms` (`id`) ON UPDATE CASCADE
) ENGINE=InnoDB AUTO_INCREMENT=2 DEFAULT CHARSET=utf8mb3 COLLATE=utf8mb3_unicode_ci;
alexm commented 2023-07-19 05:08:42 +00:00
Member
Copy Link

AUTO_INCREMENT=2 esta be?

AUTO_INCREMENT=2 esta be?
vicent marked this conversation as resolved
alexm requested changes 2023-07-19 05:20:24 +00:00
db/changes/233001/00-clientSms.sql Outdated
@ -0,0 +11,4 @@
INSERT INTO `salix`.`ACL` (`model`, `property`, `accessType`, `permission`, `principalType`, `principalId`)
VALUES
('ClientSms', '*', 'READ', 'ALLOW', 'ROLE', 'employee'),
alexm commented 2023-07-19 05:09:20 +00:00
Member
Copy Link

De moment donali els especifics https://loopback.io/doc/en/lb2/Controlling-data-access.html, encomter de *

De moment donali els especifics https://loopback.io/doc/en/lb2/Controlling-data-access.html, encomter de *
vicent marked this conversation as resolved
modules/client/back/models/client-sms.json
@ -0,0 +15,4 @@
"clientFk": {
"type": "number"
},
"smsFk": {
alexm commented 2023-07-19 05:11:16 +00:00
Member
Copy Link

Me sona que quan ja tens la relacio baix, no cal possar tambe el camp en properties

Me sona que quan ja tens la relacio baix, no cal possar tambe el camp en properties
vicent marked this conversation as resolved
modules/client/front/sms/index.html Outdated
@ -0,0 +20,4 @@
</vn-tr>
</vn-thead>
<vn-tbody>
<vn-tr ng-repeat="clientSms in clientSmss">
alexm commented 2023-07-19 05:19:34 +00:00
Member
Copy Link

Si ClientSms representa varios mensajes SMS de un cliente, un nombre más apropiado para la variable sería clientSmsList, clientSmsArray, o simplemente clientSms. Esto indicaría que la variable contiene una lista o un conjunto de mensajes SMS de un cliente.

El uso de List o Array al final del nombre de la variable es una convención común en programación para indicar que la variable es una colección de elementos.

Por otro lado, si prefieres no indicar el tipo de dato en el nombre de la variable, simplemente usar clientSms (en plural) también sería adecuado, ya que en inglés, la forma plural de "SMS" es también "SMS".

Jo gastaria clientSmsList

Si ClientSms representa varios mensajes SMS de un cliente, un nombre más apropiado para la variable sería clientSmsList, clientSmsArray, o simplemente clientSms. Esto indicaría que la variable contiene una lista o un conjunto de mensajes SMS de un cliente. El uso de List o Array al final del nombre de la variable es una convención común en programación para indicar que la variable es una colección de elementos. Por otro lado, si prefieres no indicar el tipo de dato en el nombre de la variable, simplemente usar clientSms (en plural) también sería adecuado, ya que en inglés, la forma plural de "SMS" es también "SMS". Jo gastaria clientSmsList
vicent marked this conversation as resolved
vicent added 1 commit 2023-07-20 05:16:46 +00:00
gitea/salix/pipeline/head Build queued... Details
ab95ef74a9 refs #5934 refactor: nombres variables
vicent requested review from alexm 2023-07-20 05:16:49 +00:00
vicent added 77 commits 2023-07-20 05:17:20 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
b45b0ff826 refs #5066 copy project from the other
gitea/salix/pipeline/head There was a failure building this commit Details
16fdfa00fd refs #5066 e2e solve
gitea/salix/pipeline/head This commit looks good Details
237c83c6f5 refs #5066 getVehicleSorted small mod
gitea/salix/pipeline/head This commit looks good Details
91edc09057 refs #5066 move sql
gitea/salix/pipeline/head This commit looks good Details
d8e7c2700a refs #5066 fix autocomplete
gitea/salix/pipeline/head This commit looks good Details
3423ce612c refs #5066 e2e fixs, change name sorted
gitea/salix/pipeline/head This commit looks good Details
8fff3989e7 Merge branch 'dev' into 5066-vehicleSorted
gitea/salix/pipeline/head This commit looks good Details
813c4ede00 Merge branch 'dev' into 5066-vehicleSorted
gitea/salix/pipeline/head This commit looks good Details
d18137bce0 refs #5066 not dense
gitea/salix/pipeline/head There was a failure building this commit Details
cc27d1fa97 refs #5066 fix vehicle res.data
gitea/salix/pipeline/head This commit looks good Details
dcbe8c5f7a refs #5066 quit if
gitea/salix/pipeline/head This commit looks good Details
eff46c1cec refs #5066 e2e fix, vnConfig
gitea/salix/pipeline/head This commit looks good Details
510b78c703 refs #6006 mod dias anteriores
gitea/salix/pipeline/head This commit looks good Details
78108b2ca5 Merge branch 'master' into hotfix-travel
gitea/salix/pipeline/head There was a failure building this commit Details
c0d329edca a
gitea/salix/pipeline/head There was a failure building this commit Details
ef6a2ae578 refs #5887 fix: delete requires
gitea/salix/pipeline/head There was a failure building this commit Details
7aaaf5492c refs #5887 refacotr: move code to hook
gitea/salix/pipeline/head This commit looks good Details
12685e045c tedst
gitea/salix/pipeline/head This commit looks good Details
b228b693cc Merge pull request 'refs #6006 mod dias anteriores' (!1662) from hotfix-travel into master 
Reviewed-on: #1662
Reviewed-by: Javi Gallego <jgallego@verdnatura.es>
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/head There was a failure building this commit Details
978224c21c Merge branch 'master' into hotfix_mailAlias
gitea/salix/pipeline/head There was a failure building this commit Details
3a61bc6052 refs #5887 move changes sql
gitea/salix/pipeline/head This commit looks good Details
337ce56a60 refs #5887 test exlcuido
gitea/salix/pipeline/head This commit looks good Details
988ff96016 Merge pull request 'hotfix_mailAlias' (!1664) from hotfix_mailAlias into master 
Reviewed-on: #1664
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
660612cb84 refs #5999 url
gitea/salix/pipeline/head This commit looks good Details
2627cafc22 refs #5999 defaulter country autocomplete
gitea/salix/pipeline/head This commit looks good Details
4632ed298d Merge branch 'master' into 5999-defaultCountry
gitea/salix/pipeline/head There was a failure building this commit Details
173ed251c3 refs #5964 fix supply
gitea/salix/pipeline/head This commit looks good Details
29a4c51518 Merge branch 'master' into 5964-supplyFixValidation
gitea/salix/pipeline/head This commit looks good Details
575d7710a6 Merge pull request 'refs #5964 fix supply' (!1666) from 5964-supplyFixValidation into master 
Reviewed-on: #1666
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
190db79019 Merge branch 'master' into 5999-defaultCountry
gitea/salix/pipeline/head There was a failure building this commit Details
5ffa8b8910 Merge pull request '5999-defaultCountry' (!1665) from 5999-defaultCountry into master 
Reviewed-on: #1665
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/head There was a failure building this commit Details
4a7cfe9122 fix: workCenter
gitea/salix/pipeline/head There was a failure building this commit Details
4f183d1c6a fix: worker.basic-data el boton guardar estava activo al hacer F5
gitea/salix/pipeline/head This commit looks good Details
5716acaa3c fix: test
gitea/salix/pipeline/head This commit looks good Details
6980392ba1 fix: tabulacion
gitea/salix/pipeline/head This commit looks good Details
06690ca71e Merge pull request 'hotfix_workCenter2' (!1669) from hotfix_workCenter2 into master 
Reviewed-on: #1669
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/head There was a failure building this commit Details
b2b335326e Merge branch 'dev' into 5066-vehicleSorted
gitea/salix/pipeline/head This commit looks good Details
f24aa2c801 pop vehicle error
gitea/salix/pipeline/head This commit looks good Details
10e726c486 move vehicleInvoice
gitea/salix/pipeline/head This commit looks good Details
a5d1c68511 change err and traduction
gitea/salix/pipeline/head This commit looks good Details
52f58a92c8 refs err.sqlMessage
gitea/salix/pipeline/head This commit looks good Details
47e8fab8d9 refs remove
gitea/salix/pipeline/head This commit looks good Details
93da129239 refs #5983 feat(itemShelving): add getInventory
gitea/salix/pipeline/head This commit looks good Details
9076553070 refs #5983 test(itemShelving): add getInventory
gitea/salix/pipeline/head There was a failure building this commit Details
bd723bb7ba refs #5824 mod ng
gitea/salix/pipeline/head This commit looks good Details
49c656928e refs #5983 feat(itemShelving): add visible
gitea/salix/pipeline/head This commit looks good Details
2f6c988005 Merge branch 'dev' into 5983_inventory_parking
gitea/salix/pipeline/head This commit looks good Details
36db2ee883 Merge branch 'dev' into 5066-vehicleSorted
gitea/salix/pipeline/head This commit looks good Details
9c746dd6c2 Merge pull request '5066-vehicleSorted' (!1467) from 5066-vehicleSorted into dev 
Reviewed-on: #1467
Reviewed-by: Javi Gallego <jgallego@verdnatura.es>
Reviewed-by: Juan Ferrer <juan@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
25ce685116 Merge branch 'dev' into 5824-fixUpsertFixedPrice
gitea/salix/pipeline/head This commit looks good Details
85c017431c refs #5983 fix(itemShelving): fixtures
gitea/salix/pipeline/head This commit looks good Details
e2f50d63f6 Merge branch 'dev' into 5983_inventory_parking
gitea/salix/pipeline/head This commit looks good Details
3d83b7b46d Merge pull request 'pop vehicle error' (!1672) from hotfix-vehicleError into master 
Reviewed-on: #1672
Reviewed-by: Vicent Llopis <vicent@verdnatura.es>
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
4150bdc6c8 Merge pull request 'refs #5824 mod ng' (!1678) from 5824-fixUpsertFixedPrice into dev 
Reviewed-on: #1678
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
b17de86fb1 refs #6043 add ACL
gitea/salix/pipeline/head This commit looks good Details
dbebd80a68 Merge branch 'dev' into 6043-fixe2eError
gitea/salix/pipeline/head This commit looks good Details
1f7f903ec6 Merge pull request 'refs #6043 add ACL' (!1680) from 6043-fixe2eError into dev 
Reviewed-on: #1680
Reviewed-by: Carlos Satorres Adam <carlossa@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
7cff014988 refs #5983 fix(itemShelving): vn
gitea/salix/pipeline/head This commit looks good Details
6344c11d1e Merge branch 'dev' into 5983_inventory_parking
gitea/salix/pipeline/head This commit looks good Details
b23dfaeeb1 Merge pull request '5983_inventory_parking' (!1677) from 5983_inventory_parking into dev 
Reviewed-on: #1677
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
Reviewed-by: Javi Gallego <jgallego@verdnatura.es>
gitea/salix/pipeline/head Build queued... Details
6df1ef9d4c Merge branch 'dev' into 5934-clientSms
alexm approved these changes 2023-07-20 06:38:22 +00:00
alexm added 8 commits 2023-07-20 06:51:04 +00:00
gitea/salix/pipeline/head This commit looks good Details
6d8b3e346d refs #5837 fix filter existingClient France
gitea/salix/pipeline/head This commit looks good Details
765c22df96 refs #5837 new table
gitea/salix/pipeline/head There was a failure building this commit Details
93387cae62 refs #5837 if isSocialNameUnique
gitea/salix/pipeline/head This commit looks good Details
579d6d53d8 Merge branch 'dev' into 5837-quitRestrictionFrance
gitea/salix/pipeline/head This commit looks good Details
60e75d7825 refs #5837 fix client condition
gitea/salix/pipeline/head This commit looks good Details
aefcb8c49a Merge branch 'dev' into 5837-quitRestrictionFrance
gitea/salix/pipeline/head This commit looks good Details
c1e578a456 Merge pull request 'refs #5837 fix filter existingClient France' (!1668) from 5837-quitRestrictionFrance into dev 
Reviewed-on: #1668
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
5771ccb488 Merge branch 'dev' into 5934-clientSms
alexm merged commit 484bcd3fde into dev 2023-07-20 07:01:02 +00:00
alexm deleted branch 5934-clientSms 2023-07-20 07:01:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1675
No description provided.
Delete Branch "5934-clientSms"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?