5929-editTicketPrice #1688

Merged
jorgep merged 6 commits from 5929-editTicketPrice into dev 2023-07-26 08:24:07 +00:00
Member
No description provided.
jorgep added the
CR / Tests passed
label 2023-07-25 13:39:03 +00:00
jorgep added 3 commits 2023-07-25 13:39:06 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
4f80221101
refs #5929 added ACL and accurate errors
gitea/salix/pipeline/head There was a failure building this commit Details
9978db9d52
refs #5929 WIP test created
gitea/salix/pipeline/head There was a failure building this commit Details
543fbf3c0a
refs #5929 isEditableOrThrow created, tests passed
jorgep added 1 commit 2023-07-25 13:40:14 +00:00
gitea/salix/pipeline/head This commit looks good Details
96483a827f
Merge branch 'dev' into 5929-editTicketPrice
jorgep requested review from alexm 2023-07-25 13:51:49 +00:00
alexm requested changes 2023-07-26 05:20:45 +00:00
@ -50,3 +49,1 @@
const isEditable = await models.Ticket.isEditable(ctx, id, myOptions);
if (!isEditable)
throw new UserError(`The sales of this ticket can't be modified`);
const isEditable = await models.Ticket.isEditableOrThrow(ctx, id, myOptions);
Member

No hace falta guardarse el valor en una variable

No hace falta guardarse el valor en una variable
@ -120,3 +118,1 @@
if (!isEditable)
throw new UserError(`The sales of this ticket can't be modified`);
const isEditable = await models.Ticket.isEditableOrThrow(ctx, args.id, myOptions);
Member

No hace falta guardarse el valor en una variable

No hace falta guardarse el valor en una variable
@ -76,3 +73,1 @@
if (!isEditable)
throw new UserError(`The sales of this ticket can't be modified`);
const isEditable = await Self.isEditableOrThrow(ctx, args.id, myOptions);
Member

No hace falta guardarse el valor en una variable

No hace falta guardarse el valor en una variable
@ -37,3 +35,1 @@
if (!isEditable)
throw new UserError(`The current ticket can't be modified`);
const isEditable = await Self.isEditableOrThrow(ctx, id, myOptions);
Member

No hace falta guardarse el valor en una variable

No hace falta guardarse el valor en una variable
@ -43,3 +42,1 @@
if (!isEditable)
throw new UserError(`The sales of this ticket can't be modified`);
const isEditable = await Self.isEditableOrThrow(ctx, id, myOptions);
Member

No hace falta guardarse el valor en una variable

No hace falta guardarse el valor en una variable
@ -0,0 +68,4 @@
const ctx = {req: {accessToken: {userId: 1}}};
const result = await models.Ticket.isEditableOrThrow(ctx, 15, options);
Member

No hace falta guardarse el valor en una variable

No hace falta guardarse el valor en una variable
@ -0,0 +88,4 @@
const options = {transaction: tx};
const ctx = {req: {accessToken: {userId: 35}}};
result = await models.Ticket.isEditableOrThrow(ctx, 15, options);
Member

No hace falta guardarse el valor en una variable

No hace falta guardarse el valor en una variable
@ -33,3 +31,1 @@
if (!isEditable)
throw new UserError(`The current ticket can't be modified`);
const isEditable = await Self.isEditableOrThrow(ctx, id, myOptions);
Member

No hace falta guardarse el valor en una variable

No hace falta guardarse el valor en una variable
@ -51,3 +51,1 @@
const isEditable = await models.Ticket.isEditable(ctx, id, myOptions);
if (!isEditable)
throw new UserError(`The sales of this ticket can't be modified`);
const isEditable = await models.Ticket.isEditableOrThrow(ctx, id, myOptions);
Member

No hace falta guardarse el valor en una variable

No hace falta guardarse el valor en una variable
jorgep added 2 commits 2023-07-26 07:21:15 +00:00
jorgep requested review from alexm 2023-07-26 07:22:40 +00:00
alexm approved these changes 2023-07-26 08:04:13 +00:00
jorgep merged commit fca03e5b7c into dev 2023-07-26 08:24:07 +00:00
jorgep deleted branch 5929-editTicketPrice 2023-07-26 08:24:07 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1688
No description provided.