verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 67 Releases Wiki Activity

6013-sendMail_fix #1694

Merged
vicent merged 7 commits from 6013-sendMail_fix into dev 2023-08-24 08:35:06 +00:00
Conversation 0 Commits 7 Files Changed 2 +39 -20
vicent commented 2023-07-31 08:25:56 +00:00
Contributor
Copy Link
No description provided.
vicent added the
CR / Tests passed
 label 2023-07-31 08:25:56 +00:00
vicent added 3 commits 2023-07-31 08:25:58 +00:00
gitea/salix/pipeline/head This commit looks good Details
7367d1cdfe refs #6013 fix: add await
gitea/salix/pipeline/head This commit looks good Details
0054f2d82f refs #6013 fix: codigo no bloqueante
gitea/salix/pipeline/head This commit looks good Details
251ed36eca refs #6013 feat: mostrar error en el mail
vicent requested review from alexm 2023-07-31 08:26:23 +00:00
vicent added 1 commit 2023-07-31 08:26:38 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
7d10be37ec Merge branch 'dev' into 6013-sendMail_fix
alexm refused to review 2023-07-31 10:06:50 +00:00
vicent requested review from alexm 2023-08-22 11:14:46 +00:00
vicent added 1 commit 2023-08-22 11:18:14 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
c7c17e6e4a Merge branch 'dev' into 6013-sendMail_fix
alexm requested changes 2023-08-22 12:21:19 +00:00
modules/worker/back/methods/worker-time-control/sendMail.js Outdated
@ -373,2 +395,3 @@
if (tx) await tx.rollback();
throw e;
delete myOptions.transaction;
alexm commented 2023-08-22 12:21:16 +00:00
Member
Copy Link

Probar a quitar los deletes y quitar el if al crear la transaccion del inicio para que siempre la cree

Probar a quitar los deletes y quitar el if al crear la transaccion del inicio para que siempre la cree
vicent marked this conversation as resolved
vicent added 1 commit 2023-08-24 07:32:56 +00:00
vicent requested review from alexm 2023-08-24 07:33:14 +00:00
vicent added 1 commit 2023-08-24 07:33:14 +00:00
gitea/salix/pipeline/head This commit looks good Details
9a12169ba4 Merge branch 'dev' into 6013-sendMail_fix
alexm approved these changes 2023-08-24 08:17:28 +00:00
vicent merged commit 6e6e4d40d0 into dev 2023-08-24 08:35:06 +00:00
vicent deleted branch 6013-sendMail_fix 2023-08-24 08:35:06 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1694
No description provided.
Delete Branch "6013-sendMail_fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?