verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 54 Releases Wiki Activity

refs #5995 Implemented downloadCmrsZip #1734

Merged
guillermo merged 3 commits from 5995-getExternalCmrRouteFk into master 2023-09-20 06:08:21 +00:00
Conversation 0 Commits 3 Files Changed 5 +115 -33
guillermo commented 2023-09-01 12:15:13 +00:00
Member
Copy Link
No description provided.
guillermo added 1 commit 2023-09-01 12:15:14 +00:00
gitea/salix/pipeline/head This commit looks good Details
979315aa5e refs #5995 Implemented downloadCmrsZip
guillermo requested review from juan 2023-09-01 12:15:19 +00:00
juan requested changes 2023-09-11 06:59:31 +00:00
Dismissed
modules/route/back/methods/route/downloadCmrsZip.js Outdated
@ -0,0 +56,4 @@
});
if (response.headers['content-type'] !== 'application/pdf') {
throw new UserError(`The response for cmr id ${id} is not a PDF.`);
juan commented 2023-09-11 06:58:37 +00:00
Owner
Copy Link

Si el missatge de error se concatena en variables no se pot traduir, s'han de parametrizar

Si el missatge de error se concatena en variables no se pot traduir, s'han de parametrizar
modules/route/back/methods/route/getExternalCmrs.js
@ -123,0 +126,4 @@
WHERE co.code <> 'ES'
AND am.name <> 'ABONO'
AND w.code = 'ALG'
AND dm.code = 'DELIVERY'
juan commented 2023-09-11 06:59:25 +00:00
Owner
Copy Link

Tots aquestos valors estaría be traure-los de la configuracio de usuri o taules config

Tots aquestos valors estaría be traure-los de la configuracio de usuri o taules config
guillermo added 1 commit 2023-09-18 08:03:24 +00:00
gitea/salix/pipeline/head This commit looks good Details
6c34421413 refs #5995 Requested changes
guillermo requested review from juan 2023-09-18 08:03:31 +00:00
guillermo added 1 commit 2023-09-19 12:42:50 +00:00
gitea/salix/pipeline/head This commit looks good Details
56c1dbc096 Merge branch 'master' into 5995-getExternalCmrRouteFk
jgallego approved these changes 2023-09-20 06:05:20 +00:00
jgallego removed review request for juan 2023-09-20 06:06:44 +00:00
jgallego dismissed juan’s review 2023-09-20 06:07:12 +00:00
Reason:

guillermo me pide subirlo

jgallego dismissed juan’s review 2023-09-20 06:07:14 +00:00
Reason:

guillermo me pide subirlo

guillermo merged commit bf2528bacf into master 2023-09-20 06:08:21 +00:00
guillermo deleted branch 5995-getExternalCmrRouteFk 2023-09-20 06:08:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
juan
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1734
No description provided.
Delete Branch "5995-getExternalCmrRouteFk"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?