verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refs #5811 feat: al borrar expedicion borrar de viaexpress #1754

Merged
jorgep merged 15 commits from 5811-ticket.expedition_deleteViaexpress into dev 2023-11-27 07:36:28 +00:00
Conversation 2 Commits 15 Files Changed 9 +161 -39
alexm commented 2023-09-19 05:23:59 +00:00
Member
Copy Link
No description provided.
alexm added 1 commit 2023-09-19 05:24:00 +00:00
alexm added 1 commit 2023-09-19 05:24:11 +00:00
alexm added 1 commit 2023-10-26 12:14:39 +00:00
jorgep added 1 commit 2023-11-21 09:20:42 +00:00
jorgep added 1 commit 2023-11-22 14:45:08 +00:00
jorgep added 1 commit 2023-11-23 07:32:21 +00:00
jorgep added 1 commit 2023-11-23 07:48:49 +00:00
jorgep added 1 commit 2023-11-23 09:28:40 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
900dffbbba refs #5811 delete viaexpress expeditions included
jorgep commented 2023-11-23 09:31:19 +00:00
Member
Copy Link

Si se quiere probar hay que hacer el insert del comentario de la tarea

Si se quiere probar hay que hacer el insert del comentario de la tarea
jorgep added 1 commit 2023-11-23 09:34:24 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
2e67ef4f5d refs #5811 refactor deleteExpeditions
jorgep added 1 commit 2023-11-23 10:24:11 +00:00
gitea/salix/pipeline/head This commit looks good Details
db15285858 refs #5811 test updated
jorgep commented 2023-11-23 10:26:07 +00:00
Member
Copy Link

Para poder hacer test hay que hacer el insert primero. pendiente con @jgallego

Para poder hacer test hay que hacer el insert primero. pendiente con @jgallego
jorgep requested review from jgallego 2023-11-23 10:26:19 +00:00
jorgep changed title from WIP: refs #5811 feat: al borrar expedicion borrar de viaexpress to refs #5811 feat: al borrar expedicion borrar de viaexpress 2023-11-23 10:26:26 +00:00
jgallego requested changes 2023-11-23 11:33:31 +00:00
back/methods/viaexpress-config/deleteShipment.js Outdated
@ -0,0 +3,4 @@
module.exports = Self => {
Self.remoteMethod('deleteShipment', {
description: 'Create an expedition and return a label',
jgallego commented 2023-11-23 11:32:40 +00:00
Owner
Copy Link

esto no cuadra

esto no cuadra
jorgep marked this conversation as resolved
jorgep added 1 commit 2023-11-23 12:36:43 +00:00
gitea/salix/pipeline/head This commit looks good Details
eeef279483 refs #5811 replace decription
jorgep added 1 commit 2023-11-23 12:38:06 +00:00
jorgep requested review from jgallego 2023-11-23 12:38:13 +00:00
jgallego requested changes 2023-11-23 13:54:55 +00:00
back/methods/viaexpress-config/deleteShipmentRenderer.js Outdated
@ -0,0 +2,4 @@
const ejs = require('ejs');
module.exports = Self => {
Self.remoteMethod('deleteShipmentRenderer', {
jgallego commented 2023-11-23 13:54:47 +00:00
Owner
Copy Link

porque este nombre si lo que se borra es un expedition?

porque este nombre si lo que se borra es un expedition?
jorgep marked this conversation as resolved
jorgep added 1 commit 2023-11-24 09:23:40 +00:00
jorgep added 1 commit 2023-11-24 09:55:52 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
8ac3887d80 refs #5811 rename methods
jorgep added 1 commit 2023-11-24 10:00:00 +00:00
jorgep requested review from jgallego 2023-11-24 10:46:56 +00:00
jgallego approved these changes 2023-11-24 14:21:54 +00:00
jorgep merged commit d075cb97ad into dev 2023-11-27 07:36:28 +00:00
jorgep deleted branch 5811-ticket.expedition_deleteViaexpress 2023-11-27 07:36:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1754
No description provided.
Delete Branch "5811-ticket.expedition_deleteViaexpress"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?