verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refs #5890 feat: itemShelvingSaleAsignado #1767

Merged
alexm merged 10 commits from 5890--itemShelvingAsignado into dev 2023-09-29 10:28:22 +00:00
Conversation 0 Commits 10 Files Changed 7 +368 -4
sergiodt commented 2023-09-27 12:03:08 +00:00
Member
Copy Link
No description provided.
sergiodt added 1 commit 2023-09-27 12:03:09 +00:00
gitea/salix/pipeline/head This commit looks good Details
ac3e9c811d refs #5890 feat: itemShelvingSaleAsignado
sergiodt requested review from carlosap 2023-09-27 12:03:18 +00:00
sergiodt requested review from alexm 2023-09-27 12:03:18 +00:00
alexm requested changes 2023-09-28 05:35:03 +00:00
db/changes/234001/01-itemShelvingSale.sql Outdated
@ -0,0 +1,299 @@
ALTER TABLE vn.itemShelvingSale ADD isPicked TINYINT(1) DEFAULT FALSE NOT NULL;
alexm commented 2023-09-28 05:31:10 +00:00
Member
Copy Link

ficali les comilles, si no quan pujem a produccio fallara:
ALTER TABLE vn.itemShelvingSale ADD isPicked TINYINT(1) DEFAULT FALSE NOT NULL;

ficali les comilles, si no quan pujem a produccio fallara: ALTER TABLE `vn`.`itemShelvingSale` ADD `isPicked` TINYINT(1) DEFAULT FALSE NOT NULL;
sergiodt marked this conversation as resolved
db/changes/234001/01-itemShelvingSale.sql Outdated
@ -0,0 +288,4 @@
END$$
DELIMITER ;
ALTER TABLE vn.itemShelvingSale DROP COLUMN IF EXISTS isPicked;
alexm commented 2023-09-28 05:31:45 +00:00
Member
Copy Link

Aci tambe les comilles

Aci tambe les comilles
sergiodt marked this conversation as resolved
modules/item/back/methods/item-shelving-sale/itemShelvingSaleByCollection.js Outdated
@ -0,0 +5,4 @@
accepts: [
{
arg: 'id',
type: 'Number',
alexm commented 2023-09-28 05:33:47 +00:00
Member
Copy Link

Fijat per si deuries haver ficat required: true en el id

Fijat per si deuries haver ficat required: true en el id
sergiodt marked this conversation as resolved
modules/item/back/methods/item-shelving-sale/itemShelvingSaleSetQuantity.js Outdated
@ -0,0 +5,4 @@
accepts: [
{
arg: 'id',
type: 'Number',
alexm commented 2023-09-28 05:32:53 +00:00
Member
Copy Link

Els tipos preferiblement els posem en minuscula tot type: 'number'

Els tipos preferiblement els posem en minuscula tot type: 'number'
sergiodt marked this conversation as resolved
modules/item/back/methods/item-shelving-sale/itemShelvingSaleSetQuantity.js Outdated
@ -0,0 +6,4 @@
{
arg: 'id',
type: 'Number',
description: 'The sale id',
alexm commented 2023-09-28 05:33:39 +00:00
Member
Copy Link

Fijat per si deuries haver ficat required: true en el id

Fijat per si deuries haver ficat required: true en el id
sergiodt marked this conversation as resolved
sergiodt added 1 commit 2023-09-28 06:09:21 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
4048627c76 refs #5890 fix: format
sergiodt added 1 commit 2023-09-28 06:10:34 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
65b0ec387f refs #5890 fix: format
alexm approved these changes 2023-09-28 06:26:02 +00:00
Dismissed
alexm added 2 commits 2023-09-28 11:26:14 +00:00
gitea/salix/pipeline/head This commit looks good Details
e51df063d3 refs #5890 feat: add userId in rawSql
alexm dismissed alexm’s review 2023-09-28 11:26:15 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexm approved these changes 2023-09-28 11:31:35 +00:00
Dismissed
carlosap added 1 commit 2023-09-28 13:14:21 +00:00
gitea/salix/pipeline/head This commit looks good Details
b4c67c088c Merge branch 'dev' into 5890--itemShelvingAsignado
carlosap added 2 commits 2023-09-28 13:15:30 +00:00
carlosap added 1 commit 2023-09-29 08:53:12 +00:00
gitea/salix/pipeline/head This commit looks good Details
934b4c4b36 refs #5890
carlosap dismissed alexm’s review 2023-09-29 08:53:12 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

carlosap refused to review 2023-09-29 10:11:57 +00:00
carlosap requested review from alexm 2023-09-29 10:17:29 +00:00
alexm added 1 commit 2023-09-29 10:18:40 +00:00
gitea/salix/pipeline/head This commit looks good Details
53ab694ad4 Merge branch 'dev' into 5890--itemShelvingAsignado
alexm approved these changes 2023-09-29 10:19:27 +00:00
alexm merged commit 3966f6a53a into dev 2023-09-29 10:28:22 +00:00
alexm deleted branch 5890--itemShelvingAsignado 2023-09-29 10:28:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1767
No description provided.
Delete Branch "5890--itemShelvingAsignado"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?