verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

5134-ModelsSalix #1768

Merged
alexm merged 9 commits from 5134-ModelsSalix into dev 2023-09-28 11:20:22 +00:00
Conversation 0 Commits 9 Files Changed 19 +289 -5
sergiodt commented 2023-09-27 12:04:54 +00:00
Member
Copy Link
No description provided.
sergiodt added 6 commits 2023-09-27 12:04:55 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
6eb88f8ab7 refs #5134 feat: models
gitea/salix/pipeline/head This commit looks good Details
9ef4ba9bef refs #5134 feat: add saleMistake model
gitea/salix/pipeline/head This commit looks good Details
a6047d257b refs #5134 feat:modelsSalix
gitea/salix/pipeline/head This commit looks good Details
1ec51d94cf refs #5134 feat: correct sql
gitea/salix/pipeline/head There was a failure building this commit Details
ed1d8ca94f refs #5134 feat: models
gitea/salix/pipeline/head This commit looks good Details
2ea2943eca refs #5134 feat: models
sergiodt requested review from alexm 2023-09-27 12:05:36 +00:00
alexm reviewed 2023-09-28 05:25:12 +00:00
db/changes/233401/00-models.sql Outdated
@ -0,0 +10,4 @@
INSERT INTO `salix`.`ACL` (model, property, accessType, permission, principalType, principalId)
VALUES('WorkerMistake', '*', 'WRITE', 'ALLOW', 'ROLE', 'coolerBoss');
INSERT INTO `salix`.`ACL` (model, property, accessType, permission, principalType, principalId)
alexm commented 2023-09-28 05:25:12 +00:00
Member
Copy Link

Este esta duplicat. Tambe pots agrupar els inserts ficant:

INSERT INTO salix.ACL (model, property, accessType, permission, principalType, principalId)
VALUES
('WorkerMistakeType', '', 'READ', 'ALLOW', 'ROLE', 'employee'),
('WorkerMistakeType', '', 'READ', 'ALLOW', 'ROLE', 'employee'),
('WorkerMistakeType', '', 'READ', 'ALLOW', 'ROLE', 'employee'),
('WorkerMistakeType', '', 'READ', 'ALLOW', 'ROLE', 'employee'),
('WorkerMistakeType', '*', 'READ', 'ALLOW', 'ROLE', 'employee');

Este esta duplicat. Tambe pots agrupar els inserts ficant: INSERT INTO `salix`.`ACL` (model, property, accessType, permission, principalType, principalId) VALUES ('WorkerMistakeType', '*', 'READ', 'ALLOW', 'ROLE', 'employee'), ('WorkerMistakeType', '*', 'READ', 'ALLOW', 'ROLE', 'employee'), ('WorkerMistakeType', '*', 'READ', 'ALLOW', 'ROLE', 'employee'), ('WorkerMistakeType', '*', 'READ', 'ALLOW', 'ROLE', 'employee'), ('WorkerMistakeType', '*', 'READ', 'ALLOW', 'ROLE', 'employee');
sergiodt marked this conversation as resolved
alexm requested changes 2023-09-28 05:29:15 +00:00
modules/shelving/back/models/shelving.json Outdated
@ -12,2 +12,2 @@
"id": true,
"description": "Identifier"
"description": "Identifier",
"id": true
alexm commented 2023-09-28 05:28:29 +00:00
Member
Copy Link

Ns si es gitea, pero te com una tabulacio de mes

Ns si es gitea, pero te com una tabulacio de mes
sergiodt marked this conversation as resolved
modules/ticket/back/model-config.json Outdated
@ -30,2 +36,4 @@
"dataSource": "vn"
},
"ExpeditionMistakeType": {
"dataSource": "vn"
alexm commented 2023-09-28 05:28:09 +00:00
Member
Copy Link

Afegir tabulacio

Afegir tabulacio
sergiodt marked this conversation as resolved
modules/ticket/back/models/expeditionMistakeType.json
@ -0,0 +10,4 @@
"code": {
"id":true,
"type": "string"
alexm commented 2023-09-28 05:27:55 +00:00
Member
Copy Link

LLevar espai

LLevar espai
sergiodt marked this conversation as resolved
modules/worker/back/models/mistakeType.json Outdated
@ -0,0 +7,4 @@
}
},
"properties": {
"id": {
alexm commented 2023-09-28 05:28:59 +00:00
Member
Copy Link

Tabulació

Tabulació
sergiodt marked this conversation as resolved
modules/worker/back/models/workerMistake.json Outdated
@ -0,0 +7,4 @@
}
},
"properties": {
"id": {
alexm commented 2023-09-28 05:29:05 +00:00
Member
Copy Link

Tabulació

Tabulació
sergiodt marked this conversation as resolved
modules/worker/back/models/workerMistakeType.json Outdated
@ -0,0 +7,4 @@
}
},
"properties": {
"code": {
alexm commented 2023-09-28 05:29:10 +00:00
Member
Copy Link

Tabulació

Tabulació
sergiodt marked this conversation as resolved
alexm reviewed 2023-09-28 05:30:37 +00:00
db/changes/233401/00-models.sql Outdated
@ -0,0 +1,29 @@
INSERT INTO `salix`.`ACL` ( model, property, accessType, permission, principalType, principalId)
alexm commented 2023-09-28 05:30:37 +00:00
Member
Copy Link

Canviar de carpeta a 234001

Canviar de carpeta a 234001
sergiodt marked this conversation as resolved
sergiodt added 1 commit 2023-09-28 05:43:26 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
a86469ccd2 refs #5134 fix: format
sergiodt added 1 commit 2023-09-28 05:52:36 +00:00
gitea/salix/pipeline/head This commit looks good Details
18de92f9e7 refs #5134 fix: format
alexm approved these changes 2023-09-28 05:53:32 +00:00
Dismissed
sergiodt added 1 commit 2023-09-28 06:18:56 +00:00
gitea/salix/pipeline/head This commit looks good Details
22f71e6147 Merge branch 'dev' into 5134-ModelsSalix
sergiodt dismissed alexm’s review 2023-09-28 06:18:56 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

sergiodt requested review from alexm 2023-09-28 06:19:39 +00:00
alexm approved these changes 2023-09-28 06:23:02 +00:00
alexm merged commit 2f22c2807a into dev 2023-09-28 11:20:22 +00:00
alexm deleted branch 5134-ModelsSalix 2023-09-28 11:20:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1768
No description provided.
Delete Branch "5134-ModelsSalix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?