verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 67 Releases Wiki Activity

6254-collection_getTickets #1769

Merged
alexm merged 8 commits from 6254-collection_getTickets into test 2023-10-02 07:52:01 +00:00
Conversation 0 Commits 8 Files Changed 7 +194 -3
alexm commented 2023-09-28 06:31:29 +00:00
Member
Copy Link
No description provided.
alexm added 2 commits 2023-09-28 06:31:31 +00:00
gitea/salix/pipeline/head This commit looks good Details
1307d4727c refs #6254 feat(collection): add getTickets
alexm requested review from jgallego 2023-09-28 06:32:02 +00:00
alexm requested review from sergiodt 2023-09-28 06:32:07 +00:00
jgallego requested changes 2023-09-28 09:11:33 +00:00
back/methods/collection/getTickets.js Outdated
@ -0,0 +151,4 @@
if (barcodes && barcodes.length) {
for (const barcode of barcodes) {
if (barcode.saleFk === sale.saleFk) {
for (let prop in barcode) {
jgallego commented 2023-09-28 09:08:28 +00:00
Owner
Copy Link

quin es el criteri que gastes per a posar for (let o for(const ?

quin es el criteri que gastes per a posar for (let o for(const ?
alexm commented 2023-09-28 12:20:44 +00:00
Author
Member
Copy Link

Si deurien de ser els dos const pq no se modifiquen. si els volgueres modificar seria let

Si deurien de ser els dos const pq no se modifiquen. si els volgueres modificar seria let
carlosap marked this conversation as resolved
loopback/locale/es.json Outdated
@ -321,1 +320,3 @@
}
"Ticket without Route": "Ticket sin ruta",
"The ticket is in preparation": "El ticket [{{ticketId}}]({{{ticketUrl}}}) del comercial {{salesPersonId}} està en preparación",
"Invalid collection or ticket": "Invalid collection or ticket"
jgallego commented 2023-09-28 09:11:29 +00:00
Owner
Copy Link

traduir

traduir
carlosap marked this conversation as resolved
carlosap added 1 commit 2023-09-29 10:30:38 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
9a7cb3ef7b refs #6254 collection_getTickets
carlosap requested review from jgallego 2023-09-29 10:30:41 +00:00
carlosap added 1 commit 2023-09-29 10:31:21 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
2820b0253f Merge branch 'test' into 6254-collection_getTickets
carlosap added 2 commits 2023-09-29 11:47:36 +00:00
gitea/salix/pipeline/head This commit looks good Details
17e6cffa3d refs #6254 collection getTickets
carlosap added 1 commit 2023-09-29 12:11:17 +00:00
gitea/salix/pipeline/head This commit looks good Details
0e5a7bbb85 refs #6254
carlosap added 1 commit 2023-09-29 12:16:43 +00:00
gitea/salix/pipeline/head This commit looks good Details
c469a221c7 refs #6254
jgallego removed review request for sergiodt 2023-09-29 17:18:13 +00:00
jgallego approved these changes 2023-09-29 18:00:41 +00:00
alexm merged commit 83d1e5cb74 into test 2023-10-02 07:52:01 +00:00
alexm deleted branch 6254-collection_getTickets 2023-10-02 07:52:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1769
No description provided.
Delete Branch "6254-collection_getTickets"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?