ref #6138 setPasword created #1798

Merged
jorgep merged 6 commits from 6138-setPassword into dev 2023-10-19 10:48:17 +00:00
Member
No description provided.
jorgep added 1 commit 2023-10-16 14:00:43 +00:00
gitea/salix/pipeline/head This commit looks good Details
bd535374d8
ref #6138 setPasword created
jorgep requested review from alexm 2023-10-16 14:00:59 +00:00
jorgep added the
CR / Tests passed
label 2023-10-16 14:01:25 +00:00
alexm requested changes 2023-10-17 05:24:49 +00:00
@ -67,3 +70,3 @@
]
};
// Añadir filter para sacar user
Member

Quitar comentario

Quitar comentario
jorgep marked this conversation as resolved
jorgep added 1 commit 2023-10-17 06:29:37 +00:00
gitea/salix/pipeline/head This commit looks good Details
48003b5d03
ref #6138
jorgep requested review from alexm 2023-10-17 06:30:00 +00:00
alexm requested changes 2023-10-18 05:15:22 +00:00
@ -0,0 +32,4 @@
tx = await Self.beginTransaction({});
myOptions.transaction = tx;
}
try {
Member

Faltaría añadir la validación que pone en la tarea:
Definir un método en worker setPassword, que permita cambiar la contraseña: por un jefe del trabajador o por rrhh si el usuario no tiene el correo verificado.

Faltaría añadir la validación que pone en la tarea: Definir un método en worker setPassword, que permita cambiar la contraseña: por un jefe del trabajador o por rrhh *si el usuario no tiene el correo verificado*.
Author
Member

Lo hable con Javi y me dijo que solo por el jefe del trabajador

Lo hable con Javi y me dijo que solo por el jefe del trabajador
jorgep marked this conversation as resolved
jorgep requested review from alexm 2023-10-18 06:26:11 +00:00
alexm approved these changes 2023-10-18 07:15:24 +00:00
Dismissed
alexm requested review from jgallego 2023-10-18 07:15:31 +00:00
jorgep added 1 commit 2023-10-18 11:41:37 +00:00
jorgep added 1 commit 2023-10-19 06:26:35 +00:00
jgallego requested changes 2023-10-19 06:32:03 +00:00
@ -0,0 +37,4 @@
if (!isSubordinate) throw new UserError('You don\'t have enough privileges.');
await models.VnUser.setPassword(args.workerFk, args.newPass, myOptions);
await models.VnUser.updateAll({id: args.workerFk}, {emailVerified: 1}, myOptions);
Owner

pon true

pon true
jorgep marked this conversation as resolved
jorgep added 1 commit 2023-10-19 07:37:02 +00:00
jorgep dismissed alexm’s review 2023-10-19 07:37:03 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jorgep added 1 commit 2023-10-19 07:52:39 +00:00
gitea/salix/pipeline/head This commit looks good Details
52b14cf8b4
ref #6138 fix emailVerified
jorgep requested review from jgallego 2023-10-19 07:53:40 +00:00
jgallego approved these changes 2023-10-19 07:59:45 +00:00
jorgep merged commit f88e266933 into dev 2023-10-19 10:48:17 +00:00
jorgep deleted branch 6138-setPassword 2023-10-19 10:48:17 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1798
No description provided.