5979-getAppOrigin #1799

Merged
pablone merged 17 commits from 5979-getAppOrigin into master 2023-10-23 05:06:44 +00:00
Member
No description provided.
pablone added 2 commits 2023-10-16 16:24:51 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
033c02750b
refactor(origin): .origin por getUrl()
pablone added 1 commit 2023-10-16 16:39:25 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
afe4c676fc
fix(url): la ulr termina con / no es necesario añadir el texto
pablone added 1 commit 2023-10-16 16:42:18 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
4f911e644c
fix: remove console.log refs #5979
pablone added 2 commits 2023-10-19 06:36:44 +00:00
pablone added 1 commit 2023-10-19 06:39:40 +00:00
pablone added 1 commit 2023-10-19 06:40:42 +00:00
pablone changed title from WIP: 5979-getAppOrigin to 5979-getAppOrigin 2023-10-19 06:51:47 +00:00
pablone added 1 commit 2023-10-19 06:51:58 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
f1b11fdca2
Merge branch 'master' into 5979-getAppOrigin
pablone requested review from alexm 2023-10-19 11:30:30 +00:00
pablone added 2 commits 2023-10-19 16:23:18 +00:00
pablone added 1 commit 2023-10-19 16:23:40 +00:00
gitea/salix/pipeline/head This commit looks good Details
dad67539c5
Merge branch 'master' into 5979-getAppOrigin
alexm requested changes 2023-10-20 07:28:16 +00:00
@ -27,3 +27,3 @@
Self.getTickets = async(ctx, id, print, options) => {
const userId = ctx.req.accessToken.userId;
const origin = ctx.req.headers.origin;
const url = Self.app.models.Url.getUrl();
Member

Sense await funciona?

Sense await funciona?
pablone marked this conversation as resolved
@ -17,0 +22,4 @@
},{
"accessType": "READ",
"principalType": "ROLE",
"principalId": "$everyone",
Member

Este quedarem en llevarlo no?

Este quedarem en llevarlo no?
pablone marked this conversation as resolved
@ -116,3 +116,3 @@
async function notifyStateChange(ctx, workerId, claim, state) {
const models = Self.app.models;
const origin = ctx.req.headers.origin;
const url = models.Url.getUrl();
Member

Aci tambe faltaria el await

Aci tambe faltaria el await
pablone marked this conversation as resolved
@ -129,3 +129,3 @@
async function notifyPickUp(ctx, workerId, claim) {
const origin = ctx.req.headers.origin;
const models = Self.app.models;
const url = models.Url.getUrl();
Member

Aci tambe faltaria el await

Aci tambe faltaria el await
pablone marked this conversation as resolved
pablone added 2 commits 2023-10-20 10:53:12 +00:00
pablone requested review from alexm 2023-10-20 10:55:23 +00:00
pablone added 1 commit 2023-10-20 10:55:36 +00:00
gitea/salix/pipeline/head This commit looks good Details
0237517f0c
Merge branch 'master' into 5979-getAppOrigin
alexm requested changes 2023-10-20 11:03:25 +00:00
@ -14,3 +14,3 @@
"principalId": "$everyone",
"permission": "ALLOW"
}
},{
Member

Quitar ACL

Quitar ACL
pablone added 2 commits 2023-10-20 11:08:08 +00:00
alexm approved these changes 2023-10-20 11:20:30 +00:00
pablone merged commit 59e91221cb into master 2023-10-23 05:06:44 +00:00
pablone deleted branch 5979-getAppOrigin 2023-10-23 05:06:44 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1799
No description provided.